[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2289: fix: assemble executable jar for pd and store

["imbajin (via GitHub)" <gi...@apache.org>]

imbajin commented on code in PR #2289:
URL: https://github.com/apache/incubator-hugegraph/pull/2289#discussion_r1299937571


##########
hugegraph-pd/hg-pd-service/pom.xml:
##########
@@ -138,11 +144,13 @@
                 <executions>
                     <execution>
                         <configuration>
-                            <classifier>spring-boot</classifier>
                             <mainClass>
                                 org.apache.hugegraph.pd.boot.HugePDServer
                             </mainClass>
                         </configuration>
+                        <goals>
+                            <goal>repackage</goal>
+                        </goals>

Review Comment:
   we need some comment here?



##########
hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh:
##########
@@ -115,7 +115,7 @@ echo "Starting HugeGraphPDServer..."
 
 # Turn on security check
 exec ${JAVA} ${JAVA_OPTIONS} -jar -Dspring.config.location=${CONF}/application.yml \

Review Comment:
   could also add `process name` param for it..... refer server/toolchain/computer, so as `store` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org