[GitHub] [apisix-dashboard] moonming commented on pull request #535: feat: refactor apis for existing check and other apis

[GitBox <gi...@apache.org>]

moonming commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-703636101


   This method is not right. What is the license of the original code?
   
   nic-chen <no...@github.com>于2020年10月5日 周一下午9:31写道：
   
   >
   >
   > *@nic-chen* commented on this pull request.
   >
   >
   >
   >
   > ------------------------------
   >
   >
   >
   >
   > In api/internal/core/store/query.go
   > <https://github.com/apache/apisix-dashboard/pull/535#discussion_r499599913>
   > :
   >
   >
   > > + * Licensed to the Apache Software Foundation (ASF) under one or more
   >
   > + * contributor license agreements.  See the NOTICE file distributed with
   >
   > + * this work for additional information regarding copyright ownership.
   >
   > + * The ASF licenses this file to You under the Apache License, Version 2.0
   >
   > + * (the "License"); you may not use this file except in compliance with
   >
   > + * the License.  You may obtain a copy of the License at
   >
   > + *
   >
   > + *     http://www.apache.org/licenses/LICENSE-2.0
   >
   > + *
   >
   > + * Unless required by applicable law or agreed to in writing, software
   >
   > + * distributed under the License is distributed on an "AS IS" BASIS,
   >
   > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   >
   > + * See the License for the specific language governing permissions and
   >
   > + * limitations under the License.
   >
   > + */
   >
   > +// Copyright 2017 The Kubernetes Authors.
   >
   >
   >
   > some code copy from Kubernetes dashboard , so i think it's better to keep
   > their license. what do you think ? @moonming <https://github.com/moonming>
   >
   >
   >
   >
   > —
   > You are receiving this because you were mentioned.
   >
   >
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix-dashboard/pull/535#discussion_r499599913>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBKYXWZRPE5RE5STNBV3SJHDBRANCNFSM4SDXIAEQ>
   > .
   >
   >
   > --
   Thanks,
   Ming Wen
   Twitter: _WenMing
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org