[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3933: Support timestamp in partition path

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3933:
URL: https://github.com/apache/iceberg/pull/3933#discussion_r789373751



##########
File path: api/src/main/java/org/apache/iceberg/types/Conversions.java
##########
@@ -71,6 +71,12 @@ public static Object fromPartitionString(Type type, String asString) {
         return new BigDecimal(asString);
       case DATE:
         return Literal.of(asString).to(Types.DateType.get()).value();
+      case TIMESTAMP:
+        if (!asString.contains("T")) {
+          return java.sql.Timestamp.valueOf(asString).getTime() * 1000;

Review comment:
       I was wondering here if we can find do the same inversion that's in the hive code for parsing this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org