You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by 岑玉海 <ce...@163.com> on 2017/12/06 03:44:01 UTC
回复： [DISCUSSION] Refactory on spark related modules
+1
Best regards!
Yuhai Cen
在2017年12月6日 11:43，David CaiQiang<da...@gmail.com> 写道：
+1
-----
Best Regards
David Cai
--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
Re: 回复： [DISCUSSION] Refactory on spark related modules
Posted by 雨中漫步 <60...@qq.com>.
+1
------------------ Original ------------------
From: "Sandeep Purohit";<ph...@gmail.com>;
Send time: Friday, Dec 8, 2017 1:04 AM
To: "dev"<de...@carbondata.apache.org>;
Subject: Re: 回复： [DISCUSSION] Refactory on spark related modules
+1 agreed with ravindra
-Sandeep
On Thu, Dec 7, 2017 at 5:26 AM, Sangeeta Gulia <sa...@knoldus.in>
wrote:
> +1 to Ravindra's suggestion.
>
> On Wed, Dec 6, 2017 at 12:56 PM, Ravindra Pesala <ra...@gmail.com>
> wrote:
>
> > Hi Jacky,
> >
> > I don't think it's a good idea to create new modules for spark2.1 and
> > spark2.2 versions.We should not create a module for every spark minor
> > version. Earlier we had a modules spark and spark2 because of major
> version
> > change and a lot of interfaces are changed along with it. If it is a
> major
> > version we can create module but not for every minor version. And
> regarding
> > the IDE issue, it is just a developer understanding of how to switch the
> > versions so we can have FAQ for that and also we can check the solution
> for
> > IDE problem.
> >
> > And about merging spark2 and spark-common module, There is no harm in
> > keeping all the RDD in common package as if you need to support any major
> > spark versions like spark3.0 in future may require separating the modules
> > again.
> >
> > Regards,
> > Ravindra.
> >
> > On 6 December 2017 at 11:00, wyphao.2007 <wy...@163.com> wrote:
> >
> > > +1
> > >
> > >
> > >
> > >
> > >
> > >
> > > 在2017年12月06 11时44分, "岑玉海"<ce...@163.com>写道:
> > >
> > > +1
> > >
> > >
> > >
> > >
> > >
> > >
> > > Best regards!
> > > Yuhai Cen
> > >
> > >
> > > 在2017年12月6日 11:43，David CaiQiang<da...@gmail.com> 写道：
> > > +1
> > >
> > >
> > >
> > > -----
> > > Best Regards
> > > David Cai
> > > --
> > > Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.
> > > n5.nabble.com/
> > >
> >
> >
> >
> > --
> > Thanks & Regards,
> > Ravi
> >
>
>
>
> --
> Warm Regards,
>
> Sangeeta Gulia
> Software Consultant
> Knoldus Software LLP
>
Re: 回复： [DISCUSSION] Refactory on spark related modules
Posted by Sandeep Purohit <ph...@gmail.com>.
+1 agreed with ravindra
-Sandeep
On Thu, Dec 7, 2017 at 5:26 AM, Sangeeta Gulia <sa...@knoldus.in>
wrote:
> +1 to Ravindra's suggestion.
>
> On Wed, Dec 6, 2017 at 12:56 PM, Ravindra Pesala <ra...@gmail.com>
> wrote:
>
> > Hi Jacky,
> >
> > I don't think it's a good idea to create new modules for spark2.1 and
> > spark2.2 versions.We should not create a module for every spark minor
> > version. Earlier we had a modules spark and spark2 because of major
> version
> > change and a lot of interfaces are changed along with it. If it is a
> major
> > version we can create module but not for every minor version. And
> regarding
> > the IDE issue, it is just a developer understanding of how to switch the
> > versions so we can have FAQ for that and also we can check the solution
> for
> > IDE problem.
> >
> > And about merging spark2 and spark-common module, There is no harm in
> > keeping all the RDD in common package as if you need to support any major
> > spark versions like spark3.0 in future may require separating the modules
> > again.
> >
> > Regards,
> > Ravindra.
> >
> > On 6 December 2017 at 11:00, wyphao.2007 <wy...@163.com> wrote:
> >
> > > +1
> > >
> > >
> > >
> > >
> > >
> > >
> > > 在2017年12月06 11时44分, "岑玉海"<ce...@163.com>写道:
> > >
> > > +1
> > >
> > >
> > >
> > >
> > >
> > >
> > > Best regards!
> > > Yuhai Cen
> > >
> > >
> > > 在2017年12月6日 11:43，David CaiQiang<da...@gmail.com> 写道：
> > > +1
> > >
> > >
> > >
> > > -----
> > > Best Regards
> > > David Cai
> > > --
> > > Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.
> > > n5.nabble.com/
> > >
> >
> >
> >
> > --
> > Thanks & Regards,
> > Ravi
> >
>
>
>
> --
> Warm Regards,
>
> Sangeeta Gulia
> Software Consultant
> Knoldus Software LLP
>
Re: 回复： [DISCUSSION] Refactory on spark related modules
Posted by Sangeeta Gulia <sa...@knoldus.in>.
+1 to Ravindra's suggestion.
On Wed, Dec 6, 2017 at 12:56 PM, Ravindra Pesala <ra...@gmail.com>
wrote:
> Hi Jacky,
>
> I don't think it's a good idea to create new modules for spark2.1 and
> spark2.2 versions.We should not create a module for every spark minor
> version. Earlier we had a modules spark and spark2 because of major version
> change and a lot of interfaces are changed along with it. If it is a major
> version we can create module but not for every minor version. And regarding
> the IDE issue, it is just a developer understanding of how to switch the
> versions so we can have FAQ for that and also we can check the solution for
> IDE problem.
>
> And about merging spark2 and spark-common module, There is no harm in
> keeping all the RDD in common package as if you need to support any major
> spark versions like spark3.0 in future may require separating the modules
> again.
>
> Regards,
> Ravindra.
>
> On 6 December 2017 at 11:00, wyphao.2007 <wy...@163.com> wrote:
>
> > +1
> >
> >
> >
> >
> >
> >
> > 在2017年12月06 11时44分, "岑玉海"<ce...@163.com>写道:
> >
> > +1
> >
> >
> >
> >
> >
> >
> > Best regards!
> > Yuhai Cen
> >
> >
> > 在2017年12月6日 11:43，David CaiQiang<da...@gmail.com> 写道：
> > +1
> >
> >
> >
> > -----
> > Best Regards
> > David Cai
> > --
> > Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.
> > n5.nabble.com/
> >
>
>
>
> --
> Thanks & Regards,
> Ravi
>
--
Warm Regards,
Sangeeta Gulia
Software Consultant
Knoldus Software LLP
Re: 回复： [DISCUSSION] Refactory on spark related modules
Posted by Ravindra Pesala <ra...@gmail.com>.
Hi Jacky,
I don't think it's a good idea to create new modules for spark2.1 and
spark2.2 versions.We should not create a module for every spark minor
version. Earlier we had a modules spark and spark2 because of major version
change and a lot of interfaces are changed along with it. If it is a major
version we can create module but not for every minor version. And regarding
the IDE issue, it is just a developer understanding of how to switch the
versions so we can have FAQ for that and also we can check the solution for
IDE problem.
And about merging spark2 and spark-common module, There is no harm in
keeping all the RDD in common package as if you need to support any major
spark versions like spark3.0 in future may require separating the modules
again.
Regards,
Ravindra.
On 6 December 2017 at 11:00, wyphao.2007 <wy...@163.com> wrote:
> +1
>
>
>
>
>
>
> 在2017年12月06 11时44分, "岑玉海"<ce...@163.com>写道:
>
> +1
>
>
>
>
>
>
> Best regards!
> Yuhai Cen
>
>
> 在2017年12月6日 11:43，David CaiQiang<da...@gmail.com> 写道：
> +1
>
>
>
> -----
> Best Regards
> David Cai
> --
> Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.
> n5.nabble.com/
>
--
Thanks & Regards,
Ravi
Re:回复： [DISCUSSION] Refactory on spark related modules
Posted by "wyphao.2007" <wy...@163.com>.
+1
在2017年12月06 11时44分, "岑玉海"<ce...@163.com>写道:
+1
Best regards!
Yuhai Cen
在2017年12月6日 11:43，David CaiQiang<da...@gmail.com> 写道：
+1
-----
Best Regards
David Cai
--
Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/