You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/07/03 10:30:53 UTC
Review Request 60592: Configure the `network/ports` isolator watch
interval.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60592/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-7576
https://issues.apache.org/jira/browse/MESOS-7576
Repository: mesos
Description
-------
Add the `--container_ports_watch_interval` option to tune the
interval at which the `network/ports` isolator scans for rogue
listening ports.
Diffs
-----
src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION
src/slave/flags.hpp c6803eb54e09a5497755e1e5fef2872193eacba6
src/slave/flags.cpp 398768656b5fa3b7c85474de2b4b008bf7b85cb3
src/tests/containerizer/network_ports_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/60592/diff/1/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 60592: Configure the `network/ports` isolator watch
interval.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60592/#review184515
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Aug. 21, 2017, 11:50 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60592/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 11:50 p.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `--container_ports_watch_interval` option to tune the
> interval at which the `network/ports` isolator scans for rogue
> listening ports.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION
> src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60
> src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f
>
>
> Diff: https://reviews.apache.org/r/60592/diff/14/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60592: Configure the `network/ports` isolator watch
interval.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60592/
-----------------------------------------------------------
(Updated Aug. 21, 2017, 3:50 p.m.)
Review request for mesos, Qian Zhang and Jiang Yan Xu.
Changes
-------
Addressed review feedback.
Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675
Repository: mesos
Description
-------
Added the `--container_ports_watch_interval` option to tune the
interval at which the `network/ports` isolator scans for rogue
listening ports.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION
src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60
src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f
Diff: https://reviews.apache.org/r/60592/diff/11/
Changes: https://reviews.apache.org/r/60592/diff/10-11/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 60592: Configure the `network/ports` isolator watch
interval.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60592/#review183299
-----------------------------------------------------------
src/slave/flags.hpp
Line 146 (original), 146 (patched)
<https://reviews.apache.org/r/60592/#comment259336>
Not yours, better to add a comment `// ENABLE_PORT_MAPPING_ISOLATOR`.
src/slave/flags.hpp
Lines 150 (patched)
<https://reviews.apache.org/r/60592/#comment259337>
Ditto.
- Qian Zhang
On Aug. 19, 2017, 5:17 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60592/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2017, 5:17 a.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `--container_ports_watch_interval` option to tune the
> interval at which the `network/ports` isolator scans for rogue
> listening ports.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION
> src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60
> src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f
>
>
> Diff: https://reviews.apache.org/r/60592/diff/10/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60592: Configure the `network/ports` isolator watch
interval.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60592/
-----------------------------------------------------------
(Updated Aug. 18, 2017, 9:17 p.m.)
Review request for mesos, Qian Zhang and Jiang Yan Xu.
Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675
Repository: mesos
Description
-------
Added the `--container_ports_watch_interval` option to tune the
interval at which the `network/ports` isolator scans for rogue
listening ports.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION
src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60
src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f
Diff: https://reviews.apache.org/r/60592/diff/10/
Changes: https://reviews.apache.org/r/60592/diff/9-10/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 60592: Configure the `network/ports` isolator watch
interval.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60592/#review183194
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/ports.cpp
Lines 199 (patched)
<https://reviews.apache.org/r/60592/#comment259209>
s/watchInterval/_watchInterval
src/slave/flags.hpp
Lines 147 (patched)
<https://reviews.apache.org/r/60592/#comment259207>
We should put this flag under `ENABLE_NETWORK_PORTS_ISOLATOR` rather than `ENABLE_PORT_MAPPING_ISOLATOR`.
src/slave/flags.cpp
Lines 1006 (patched)
<https://reviews.apache.org/r/60592/#comment259208>
Kill the `\n` in the end.
- Qian Zhang
On July 3, 2017, 6:30 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60592/
> -----------------------------------------------------------
>
> (Updated July 3, 2017, 6:30 p.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the `--container_ports_watch_interval` option to tune the
> interval at which the `network/ports` isolator scans for rogue
> listening ports.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION
> src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60
> src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f
>
>
> Diff: https://reviews.apache.org/r/60592/diff/9/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>