[GitHub] liubao68 commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #479: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/479#discussion_r160118733
 
 

 ##########
 File path: service-registry/src/main/java/io/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
 ##########
 @@ -100,17 +111,23 @@ public void pullInstances() {
       return;
     }
 
-    List<MicroserviceInstance> pulledInstances = RegistryUtils.findServiceInstance(appId,
+    MicroserviceInstances microserviceInstances = RegistryUtils.findServiceInstances(appId,
         microserviceName,
-        DefinitionConst.VERSION_RULE_ALL);
-    if (pulledInstances == null) {
+        DefinitionConst.VERSION_RULE_ALL,
+        revision);
+    if (microserviceInstances == null) {
+      return;
+    }
+    if (!microserviceInstances.isNeedRefresh()) {
 
 Review comment:
   There are conflicts with https://github.com/apache/incubator-servicecomb-java-chassis/pull/486

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services