You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2020/09/03 13:34:39 UTC

[GitHub] [jmeter] jloisel opened a new pull request #616: Fix #63255

jloisel opened a new pull request #616:
URL: https://github.com/apache/jmeter/pull/616


   ## Description
   Fix bug: https://bz.apache.org/bugzilla/show_bug.cgi?id=63255
   
   ## Motivation and Context
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ## How Has This Been Tested?
   Tested manually.
   
   ## Types of changes
   - Bug fix (non-breaking change which fixes an issue
   
   ## Checklist:
   - [x] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] jloisel commented on pull request #616: Fix #63255

Posted by GitBox <gi...@apache.org>.
jloisel commented on pull request #616:
URL: https://github.com/apache/jmeter/pull/616#issuecomment-688285398


   Hi Philippe, Thanks for reviewing this pull request. Do you have any idea on how to fix both the issue (do not escape remove escapes from escaped json, which relies on `\`) and support escaping `\`? I may have missed something. 
   
   I thought about splitting the method to have both old and new behavior, depending on the context.
   
   One thing is sure, replacing `\\` by `\` when the content contains a variable is causing issues as it alters the content of the request. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] jloisel commented on pull request #616: Bug 63255 - HTTP Post Request fails due to triple backslash in Body Data

Posted by GitBox <gi...@apache.org>.
jloisel commented on pull request #616:
URL: https://github.com/apache/jmeter/pull/616#issuecomment-705467637


   No problem. I didn't find any good approach to solve this issue as of now. Even splitting into multiple methods doesn't seem an easy task, given how low level this code is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] pmouawad commented on pull request #616: Bug 63255 - HTTP Post Request fails due to triple backslash in Body Data

Posted by GitBox <gi...@apache.org>.
pmouawad commented on pull request #616:
URL: https://github.com/apache/jmeter/pull/616#issuecomment-701941485


   Hello @jloisel ,
   Your approach of splitting looks a good approach to me.
   Thanks for contributing.
   Regards


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] pmouawad closed pull request #616: Bug 63255 - HTTP Post Request fails due to triple backslash in Body Data

Posted by GitBox <gi...@apache.org>.
pmouawad closed pull request #616:
URL: https://github.com/apache/jmeter/pull/616


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] pmouawad commented on pull request #616: Fix #63255

Posted by GitBox <gi...@apache.org>.
pmouawad commented on pull request #616:
URL: https://github.com/apache/jmeter/pull/616#issuecomment-686615666


   Thanks for PR, but as you can guess, it cannot be merged without:
   
   - Existing tests passing
   - Additional tests for this particular case
   
   If you can update the PR, it would be nice.
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] jloisel commented on pull request #616: Fix #63255

Posted by GitBox <gi...@apache.org>.
jloisel commented on pull request #616:
URL: https://github.com/apache/jmeter/pull/616#issuecomment-686559554


   The fix is probably not adequate, since it breaks other parts of JMeter. But it's impossible to use JMeter in the case you have escaped json in POST request data with variables within.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] pmouawad closed pull request #616: Bug 63255 - HTTP Post Request fails due to triple backslash in Body Data

Posted by GitBox <gi...@apache.org>.
pmouawad closed pull request #616:
URL: https://github.com/apache/jmeter/pull/616


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] jloisel commented on pull request #616: Bug 63255 - HTTP Post Request fails due to triple backslash in Body Data

Posted by GitBox <gi...@apache.org>.
jloisel commented on pull request #616:
URL: https://github.com/apache/jmeter/pull/616#issuecomment-705467637


   No problem. I didn't find any good approach to solve this issue as of now. Even splitting into multiple methods doesn't seem an easy task, given how low level this code is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] pmouawad commented on pull request #616: Bug 63255 - HTTP Post Request fails due to triple backslash in Body Data

Posted by GitBox <gi...@apache.org>.
pmouawad commented on pull request #616:
URL: https://github.com/apache/jmeter/pull/616#issuecomment-705178598


   Hello,
   I'll close PR as it is not mergeable currently.
   
   Thanks
   Regards


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org