You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "ButterBright (via GitHub)" <gi...@apache.org> on 2025/07/13 14:35:23 UTC

[PR] Deprecate the indexed_only field in TagSpec [skywalking-banyandb]

ButterBright opened a new pull request, #703:
URL: https://github.com/apache/skywalking-banyandb/pull/703

   <!--
       ⚠️ Please make sure to read this template first, pull requests that don't accord with this template
       maybe closed without notice.
       Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
       Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
   -->
   
   <!-- ==== πŸ› Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist πŸ‘‡ ====
   ### Fix <bug description or the bug issue number or bug issue link>
   - [ ] Add a unit test to verify that the fix works.
   - [ ] Explain briefly why the bug exists and how to fix it.
        ==== πŸ› Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist πŸ‘† ==== -->
   
   <!-- ==== πŸ†• Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist πŸ‘‡ ====
   ### <Feature description>
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
        ==== πŸ†• Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist πŸ‘† ==== -->
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#<issue number>.
   - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate the indexed_only field in TagSpec [skywalking-banyandb]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #703:
URL: https://github.com/apache/skywalking-banyandb/pull/703#discussion_r2203411864


##########
banyand/stream/block.go:
##########
@@ -584,25 +584,28 @@ func (bc *blockCursor) loadData(tmpBlock *block) bool {
 		bc.elementIDs = append(bc.elementIDs, tmpBlock.elementIDs[s:e+1]...)
 	}
 
-	for i, projection := range bc.bm.tagProjection {
+	for _, cf := range tmpBlock.tagFamilies {
 		tf := tagFamily{
-			name: projection.Family,
+			name: cf.name,
 		}
-		for j, name := range projection.Names {
+		for i := range cf.tags {

Review Comment:
   This change iterates over all tag families instead of respecting the query projection (`bc.bm.tagProjection`), which may return unwanted tags. Consider filtering `tmpBlock.tagFamilies` by the projection’s `Family` and `Names` to preserve the original projection logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove the indexed_only field in TagSpec [skywalking-banyandb]

Posted by "ButterBright (via GitHub)" <gi...@apache.org>.
ButterBright commented on PR #703:
URL: https://github.com/apache/skywalking-banyandb/pull/703#issuecomment-3072518079

   I will update the ui accordingly in a follow-up pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove the indexed_only field in TagSpec [skywalking-banyandb]

Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #703:
URL: https://github.com/apache/skywalking-banyandb/pull/703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deprecate the indexed_only field in TagSpec [skywalking-banyandb]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #703:
URL: https://github.com/apache/skywalking-banyandb/pull/703#discussion_r2203412573


##########
api/proto/banyandb/database/v1/schema.proto:
##########
@@ -50,7 +50,7 @@ message TagSpec {
   // indexed_only indicates whether the tag is stored
   // True: It's indexed only, but not stored
   // False: it's stored and indexed
-  bool indexed_only = 3;
+  bool indexed_only = 3 [deprecated = true];

Review Comment:
   @hanahmily As we don't keep forward compatibility, once Kai tested, should we remove this permanently, and use id=3 later for other things?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove the indexed_only field in TagSpec [skywalking-banyandb]

Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #703:
URL: https://github.com/apache/skywalking-banyandb/pull/703#discussion_r2209312288


##########
banyand/stream/block.go:
##########
@@ -584,25 +584,28 @@ func (bc *blockCursor) loadData(tmpBlock *block) bool {
 		bc.elementIDs = append(bc.elementIDs, tmpBlock.elementIDs[s:e+1]...)
 	}
 
-	for i, projection := range bc.bm.tagProjection {
+	for _, cf := range tmpBlock.tagFamilies {
 		tf := tagFamily{
-			name: projection.Family,
+			name: cf.name,
 		}
-		for j, name := range projection.Names {
+		for i := range cf.tags {

Review Comment:
   @ButterBright copilot's findings make sense to me. Could you fix this issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove the indexed_only field in TagSpec [skywalking-banyandb]

Posted by "ButterBright (via GitHub)" <gi...@apache.org>.
ButterBright commented on code in PR #703:
URL: https://github.com/apache/skywalking-banyandb/pull/703#discussion_r2213751008


##########
banyand/stream/block.go:
##########
@@ -584,25 +584,28 @@ func (bc *blockCursor) loadData(tmpBlock *block) bool {
 		bc.elementIDs = append(bc.elementIDs, tmpBlock.elementIDs[s:e+1]...)
 	}
 
-	for i, projection := range bc.bm.tagProjection {
+	for _, cf := range tmpBlock.tagFamilies {
 		tf := tagFamily{
-			name: projection.Family,
+			name: cf.name,
 		}
-		for j, name := range projection.Names {
+		for i := range cf.tags {

Review Comment:
   The tag filtering in loadData previously excluded indexed_only tags, which  had to be retrieved by iterating through the projection. After removing the indexed_only field, we could align the implementation with how measures are processed, improving consistency and readability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org