[GitHub] [hive] lcspinter commented on a diff in pull request #3226: HIVE-26157: Change Iceberg storage handler authz URI to metadata location

[GitBox <gi...@apache.org>]

lcspinter commented on code in PR #3226:
URL: https://github.com/apache/hive/pull/3226#discussion_r864831363


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -456,9 +458,19 @@ public boolean isValidMetadataTable(String metaTableName) {
   public URI getURIForAuth(org.apache.hadoop.hive.metastore.api.Table hmsTable) throws URISyntaxException {
     String dbName = hmsTable.getDbName();
     String tableName = hmsTable.getTableName();
-    return new URI(ICEBERG_URI_PREFIX + dbName + "/" + tableName);
+    Optional<String> locationProperty = SessionStateUtil.getProperty(conf, hive_metastoreConstants.META_TABLE_LOCATION);
+    if (locationProperty.isPresent()) {
+      // this property is set during the create operation before the hive table was created
+      // we are returning a dummy iceberg metadata file
+      return new URI(ICEBERG_URI_PREFIX + locationProperty.get() + "/metadata/dummy.metadata.json");

Review Comment:
   yes, we are setting it. That is why I added that additional code change to the SemanticAnalyzer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org