You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/24 03:41:58 UTC
[GitHub] [incubator-apisix] membphis opened a new pull request #1766: feature: add a new option, decide if we remove the "/" at the end of …
membphis opened a new pull request #1766:
URL: https://github.com/apache/incubator-apisix/pull/1766
…the URI before route mathing.
fix #1765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1766: feature: add a new option, decide if we remove the "/" at the end of …
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1766:
URL: https://github.com/apache/incubator-apisix/pull/1766#issuecomment-648567075
@apache/apisix-committers The default value, which one is better? `true` or `false`?
`delete_uri_tail_slash: true`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis merged pull request #1766: feature: add a new option, decide if we remove the "/" at the end of …
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1766:
URL: https://github.com/apache/incubator-apisix/pull/1766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] ShiningRush commented on pull request #1766: feature: add a new option, decide if we remove the "/" at the end of …
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on pull request #1766:
URL: https://github.com/apache/incubator-apisix/pull/1766#issuecomment-648569612
I think `false` would be better, no tricks when matching route except user want.
So can ensure users know what happen when them set `true`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1766: feature: add a new option, decide if we remove the "/" at the end of …
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1766:
URL: https://github.com/apache/incubator-apisix/pull/1766#issuecomment-650857310
> I think `false` would be better, no tricks when matching route except user want.
> So can ensure users know what happen when them set `true`
Ok, I have updated the processing logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org