You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/12/24 03:40:50 UTC
[GitHub] [logging-log4j2] quaff opened a new pull request #450: Document how to disable message pattern lookups
quaff opened a new pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450
It's worth to add a section in manual, I've struggled this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #450: Document how to disable message pattern lookups
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450#discussion_r548530325
##########
File path: src/site/asciidoc/manual/configuration.adoc
##########
@@ -1146,6 +1146,13 @@ included, such as ``${main:\--file:-app.properties}`. This would use the
`MainMapLookup` for a key named `--file`. If the key is not found then
<code>app.properties</code> would be used as the default value.
+[#DisablesMessagePatternLookups]
+== Disables Message Pattern Lookups
+Message is processed (by default) by lookups, for example if you defined
Review comment:
Message is processed (by default)
->
A message is processed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #450: Document how to disable message pattern lookups
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450#discussion_r548530654
##########
File path: src/site/asciidoc/manual/configuration.adoc
##########
@@ -1146,6 +1146,13 @@ included, such as ``${main:\--file:-app.properties}`. This would use the
`MainMapLookup` for a key named `--file`. If the key is not found then
<code>app.properties</code> would be used as the default value.
+[#DisablesMessagePatternLookups]
+== Disables Message Pattern Lookups
+Message is processed (by default) by lookups, for example if you defined
Review comment:
Actually it might be simpler for a native English speaker to rewrite the whole thing instead of editing here which is awkward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers merged pull request #450: Document how to disable message pattern lookups
Posted by GitBox <gi...@apache.org>.
rgoers merged pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] quaff commented on a change in pull request #450: Document how to disable message pattern lookups
Posted by GitBox <gi...@apache.org>.
quaff commented on a change in pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450#discussion_r548769465
##########
File path: src/site/asciidoc/manual/configuration.adoc
##########
@@ -1146,6 +1146,13 @@ included, such as ``${main:\--file:-app.properties}`. This would use the
`MainMapLookup` for a key named `--file`. If the key is not found then
<code>app.properties</code> would be used as the default value.
+[#DisablesMessagePatternLookups]
+== Disables Message Pattern Lookups
+Message is processed (by default) by lookups, for example if you defined
Review comment:
@garydgregory You could merge this PR then polish it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #450: Document how to disable message pattern lookups
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450#discussion_r548530023
##########
File path: src/site/asciidoc/manual/configuration.adoc
##########
@@ -1146,6 +1146,13 @@ included, such as ``${main:\--file:-app.properties}`. This would use the
`MainMapLookup` for a key named `--file`. If the key is not found then
<code>app.properties</code> would be used as the default value.
+[#DisablesMessagePatternLookups]
Review comment:
DisablesMessagePatternLookups -> DisablingMessagePatternLookups
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org