You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jianran <gi...@git.apache.org> on 2017/03/28 02:17:01 UTC
[GitHub] spark pull request #17447: [SPARK-20117][Scheduler]TaskSetManager checkSpecu...
GitHub user jianran opened a pull request:
https://github.com/apache/spark/pull/17447
[SPARK-20117][Scheduler]TaskSetManager checkSpeculatableTasks variables immutability and use string interpolation
## What changes were proposed in this pull request?
`TaskSetManager` `checkSpeculatableTasks` variables immutability and use string interpolation
## How was this patch tested?
Existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jianran/spark SPARK-20117
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17447.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17447
----
commit 3911c46892304a5eec7d603dd8a015c9cf1fe0af
Author: jianran.tfh <ji...@taobao.com>
Date: 2017-03-17T09:30:28Z
rdd id info
commit e426dc5243fca185ff0ef8dafcbfcba14e031b83
Author: jianran <ta...@163.com>
Date: 2017-03-17T15:03:05Z
[SPARK-19998] add RDD id info
commit 98393f8e346be0cd1cbe73b6861668e17446990d
Author: jianran.tfh <ji...@taobao.com>
Date: 2017-03-18T13:55:08Z
remove redundant 'not found'
commit 4bd4b8d573e1bd93176e67e8f3487e0292acd6f6
Author: jianran.tfh <ji...@taobao.com>
Date: 2017-03-20T02:24:15Z
remove empty line
commit 7206a47fa1826d82fee50c1a7c70bf50c85dde65
Author: jianran.tfh <ji...@taobao.com>
Date: 2017-03-20T07:26:28Z
Merge branch 'SPARK-19998'
commit 182832310822c41745f2d8a5ba305032c06649ba
Author: jianran.tfh <ji...@taobao.com>
Date: 2017-03-28T01:10:55Z
Merge remote-tracking branch 'upstream/master'
commit ad5ef3cca2956ef689fd3cd33a36eec72cef4ba7
Author: jianran.tfh <ji...@taobao.com>
Date: 2017-03-28T02:12:30Z
TaskSetManager checkSpeculatableTasks variables immutability and Use string interpolation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17447: [SPARK-20117][Scheduler]TaskSetManager checkSpecu...
Posted by jianran <gi...@git.apache.org>.
Github user jianran closed the pull request at:
https://github.com/apache/spark/pull/17447
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17447: [SPARK-20117][Scheduler]TaskSetManager checkSpeculatable...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/17447
I wouldn't bother with the string interpolation change (there is a good argument to be made that string interpolation doesn't gain you anything in patterns like those in this PR where a single string is being concatenated to the end of another); and the var -> val change in a local variable isn't significant enough to justify a PR. Thanks for contributing, but please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17447: [SPARK-20117][Scheduler]TaskSetManager checkSpeculatable...
Posted by jianran <gi...@git.apache.org>.
Github user jianran commented on the issue:
https://github.com/apache/spark/pull/17447
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17447: [SPARK-20117][Scheduler]TaskSetManager checkSpeculatable...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17447
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org