You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by qingwen220 <gi...@git.apache.org> on 2016/09/02 09:18:02 UTC

[GitHub] incubator-eagle pull request #416: Update spark history job feeder config & ...

GitHub user qingwen220 opened a pull request:

    https://github.com/apache/incubator-eagle/pull/416

    Update spark history job feeder config & refactor the code

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qingwen220/incubator-eagle sparkHist

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #416
    
----
commit d28435c3b8dadd9acadac159e572c4d56d8a1f3e
Author: Qingwen Zhao <qi...@gmail.com>
Date:   2016-09-02T08:06:55Z

    Update spark history job feeder config & refactor the code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #416: Update spark history job feeder config & refacto...

Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the issue:

    https://github.com/apache/incubator-eagle/pull/416
  
    @qingwen220 it is a big PR, can you please add description so later on people can reference to see what really happened.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #416: Update spark history job feeder config & ...

Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/416#discussion_r77465606
  
    --- Diff: eagle-jpm/eagle-jpm-spark-history/src/main/resources/application.conf ---
    @@ -45,7 +48,6 @@
         }
       },
       "storm":{
    -    worker.num: 2,
    --- End diff --
    
    i agree with u, and the following commit is the update


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #416: Update spark history job feeder config & ...

Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 closed the pull request at:

    https://github.com/apache/incubator-eagle/pull/416


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #416: Update spark history job feeder config & ...

Posted by pkuwm <gi...@git.apache.org>.
Github user pkuwm commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/416#discussion_r77379043
  
    --- Diff: eagle-jpm/eagle-jpm-spark-history/src/main/resources/application.conf ---
    @@ -45,7 +48,6 @@
         }
       },
       "storm":{
    -    worker.num: 2,
    --- End diff --
    
    Since the app framwork has set the worker number and the this conf has been removed, we need to also move the conf in SparkHistoryJobAppProvider.xml?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---