You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sermojohn <gi...@git.apache.org> on 2017/11/07 10:12:48 UTC
[GitHub] commons-codec pull request #11: CODEC-240 Percent-Encoding codec proposal
GitHub user sermojohn opened a pull request:
https://github.com/apache/commons-codec/pull/11
CODEC-240 Percent-Encoding codec proposal
@garydgregory thank you for the advice, I really appreciate your feedback.
Re-based from trunk, so had to delete and recreate the feature branch, which resulted in closing the initial PR. Please let me know if another process should be followed when merging changes from the trunk.
The changes of the last commit increase of test coverage and decrease slightly the complexity.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sermojohn/commons-codec CODEC-240
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-codec/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit 33aaa7a44a17b674a4bd4ebc3fd163afb7666815
Author: Ioannis Sermetziadis <se...@gmail.com>
Date: 2017-10-02T19:34:52Z
CODEC-240 Percent-Encoding codec proposal. Due to the requirement of supporting a dynamic set of characters to always encode (apart from the non-ASCII that are always encoded), I added a constructor that takes an array of characters to force encode. This is useful because different encoding requirements apply in different parts of the HTTP 1.1 protocol (e.g. for URL, Multipart entity fields, etc.)
commit 67f97973a9442a98f96a2c420e976cbe7c35ecb1
Author: Ioannis Sermetziadis <se...@gmail.com>
Date: 2017-10-13T20:23:10Z
CODEC-240 Refactored PercentCodec to optimize encoding and decoding in regard to performance. Also implemented support for space to '+' conversion.
commit f4a04da253fdf659389e4cb2163b53d695129d68
Author: Ioannis Sermetziadis <se...@gmail.com>
Date: 2017-11-07T09:49:09Z
CODEC-240 Increased test coverage and did minor modification to decrease complexity.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-codec pull request #11: CODEC-240 Percent-Encoding codec proposal
Posted by sermojohn <gi...@git.apache.org>.
Github user sermojohn closed the pull request at:
https://github.com/apache/commons-codec/pull/11
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org