[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #26744: [SPARK-30106][SQL][MINOR][TEST] Fix the test of DynamicPartitionPruningSuite
URL: https://github.com/apache/spark/pull/26744#discussion_r353456144
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
 ##########
 @@ -423,7 +423,7 @@ class DynamicPartitionPruningSuite
           """
             |SELECT * FROM fact_sk f
             |JOIN dim_store s
-            |ON f.date_id = s.store_id
+            |ON f.store_id = s.store_id
 
 Review comment:
   Yes. This should be a join on the partitioned column, `fact_sk.store_id`, because the previous test covers `not a partition column` case. And, `no predicate on the dimension table` should mean `WHERE s.country = 'NL'`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org