You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/08 21:47:59 UTC

[GitHub] [incubator-superset] pkdotson opened a new pull request #11206: feat: home screen mvp

pkdotson opened a new pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206


   ### SUMMARY
   This PR is the first draft of homescreen. The pr also decouples the card components from chartlist and dashboardlist components so that they both can be used more readily throughout homescreen. 
   
   <img width="1789" alt="Screen Shot 2020-10-08 at 2 43 48 PM" src="https://user-images.githubusercontent.com/17326228/95516835-af7d1a80-0974-11eb-913d-b355f66ab0e5.png">
   
   <img width="1774" alt="Screen Shot 2020-10-08 at 2 44 34 PM" src="https://user-images.githubusercontent.com/17326228/95516889-cc195280-0974-11eb-9253-4b87d5d59060.png">
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   Test Plan includes unit test and end to end test which are in development and will be updated during this review.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [x ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/917d02efbd80ef490f121ffb8e2211e919311596?el=desc) will **decrease** coverage by `5.63%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   65.67%   60.04%   -5.64%     
   ==========================================
     Files         835      394     -441     
     Lines       39656    24924   -14732     
     Branches     3604        0    -3604     
   ==========================================
   - Hits        26045    14965   -11080     
   + Misses      13502     9959    -3543     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.04% <100.00%> (-0.88%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `74.56% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.86% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <100.00%> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
   | ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [917d02e...641f5c5](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r513816844



##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -53,6 +57,102 @@ const createFetchResourceMethod = (method: string) => (
   return [];
 };
 
+export const getRecentAcitivtyObjs = (
+  userId: string | number,
+  recent: string,
+  addDangerToast: (arg0: string) => void,
+) => {
+  const getParams = (filters?: Array<any>) => {
+    const params = {
+      order_column: 'changed_on_delta_humanized',
+      order_direction: 'desc',
+      page: 0,
+      page_size: 3,
+      filters,
+    };
+    if (!filters) delete params.filters;
+    return rison.encode(params);
+  };
+  const filters = {
+    // chart and dashbaord uses same filters
+    // for edited and created
+    edited: [
+      {
+        col: 'changed_by',
+        opr: 'rel_o_m',
+        value: `${userId}`,
+      },
+    ],
+    created: [
+      {
+        col: 'created_by',
+        opr: 'rel_o_m',
+        value: `${userId}`,
+      },
+    ],
+  };
+  const baseBatch = [
+    SupersetClient.get({ endpoint: recent }),
+    SupersetClient.get({
+      endpoint: `/api/v1/dashboard/?q=${getParams(filters.edited)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/chart/?q=${getParams(filters.edited)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/dashboard/?q=${getParams(filters.created)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/chart/?q=${getParams(filters.created)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/saved_query/?q=${getParams(filters.created)}`,
+    }),
+  ];
+  return Promise.all(baseBatch).then(
+    // @ts-ignore
+    ([
+      recentsRes,
+      editedDash,
+      editedChart,
+      createdByDash,
+      createdByChart,
+      createdByQuery,
+    ]) => {
+      const res: any = {
+        editedDash: editedDash.json?.result.slice(0, 3),
+        editedChart: editedChart.json?.result.slice(0, 3),
+        createdByDash: createdByDash.json?.result.slice(0, 3),
+        createdByChart: createdByChart.json?.result.slice(0, 3),
+        createdByQuery: createdByQuery.json?.result.slice(0, 3),
+      };
+      if (recentsRes.json.length === 0) {
+        const newBatch = [
+          SupersetClient.get({ endpoint: `/api/v1/chart/?q=${getParams()}` }),
+          SupersetClient.get({
+            endpoint: `/api/v1/dashboard/?q=${getParams()}`,
+          }),
+        ];
+        return Promise.all(newBatch)
+          .then(([chartRes, dashboardRes]) => {
+            res.examples = [
+              ...chartRes.json.result,
+              ...dashboardRes.json.result,
+            ];
+            return res;
+          })
+          .catch(e =>
+            addDangerToast(
+              t('There was an error fetching you recent activity:', e),
+            ),
+          );

Review comment:
       ```suggestion
             .catch(() => addDangerToast(
                 t('There was an error fetching you recent activity'),
               ),
             );
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `5.27%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.33%   -5.28%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26067   -15148     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    15989   -11465     
   + Misses      13660    10078    -3582     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.33% <100.00%> (-0.67%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [451 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...ff22e81](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.58%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   62.03%   -4.59%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26076   -15139     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16175   -11279     
   + Misses      13660     9901    -3759     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `62.03% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `75.80% <0.00%> (-0.39%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <0.00%> (-0.04%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | | |
   | [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | | |
   | [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | | |
   | ... and [436 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...3af819d](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r509948921



##########
File path: superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
##########
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t } from '@superset-ui/core';
+import { useListViewResource, useChartEditModal } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import PropertiesModal from 'src/explore/components/PropertiesModal';
+import { User } from 'src/types/bootstrapTypes';
+import Icon from 'src/components/Icon';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import Chart from 'src/types/Chart';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+import { CardContainer, IconContainer } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface ChartTableProps {
+  addDangerToast: (message: string) => void;
+  addSuccessToast: (message: string) => void;
+  search: string;
+  chartFilter?: string;
+  user?: User;
+}
+
+function ChartTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: ChartTableProps) {
+  const {
+    state: { loading, resourceCollection: charts, bulkSelectEnabled },
+    setResourceCollection: setCharts,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Chart>('chart', t('chart'), addDangerToast);
+
+  const {
+    sliceCurrentlyEditing,
+    openChartEditModal,
+    handleChartUpdated,
+    closeChartEditModal,
+  } = useChartEditModal(setCharts, charts);
+
+  const [chartFilter, setChartFilter] = useState('Favorite');
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (chartFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'chart_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [chartFilter]);
+
+  return (
+    <>
+      {sliceCurrentlyEditing && (
+        <PropertiesModal
+          onHide={closeChartEditModal}
+          onSave={handleChartUpdated}
+          show
+          slice={sliceCurrentlyEditing}
+        />
+      )}
+
+      <SubMenu
+        activeChild={chartFilter}
+        name=""
+        // eslint-disable-next-line react/no-children-prop
+        children={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setChartFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setChartFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> Chart{' '}

Review comment:
       Linter is propagating these. I'll delete!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r511706466



##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    if (e.item_url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    return '';

Review comment:
       typescript expects a string. Instead of doing null | string I use the empty '' to pass as null instead of the dual type.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r512423993



##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -53,19 +53,33 @@ const StyledHeader = styled.header`
     li.active > a,
     li.active > div,
     li > a:hover,
+    li > a:focus,
     li > div:hover {
-      background-color: ${({ theme }) => theme.colors.secondary.light4};
+      background: ${({ theme }) => theme.colors.secondary.light4};
       border-bottom: none;
       border-radius: 4px;

Review comment:
       ```suggestion
         border-radius: ${({ theme }) => theme.borderRadius}px;
   ```
   ^ touching up someone else's work, but we don't get to break out this theme variable every day ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-718283949


   > something looks a little off here .... 4k changes and 119 files changed 🤔
   
   Looks like commits from `master` got merged in here rather than a rebase.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.44%`.
   > The diff coverage is `58.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   62.20%   -4.45%     
   ==========================================
     Files         863      868       +5     
     Lines       41048    41559     +511     
     Branches     3693     3792      +99     
   ==========================================
   - Hits        27359    25852    -1507     
   - Misses      13592    15528    +1936     
   - Partials       97      179      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.55% <58.88%> (-0.38%)` | :arrow_down: |
   | #python | `61.99% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.69% <21.62%> (-22.20%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `58.49% <56.86%> (-20.46%)` | :arrow_down: |
   | ... and [227 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...512ecc0](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-719248989


   A huge milestone! Thanks for all the great work @pkdotson and bearing with the back and forth. Looking forward to more exciting improvements to come!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.43%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   65.43%   60.99%   -4.44%     
   ==========================================
     Files         829      392     -437     
     Lines       39200    24555   -14645     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        25649    14977   -10672     
   + Misses      13444     9578    -3866     
   + Partials      107        0     -107     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.99% <100.00%> (+0.38%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `74.56% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.86% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <0.00%> (-0.43%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.20% <0.00%> (-0.06%)` | :arrow_down: |
   | ... and [435 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [9785667...f190768](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas merged pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.32%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.24%   -5.33%     
   ==========================================
     Files         860      415     -445     
     Lines       40874    25852   -15022     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15834   -11376     
   + Misses      13566    10018    -3548     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.24% <100.00%> (-0.70%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | ... and [444 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...69cda75](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.82%`.
   > The diff coverage is `79.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.82%   -4.83%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26063   -14985     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    16113   -11246     
   + Misses      13592     9950    -3642     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.82% <79.41%> (-0.14%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <ø> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <50.00%> (-2.76%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.87% <100.00%> (+0.45%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.15% <100.00%> (+0.15%)` | :arrow_up: |
   | ... and [409 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-718286546


   I think it's because of `package-lock.json`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `5.21%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.39%   -5.22%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26067   -15148     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16004   -11450     
   + Misses      13660    10063    -3597     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.39% <100.00%> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | ... and [447 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r513048853



##########
File path: superset-frontend/src/views/CRUD/chart/ChartCard.tsx
##########
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { useFavoriteStatus } from 'src/views/CRUD/hooks';
+import { SupersetClient, t } from '@superset-ui/core';
+import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
+import Icon from 'src/components/Icon';
+import Chart from 'src/types/Chart';
+
+import ListViewCard from 'src/components/ListViewCard';
+import Label from 'src/components/Label';
+import { Dropdown, Menu } from 'src/common/components';
+import FaveStar from 'src/components/FaveStar';
+import FacePile from 'src/components/FacePile';
+
+const FAVESTAR_BASE_URL = '/superset/favstar/slice';
+
+interface ChartCardProps {
+  chart: Chart;
+  hasPerm: (perm: string) => boolean;
+  openChartEditModal: (chart: Chart) => void;
+  bulkSelectEnabled: boolean;
+  addDangerToast: (msg: string) => void;
+  addSuccessToast: (msg: string) => void;
+  refreshData: () => void;
+  loading: boolean;
+}
+
+export default function ChartCard({
+  chart,
+  hasPerm,
+  openChartEditModal,
+  bulkSelectEnabled,
+  addDangerToast,
+  addSuccessToast,
+  refreshData,
+  loading,
+}: ChartCardProps) {
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+  const [, fetchFaveStar, saveFaveStar, favoriteStatus] = useFavoriteStatus(
+    {},
+    FAVESTAR_BASE_URL,
+    addDangerToast,
+  );
+  function handleChartDelete({ id, slice_name: sliceName }: Chart) {
+    SupersetClient.delete({
+      endpoint: `/api/v1/chart/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        addSuccessToast(t('Deleted: %s', sliceName));
+      },
+      () => {
+        addDangerToast(t('There was an issue deleting: %s', sliceName));
+      },
+    );
+  }

Review comment:
       openChartEditModal is coming from a hook I set up in utils




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `5.59%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.01%   -5.60%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26067   -15148     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    15906   -11548     
   + Misses      13660    10161    -3499     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.01% <100.00%> (-0.99%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.33%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.31%   -5.34%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26000   -15048     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15942   -11417     
   + Misses      13592    10058    -3534     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.31% <100.00%> (-0.65%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...8924264](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.61%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.99%   -4.62%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26078   -15137     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16168   -11286     
   + Misses      13660     9910    -3750     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.99% <100.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.53% <0.00%> (-0.50%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.35% <0.00%> (ø)` | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...ff22e81](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-714288002


   A few other little things that we discussed in person. They should not be blockers here, and could be followed up on other PRs, but I wanted to put them "on paper":
   * It would be great to share/reuse the media queries with cards (keeping it DRY), so they benefit other card views.
   * Maybe instead of living in `superset-frontend/src/views/CRUD/welcome` it should live in `superset-frontend/src/views/welcome` as its own thing.
   * If _may be of benefit to decouple all the card variants (Recent/Chart/Dashboard/SavedQuery/(eventually...)SearchResult). If doing so, then they should _all_ probably continue to use the common `ListVIewCard` under the hood, which could be renamed as `BaseCard` or similar. All of these could live in the main `components` directory, perhaps hierarchically nested.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.79%`.
   > The diff coverage is `58.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.77%   -4.80%     
   ==========================================
     Files         860      869       +9     
     Lines       40874    41318     +444     
     Branches     3694     3769      +75     
   ==========================================
   - Hits        27210    25525    -1685     
   - Misses      13566    15613    +2047     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.71% <58.88%> (-0.25%)` | :arrow_down: |
   | #python | `61.22% <ø> (-0.73%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [238 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...6fb9516](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.29%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.35%   -5.30%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26063   -14985     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15991   -11368     
   + Misses      13592    10072    -3520     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.35% <100.00%> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <0.00%> (-2.76%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...512ecc0](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r513816844



##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -53,6 +57,102 @@ const createFetchResourceMethod = (method: string) => (
   return [];
 };
 
+export const getRecentAcitivtyObjs = (
+  userId: string | number,
+  recent: string,
+  addDangerToast: (arg0: string) => void,
+) => {
+  const getParams = (filters?: Array<any>) => {
+    const params = {
+      order_column: 'changed_on_delta_humanized',
+      order_direction: 'desc',
+      page: 0,
+      page_size: 3,
+      filters,
+    };
+    if (!filters) delete params.filters;
+    return rison.encode(params);
+  };
+  const filters = {
+    // chart and dashbaord uses same filters
+    // for edited and created
+    edited: [
+      {
+        col: 'changed_by',
+        opr: 'rel_o_m',
+        value: `${userId}`,
+      },
+    ],
+    created: [
+      {
+        col: 'created_by',
+        opr: 'rel_o_m',
+        value: `${userId}`,
+      },
+    ],
+  };
+  const baseBatch = [
+    SupersetClient.get({ endpoint: recent }),
+    SupersetClient.get({
+      endpoint: `/api/v1/dashboard/?q=${getParams(filters.edited)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/chart/?q=${getParams(filters.edited)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/dashboard/?q=${getParams(filters.created)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/chart/?q=${getParams(filters.created)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/saved_query/?q=${getParams(filters.created)}`,
+    }),
+  ];
+  return Promise.all(baseBatch).then(
+    // @ts-ignore
+    ([
+      recentsRes,
+      editedDash,
+      editedChart,
+      createdByDash,
+      createdByChart,
+      createdByQuery,
+    ]) => {
+      const res: any = {
+        editedDash: editedDash.json?.result.slice(0, 3),
+        editedChart: editedChart.json?.result.slice(0, 3),
+        createdByDash: createdByDash.json?.result.slice(0, 3),
+        createdByChart: createdByChart.json?.result.slice(0, 3),
+        createdByQuery: createdByQuery.json?.result.slice(0, 3),
+      };
+      if (recentsRes.json.length === 0) {
+        const newBatch = [
+          SupersetClient.get({ endpoint: `/api/v1/chart/?q=${getParams()}` }),
+          SupersetClient.get({
+            endpoint: `/api/v1/dashboard/?q=${getParams()}`,
+          }),
+        ];
+        return Promise.all(newBatch)
+          .then(([chartRes, dashboardRes]) => {
+            res.examples = [
+              ...chartRes.json.result,
+              ...dashboardRes.json.result,
+            ];
+            return res;
+          })
+          .catch(e =>
+            addDangerToast(
+              t('There was an error fetching you recent activity:', e),
+            ),
+          );

Review comment:
       ```suggestion
             .catch(() => addDangerToast(
                 t('There was an error fetching you recent activity:'),
               ),
             );
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.65%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.91%   -4.66%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    16074   -11136     
   + Misses      13566     9887    -3679     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.91% <ø> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `92.10% <0.00%> (-2.49%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `98.83% <0.00%> (-1.17%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `81.77% <0.00%> (-0.43%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (-0.12%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <0.00%> (ø)` | |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <0.00%> (ø)` | |
   | ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...d97dd73](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.66%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.90%   -4.67%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    16071   -11139     
   + Misses      13566     9890    -3676     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.90% <ø> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `92.10% <0.00%> (-2.49%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `98.83% <0.00%> (-1.17%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.44%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `81.77% <0.00%> (-0.43%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (-0.12%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <0.00%> (ø)` | |
   | ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...11b387a](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.33%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.23%   -5.34%     
   ==========================================
     Files         860      415     -445     
     Lines       40874    25863   -15011     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15837   -11373     
   + Misses      13566    10026    -3540     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.23% <100.00%> (-0.71%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | ... and [440 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...69cda75](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.29%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.35%   -5.30%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26063   -14985     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15991   -11368     
   + Misses      13592    10072    -3520     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.35% <100.00%> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <0.00%> (-2.76%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.70%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   60.94%   -5.71%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    25989   -15059     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15839   -11520     
   + Misses      13592    10150    -3442     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.94% <100.00%> (-1.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [457 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...8924264](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.55%`.
   > The diff coverage is `58.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   62.09%   -4.56%     
   ==========================================
     Files         863      868       +5     
     Lines       41048    41559     +511     
     Branches     3693     3792      +99     
   ==========================================
   - Hits        27359    25806    -1553     
   - Misses      13592    15574    +1982     
   - Partials       97      179      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.55% <58.88%> (-0.38%)` | :arrow_down: |
   | #python | `61.82% <100.00%> (-0.14%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.69% <21.62%> (-22.20%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `58.49% <56.86%> (-20.46%)` | :arrow_down: |
   | ... and [232 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...512ecc0](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.43%`.
   > The diff coverage is `59.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   62.13%   -4.44%     
   ==========================================
     Files         860      867       +7     
     Lines       40874    41276     +402     
     Branches     3694     3774      +80     
   ==========================================
   - Hits        27210    25646    -1564     
   - Misses      13566    15449    +1883     
   - Partials       98      181      +83     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.70% <59.61%> (-0.27%)` | :arrow_down: |
   | #python | `61.79% <ø> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `67.24% <48.57%> (-32.76%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [218 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...e12c2b9](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r512444754



##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,124 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { Empty } from 'src/common/components';
+import { t, styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const ButtonContainer = styled.div`
+  Button {
+    svg {
+      color: ${({ theme }) => theme.colors.grayscale.light5};
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const tableIcon = {
+    RECENTS: 'union.png',
+    DASHBOARDS: 'empty-dashboard.png',
+    CHARTS: 'empty-charts.png',
+    SAVED_QUERIES: 'empty-queries.png',
+  };
+  const mine = (
+    <div>{`No ${
+      tableName === 'SAVED_QUERIES'
+        ? t('saved queries')
+        : t(`${tableName.toLowerCase()}`)
+    } yet`}</div>
+  );
+  const recent = (
+    <div className="no-recents">
+      {t(
+        `Recently ${tab?.toLowerCase()} charts, dashboards, and saved queries will appear here`,

Review comment:
       ```suggestion
           `Recently charts, dashboards, and saved queries will appear here`,
           t('Recently %s charts, dashboards, and saved queries will appear here, tab?.toLowerCase())
   ```
   Just to make it one-click committable ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r512423100



##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx
##########
@@ -34,13 +37,15 @@ describe('Welcome', () => {
       isActive: true,
     },
   };
-  it('is valid', () => {
-    expect(React.isValidElement(<Welcome {...mockedProps} />)).toBe(true);
+  const wrapper = shallow(<Welcome {...mockedProps} />, {
+    context: { store },
   });
-  it('renders 3 Tab, Panel, and Row components', () => {
-    const wrapper = shallow(<Welcome {...mockedProps} />);
-    expect(wrapper.find(Tab)).toHaveLength(3);
-    expect(wrapper.find(Panel)).toHaveLength(3);
-    expect(wrapper.find(Row)).toHaveLength(3);
+
+  it('is renders', () => {

Review comment:
       ```suggestion
     it('renders', () => {
   ```
   Grammar nit ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514473282



##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getRecentAcitivtyObjs, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface ActivityObjects {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  margin-top: ${({ theme }) => theme.gridUnit * -4}px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: ${({ theme }) => theme.gridUnit * 3}px;
+    margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  }
+  .ant-card-meta-title {
+    font-weight: ${({ theme }) => theme.typography.weights.bold};
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: ActivityObjects) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: ActivityObjects) => {
+    if (e.sql) return 'sql';
+    if (e.url?.includes('dashboard')) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.includes('explore') || e.item_url?.includes('explore')) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getRecentAcitivtyObjs(user.userId, recent, addDangerToast)
+      .then(res => {
+        const data: any = {
+          Created: [
+            ...res.createdByChart,
+            ...res.createdByDash,
+            ...res.createdByQuery,
+          ],
+          Edited: [...res.editedChart, ...res.editedDash],
+        };
+        if (res.viewed) {
+          const filtered = reject(res.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = res.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);

Review comment:
       Those are from `recent_activities` (they could be either dashboard or card) after my fix in  #11481
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r512431433



##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx
##########
@@ -0,0 +1,159 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { SupersetClient, t } from '@superset-ui/core';
+import rison from 'rison';
+import { Dropdown, Menu } from 'src/common/components';
+import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
+import ListViewCard from 'src/components/ListViewCard';
+import Icon from 'src/components/Icon';
+import Label from 'src/components/Label';
+import FacePile from 'src/components/FacePile';
+import FaveStar from 'src/components/FaveStar';
+import { DashboardCardProps, Dashboard } from 'src/views/CRUD/types';
+import { createErrorHandler } from 'src/views/CRUD/utils';
+import { useFavoriteStatus } from 'src/views/CRUD/hooks';
+
+const FAVESTAR_BASE_URL = '/superset/favstar/Dashboard';
+
+function DashboardCard({
+  isChart,

Review comment:
       Looks like on like 81, this code may have shared code between charts/dashboards, so perhaps that line and the `cardTitle` aren't needed anymore either. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f14cf9d6dc742be1a1d676db6ab9f5b39d6a2d28?el=desc) will **decrease** coverage by `0.65%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   61.57%   60.92%   -0.66%     
   ==========================================
     Files         838      415     -423     
     Lines       39839    25852   -13987     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        24532    15750    -8782     
   + Misses      15126    10102    -5024     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.92% <100.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (+2.42%)` | :arrow_up: |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (+2.00%)` | :arrow_up: |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [489 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [f14cf9d...3f30d1b](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.71%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.85%   -4.72%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    16059   -11151     
   + Misses      13566     9902    -3664     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.85% <ø> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `92.10% <0.00%> (-2.49%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `98.83% <0.00%> (-1.17%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.30% <0.00%> (-0.84%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.86% <0.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `81.77% <0.00%> (-0.43%)` | :arrow_down: |
   | ... and [447 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...d97dd73](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514476210



##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getRecentAcitivtyObjs, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface ActivityObjects {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  margin-top: ${({ theme }) => theme.gridUnit * -4}px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: ${({ theme }) => theme.gridUnit * 3}px;
+    margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  }
+  .ant-card-meta-title {
+    font-weight: ${({ theme }) => theme.typography.weights.bold};
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: ActivityObjects) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: ActivityObjects) => {
+    if (e.sql) return 'sql';
+    if (e.url?.includes('dashboard')) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.includes('explore') || e.item_url?.includes('explore')) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getRecentAcitivtyObjs(user.userId, recent, addDangerToast)
+      .then(res => {
+        const data: any = {
+          Created: [
+            ...res.createdByChart,
+            ...res.createdByDash,
+            ...res.createdByQuery,
+          ],
+          Edited: [...res.editedChart, ...res.editedDash],
+        };
+        if (res.viewed) {
+          const filtered = reject(res.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = res.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);

Review comment:
       This also could be a result of the broken recents api. It would return duplicates like this as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514000670



##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/ActivityTable_spec.tsx
##########
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styledMount as mount } from 'spec/helpers/theming';
+import thunk from 'redux-thunk';
+import fetchMock from 'fetch-mock';
+
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+import configureStore from 'redux-mock-store';
+import ActivityTable from 'src/views/CRUD/welcome/ActivityTable';
+
+const mockStore = configureStore([thunk]);
+const store = mockStore({});
+
+const chartsEndpoint = 'glob:*/api/v1/chart/?*';
+const dashboardEndpoint = 'glob:*/api/v1/dashboard/?*';
+const savedQueryEndpoint = 'glob:*/api/v1/saved_query/?*';
+
+fetchMock.get(chartsEndpoint, {
+  result: [
+    {
+      slice_name: 'ChartyChart',
+      changed_on_utc: '24 Feb 2014 10:13:14',
+      url: '/fakeUrl/explore',
+      id: '4',
+      table: {},
+    },
+  ],
+});
+
+fetchMock.get(dashboardEndpoint, {
+  result: [
+    {
+      dashboard_title: 'Dashboard_Test',
+      changed_on_utc: '24 Feb 2014 10:13:14',
+      url: '/fakeUrl/dashboard',
+      id: '3',
+    },
+  ],
+});
+
+fetchMock.get(savedQueryEndpoint, {
+  result: [],
+});
+
+describe('ActivityTable', () => {
+  const activityProps = {
+    user: {
+      userId: '1',
+    },
+    activityFilter: 'Edited',
+  };
+  const wrapper = mount(<ActivityTable {...activityProps} />, {
+    context: { store },
+  });
+
+  beforeAll(async () => {
+    await waitForComponentToPaint(wrapper);
+  });
+
+  it('the component renders ', () => {
+    expect(wrapper.find(ActivityTable)).toExist();
+  });
+
+  it('calls batch method and renders ListViewCArd', async () => {
+    const chartCall = fetchMock.calls(/chart\/\?q/);
+    const dashboardCall = fetchMock.calls(/dashboard\/\?q/);
+    expect(chartCall).toHaveLength(2);
+    expect(dashboardCall).toHaveLength(2);

Review comment:
       The home page fires 12 fetch requests on initial page load:
   
   <img src="https://user-images.githubusercontent.com/335541/97531220-f907c680-1970-11eb-9929-8f83130092e8.png" width="500">
   
   This would be quite unscalable for large Superset deployments.
   
   Can we combine some of these or make them async? For example, the non-default tabs shouldn't render when they are not selected.

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { Empty } from 'src/common/components';
+import { t, styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const ButtonContainer = styled.div`
+  Button {
+    svg {
+      color: ${({ theme }) => theme.colors.grayscale.light5};
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const tableIcon = {
+    RECENTS: 'union.png',
+    DASHBOARDS: 'empty-dashboard.png',
+    CHARTS: 'empty-charts.png',
+    SAVED_QUERIES: 'empty-queries.png',

Review comment:
       The images are quite blurry on retina screens. Can we use SVG icons or at least 2x images?
   
   <img src="https://user-images.githubusercontent.com/335541/97531553-a4b11680-1971-11eb-9f6f-5ca502973be2.png" width="400">
   

##########
File path: superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
##########
@@ -16,169 +16,176 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React from 'react';
-import { t, SupersetClient } from '@superset-ui/core';
-import { debounce } from 'lodash';
-import ListView, { FetchDataConfig } from 'src/components/ListView';
+import React, { useEffect, useState } from 'react';
+import { SupersetClient, t } from '@superset-ui/core';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import { Dashboard, DashboardTableProps } from 'src/views/CRUD/types';
 import withToasts from 'src/messageToasts/enhancers/withToasts';
-import { Dashboard } from 'src/types/bootstrapTypes';
+import PropertiesModal from 'src/dashboard/components/PropertiesModal';
+import DashboardCard from 'src/views/CRUD/dashboard/DashboardCard';
+import SubMenu from 'src/components/Menu/SubMenu';
+import Icon from 'src/components/Icon';
+import EmptyState from './EmptyState';
+import { createErrorHandler, CardContainer, IconContainer } from '../utils';
 
-const PAGE_SIZE = 25;
+const PAGE_SIZE = 3;
 
-interface DashboardTableProps {
-  addDangerToast: (message: string) => void;
-  search?: string;
+export interface FilterValue {
+  col: string;
+  operator: string;
+  value: string | boolean | number | null | undefined;
 }
 
-interface DashboardTableState {
-  dashboards: Dashboard[];
-  dashboard_count: number;
-  loading: boolean;
-}
+function DashboardTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: DashboardTableProps) {
+  const {
+    state: { loading, resourceCollection: dashboards, bulkSelectEnabled },
+    setResourceCollection: setDashboards,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Dashboard>(
+    'dashboard',
+    t('dashboard'),
+    addDangerToast,
+  );
 
-class DashboardTable extends React.PureComponent<
-  DashboardTableProps,
-  DashboardTableState
-> {
-  columns = [
-    {
-      accessor: 'dashboard_title',
-      Header: 'Dashboard',
-      Cell: ({
-        row: {
-          original: { url, dashboard_title: dashboardTitle },
-        },
-      }: {
-        row: {
-          original: {
-            url: string;
-            dashboard_title: string;
-          };
-        };
-      }) => <a href={url}>{dashboardTitle}</a>,
-    },
-    {
-      accessor: 'changed_by.first_name',
-      Header: 'Modified By',
-      Cell: ({
-        row: {
-          original: { changed_by_name: changedByName, changedByUrl },
-        },
-      }: {
-        row: {
-          original: {
-            changed_by_name: string;
-            changedByUrl: string;
-          };
-        };
-      }) => <a href={changedByUrl}>{changedByName}</a>,
-    },
-    {
-      accessor: 'changed_on_delta_humanized',
-      Header: 'Modified',
-      Cell: ({
-        row: {
-          original: { changed_on_delta_humanized: changedOn },
-        },
-      }: {
-        row: {
-          original: {
-            changed_on_delta_humanized: string;
-          };
-        };
-      }) => <span className="no-wrap">{changedOn}</span>,
-    },
-  ];
+  const [editModal, setEditModal] = useState<Dashboard | null>(null);
+  const [dashboardFilter, setDashboardFilter] = useState('Favorite');
 
-  initialSort = [{ id: 'changed_on_delta_humanized', desc: true }];
+  const handleDashboardEdit = (edits: Dashboard) => {
+    return SupersetClient.get({
+      endpoint: `/api/v1/dashboard/${edits.id}`,
+    }).then(
+      ({ json = {} }) => {
+        setDashboards(
+          dashboards.map(dashboard => {
+            if (dashboard.id === json.id) {
+              return json.result;
+            }
+            return dashboard;
+          }),
+        );
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(
+          t('An error occurred while fetching dashboards: %s', errMsg),
+        ),
+      ),
+    );
+  };
 
-  constructor(props: DashboardTableProps) {
-    super(props);
-    this.state = {
-      dashboards: [],
-      dashboard_count: 0,
-      loading: false,
-    };
-  }
+  const getFilters = () => {
+    const filters = [];
 
-  componentDidUpdate(prevProps: DashboardTableProps) {
-    if (prevProps.search !== this.props.search) {
-      this.fetchDataDebounced({
-        pageSize: PAGE_SIZE,
-        pageIndex: 0,
-        sortBy: this.initialSort,
-        filters: [],
+    if (dashboardFilter === 'Mine') {
+      filters.push({
+        id: 'owners',
+        operator: 'rel_m_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'dashboard_is_fav',
+        value: true,
       });
     }
+    return filters;
+  };
+  const subMenus = [];
+  if (dashboards.length > 0 && dashboardFilter === 'favorite') {
+    subMenus.push({
+      name: 'Favorite',
+      label: t('Favorite'),
+      onClick: () => setDashboardFilter('Favorite'),
+    });
   }
 
-  fetchData = ({ pageIndex, pageSize, sortBy, filters }: FetchDataConfig) => {
-    this.setState({ loading: true });
-    const filterExps = Object.keys(filters)
-      .map(fk => ({
-        col: fk,
-        opr: filters[fk].filterId,
-        value: filters[fk].filterValue,
-      }))
-      .concat(
-        this.props.search
-          ? [
-              {
-                col: 'dashboard_title',
-                opr: 'ct',
-                value: this.props.search,
-              },
-            ]
-          : [],
-      );
-
-    const queryParams = JSON.stringify({
-      order_column: sortBy[0].id,
-      order_direction: sortBy[0].desc ? 'desc' : 'asc',
-      page: pageIndex,
-      page_size: pageSize,
-      ...(filterExps.length ? { filters: filterExps } : {}),
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
     });
+  }, [dashboardFilter]);
 
-    return SupersetClient.get({
-      endpoint: `/api/v1/dashboard/?q=${queryParams}`,
-    })
-      .then(({ json }) => {
-        this.setState({ dashboards: json.result, dashboard_count: json.count });
-      })
-      .catch(response => {
-        if (response.status === 401) {
-          this.props.addDangerToast(
-            t(
-              "You don't have the necessary permissions to load dashboards. Please contact your administrator.",
+  return (
+    <>
+      <SubMenu
+        activeChild={dashboardFilter}
+        tabs={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setDashboardFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setDashboardFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> Dashboard{' '}
+              </IconContainer>
             ),
-          );
-        } else {
-          this.props.addDangerToast(
-            t('An error occurred while fetching Dashboards'),
-          );
-        }
-      })
-      .finally(() => this.setState({ loading: false }));
-  };
-
-  // sort-comp disabled because of conflict with no-use-before-define rule
-  // eslint-disable-next-line react/sort-comp
-  fetchDataDebounced = debounce(this.fetchData, 200);
-
-  render() {
-    return (
-      <ListView
-        columns={this.columns}
-        data={this.state.dashboards}
-        count={this.state.dashboard_count}
-        pageSize={PAGE_SIZE}
-        fetchData={this.fetchData}
-        loading={this.state.loading}
-        initialSort={this.initialSort}
+            buttonStyle: 'tertiary',
+            onClick: () => {
+              window.location.href = '/dashboard/new';
+            },
+          },
+          {
+            name: 'View All »',
+            buttonStyle: 'link',
+            onClick: () => {
+              window.location.href = '/dashboard/list/';
+            },
+          },
+        ]}
       />
-    );
-  }
+      {editModal && (
+        <PropertiesModal
+          dashboardId={editModal?.id}
+          show
+          onHide={() => setEditModal(null)}

Review comment:
       ```suggestion
             onHide={() => setEditModal(undefined)}
   ```

##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/EmptyState_spec.tsx
##########
@@ -0,0 +1,92 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styledMount as mount } from 'spec/helpers/theming';
+import EmptyState from 'src/views/CRUD/welcome/EmptyState';
+
+describe('EmptyState', () => {
+  const variants = [
+    {
+      tab: 'Favorite',
+      tableName: 'DASHBOARDS',
+    },
+    {
+      tab: 'Mine',
+      tableName: 'DASHBOARDS',
+    },
+    {
+      tab: 'Favorite',
+      tableName: 'CHARTS',
+    },
+    {
+      tab: 'Mine',
+      tableName: 'CHARTS',
+    },
+    {
+      tab: 'Favorite',
+      tableName: 'SAVED_QUERIES',
+    },
+    {
+      tab: 'Mine',
+      tableName: 'SAVED_QUEREIS',
+    },
+  ];
+  const recents = [
+    {
+      tab: 'Viewed',
+      tableName: 'RECENTS',
+    },
+    {
+      tab: 'Edited',
+      tableName: 'RECENTS',
+    },
+    {
+      tab: 'Created',
+      tableName: 'RECENTS',
+    },
+  ];

Review comment:
       It probably makes more sense to make "Created" and "Mine" as the default tabs (or remember users' last selections?).
   
   <img src="https://user-images.githubusercontent.com/335541/97532128-eb534080-1972-11eb-807e-a6e2e87f1213.png" width="500">
   

##########
File path: superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
##########
@@ -16,169 +16,176 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React from 'react';
-import { t, SupersetClient } from '@superset-ui/core';
-import { debounce } from 'lodash';
-import ListView, { FetchDataConfig } from 'src/components/ListView';
+import React, { useEffect, useState } from 'react';
+import { SupersetClient, t } from '@superset-ui/core';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import { Dashboard, DashboardTableProps } from 'src/views/CRUD/types';
 import withToasts from 'src/messageToasts/enhancers/withToasts';
-import { Dashboard } from 'src/types/bootstrapTypes';
+import PropertiesModal from 'src/dashboard/components/PropertiesModal';
+import DashboardCard from 'src/views/CRUD/dashboard/DashboardCard';
+import SubMenu from 'src/components/Menu/SubMenu';
+import Icon from 'src/components/Icon';
+import EmptyState from './EmptyState';
+import { createErrorHandler, CardContainer, IconContainer } from '../utils';
 
-const PAGE_SIZE = 25;
+const PAGE_SIZE = 3;
 
-interface DashboardTableProps {
-  addDangerToast: (message: string) => void;
-  search?: string;
+export interface FilterValue {
+  col: string;
+  operator: string;
+  value: string | boolean | number | null | undefined;
 }
 
-interface DashboardTableState {
-  dashboards: Dashboard[];
-  dashboard_count: number;
-  loading: boolean;
-}
+function DashboardTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: DashboardTableProps) {
+  const {
+    state: { loading, resourceCollection: dashboards, bulkSelectEnabled },
+    setResourceCollection: setDashboards,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Dashboard>(
+    'dashboard',
+    t('dashboard'),
+    addDangerToast,
+  );
 
-class DashboardTable extends React.PureComponent<
-  DashboardTableProps,
-  DashboardTableState
-> {
-  columns = [
-    {
-      accessor: 'dashboard_title',
-      Header: 'Dashboard',
-      Cell: ({
-        row: {
-          original: { url, dashboard_title: dashboardTitle },
-        },
-      }: {
-        row: {
-          original: {
-            url: string;
-            dashboard_title: string;
-          };
-        };
-      }) => <a href={url}>{dashboardTitle}</a>,
-    },
-    {
-      accessor: 'changed_by.first_name',
-      Header: 'Modified By',
-      Cell: ({
-        row: {
-          original: { changed_by_name: changedByName, changedByUrl },
-        },
-      }: {
-        row: {
-          original: {
-            changed_by_name: string;
-            changedByUrl: string;
-          };
-        };
-      }) => <a href={changedByUrl}>{changedByName}</a>,
-    },
-    {
-      accessor: 'changed_on_delta_humanized',
-      Header: 'Modified',
-      Cell: ({
-        row: {
-          original: { changed_on_delta_humanized: changedOn },
-        },
-      }: {
-        row: {
-          original: {
-            changed_on_delta_humanized: string;
-          };
-        };
-      }) => <span className="no-wrap">{changedOn}</span>,
-    },
-  ];
+  const [editModal, setEditModal] = useState<Dashboard | null>(null);

Review comment:
       ```suggestion
     const [editModal, setEditModal] = useState<Dashboard>();
   ```
   
   nit: you can skip `null` by using `undefined`.

##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -83,8 +97,8 @@ export interface ButtonProps {
 
 export interface SubMenuProps {
   buttons?: Array<ButtonProps>;
-  name: string;
-  children?: MenuChild[];
+  name?: string;
+  tabs?: MenuChild[];

Review comment:
       Why change it from `children` to `tabs`? Passing props kind of goes against React's declarative nature.

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getRecentAcitivtyObjs, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface ActivityObjects {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  margin-top: ${({ theme }) => theme.gridUnit * -4}px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: ${({ theme }) => theme.gridUnit * 3}px;
+    margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  }
+  .ant-card-meta-title {
+    font-weight: ${({ theme }) => theme.typography.weights.bold};
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;

Review comment:
       This API seems broken. I just created a fix: https://github.com/apache/incubator-superset/pull/11481
   
   You probably want to set this limit to 6 so that you can fill two full rows.
   
   ![image](https://user-images.githubusercontent.com/335541/97544922-7f2f0780-1987-11eb-9660-2be3f2ef00fd.png)
   

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getRecentAcitivtyObjs, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface ActivityObjects {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  margin-top: ${({ theme }) => theme.gridUnit * -4}px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: ${({ theme }) => theme.gridUnit * 3}px;
+    margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  }
+  .ant-card-meta-title {
+    font-weight: ${({ theme }) => theme.typography.weights.bold};
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: ActivityObjects) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: ActivityObjects) => {
+    if (e.sql) return 'sql';
+    if (e.url?.includes('dashboard')) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.includes('explore') || e.item_url?.includes('explore')) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getRecentAcitivtyObjs(user.userId, recent, addDangerToast)
+      .then(res => {
+        const data: any = {
+          Created: [
+            ...res.createdByChart,
+            ...res.createdByDash,
+            ...res.createdByQuery,
+          ],
+          Edited: [...res.editedChart, ...res.editedDash],
+        };
+        if (res.viewed) {
+          const filtered = reject(res.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = res.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);

Review comment:
       ![image](https://user-images.githubusercontent.com/335541/97545074-b7364a80-1987-11eb-992d-0f8637cc05a1.png)
   
   After switching the tabs back and forth multiple times, I'm getting duplicate cards. You might want to test and debug your this hook a little bit more.
   
   
   I'm also not sure why some cards have icons, some do not. It would also be nice if the whole card can be clickable instead of just the title.

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { Empty } from 'src/common/components';
+import { t, styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const ButtonContainer = styled.div`
+  Button {
+    svg {
+      color: ${({ theme }) => theme.colors.grayscale.light5};
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const tableIcon = {
+    RECENTS: 'union.png',
+    DASHBOARDS: 'empty-dashboard.png',
+    CHARTS: 'empty-charts.png',
+    SAVED_QUERIES: 'empty-queries.png',
+  };
+  const mine = (
+    <div>{`No ${
+      tableName === 'SAVED_QUERIES'
+        ? t('saved queries')
+        : t(`${tableName.toLowerCase()}`)
+    } yet`}</div>
+  );
+  const recent = (
+    <div className="no-recents">
+      {(() => {
+        if (tab === 'Viewed') {
+          return t(
+            `Recently viewed charts, dashboards, and saved queries will appear here`,
+          );
+        }
+        if (tab === 'Created') {
+          return t(
+            'Recently created charts, dashboards, and saved queries will appear here',
+          );
+        }
+        if (tab === 'Examples') {
+          return t(
+            `Recent example charts, dashboards, and saved queries will appear here`,
+          );
+        }
+        if (tab === 'Edited') {
+          return t(
+            `Recently edited charts, dashboards, and saved queries will appear here`,
+          );
+        }
+        return null;
+      })()}
+    </div>
+  );
+  // Mine and Recent Activity(all tabs) tab empty state
+  if (tab === 'Mine' || tableName === 'RECENTS') {

Review comment:
       Nit: can we make the tab name all lowercase to have some consistency?
   
   ```
   if (tab === 'mine' || tableName === 'recents') {
   ```
   
   The idea is to not have to think about which case to use.

##########
File path: superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
##########
@@ -16,169 +16,176 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React from 'react';
-import { t, SupersetClient } from '@superset-ui/core';
-import { debounce } from 'lodash';
-import ListView, { FetchDataConfig } from 'src/components/ListView';
+import React, { useEffect, useState } from 'react';
+import { SupersetClient, t } from '@superset-ui/core';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import { Dashboard, DashboardTableProps } from 'src/views/CRUD/types';
 import withToasts from 'src/messageToasts/enhancers/withToasts';
-import { Dashboard } from 'src/types/bootstrapTypes';
+import PropertiesModal from 'src/dashboard/components/PropertiesModal';
+import DashboardCard from 'src/views/CRUD/dashboard/DashboardCard';
+import SubMenu from 'src/components/Menu/SubMenu';
+import Icon from 'src/components/Icon';
+import EmptyState from './EmptyState';
+import { createErrorHandler, CardContainer, IconContainer } from '../utils';
 
-const PAGE_SIZE = 25;
+const PAGE_SIZE = 3;
 
-interface DashboardTableProps {
-  addDangerToast: (message: string) => void;
-  search?: string;
+export interface FilterValue {
+  col: string;
+  operator: string;
+  value: string | boolean | number | null | undefined;
 }
 
-interface DashboardTableState {
-  dashboards: Dashboard[];
-  dashboard_count: number;
-  loading: boolean;
-}
+function DashboardTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: DashboardTableProps) {
+  const {
+    state: { loading, resourceCollection: dashboards, bulkSelectEnabled },
+    setResourceCollection: setDashboards,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Dashboard>(
+    'dashboard',
+    t('dashboard'),
+    addDangerToast,
+  );
 
-class DashboardTable extends React.PureComponent<
-  DashboardTableProps,
-  DashboardTableState
-> {
-  columns = [
-    {
-      accessor: 'dashboard_title',
-      Header: 'Dashboard',
-      Cell: ({
-        row: {
-          original: { url, dashboard_title: dashboardTitle },
-        },
-      }: {
-        row: {
-          original: {
-            url: string;
-            dashboard_title: string;
-          };
-        };
-      }) => <a href={url}>{dashboardTitle}</a>,
-    },
-    {
-      accessor: 'changed_by.first_name',
-      Header: 'Modified By',
-      Cell: ({
-        row: {
-          original: { changed_by_name: changedByName, changedByUrl },
-        },
-      }: {
-        row: {
-          original: {
-            changed_by_name: string;
-            changedByUrl: string;
-          };
-        };
-      }) => <a href={changedByUrl}>{changedByName}</a>,
-    },
-    {
-      accessor: 'changed_on_delta_humanized',
-      Header: 'Modified',
-      Cell: ({
-        row: {
-          original: { changed_on_delta_humanized: changedOn },
-        },
-      }: {
-        row: {
-          original: {
-            changed_on_delta_humanized: string;
-          };
-        };
-      }) => <span className="no-wrap">{changedOn}</span>,
-    },
-  ];
+  const [editModal, setEditModal] = useState<Dashboard | null>(null);
+  const [dashboardFilter, setDashboardFilter] = useState('Favorite');
 
-  initialSort = [{ id: 'changed_on_delta_humanized', desc: true }];
+  const handleDashboardEdit = (edits: Dashboard) => {
+    return SupersetClient.get({
+      endpoint: `/api/v1/dashboard/${edits.id}`,
+    }).then(
+      ({ json = {} }) => {
+        setDashboards(
+          dashboards.map(dashboard => {
+            if (dashboard.id === json.id) {
+              return json.result;
+            }
+            return dashboard;
+          }),
+        );
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(
+          t('An error occurred while fetching dashboards: %s', errMsg),
+        ),
+      ),
+    );
+  };
 
-  constructor(props: DashboardTableProps) {
-    super(props);
-    this.state = {
-      dashboards: [],
-      dashboard_count: 0,
-      loading: false,
-    };
-  }
+  const getFilters = () => {
+    const filters = [];
 
-  componentDidUpdate(prevProps: DashboardTableProps) {
-    if (prevProps.search !== this.props.search) {
-      this.fetchDataDebounced({
-        pageSize: PAGE_SIZE,
-        pageIndex: 0,
-        sortBy: this.initialSort,
-        filters: [],
+    if (dashboardFilter === 'Mine') {
+      filters.push({
+        id: 'owners',
+        operator: 'rel_m_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'dashboard_is_fav',
+        value: true,
       });
     }
+    return filters;
+  };
+  const subMenus = [];
+  if (dashboards.length > 0 && dashboardFilter === 'favorite') {
+    subMenus.push({
+      name: 'Favorite',
+      label: t('Favorite'),
+      onClick: () => setDashboardFilter('Favorite'),
+    });
   }
 
-  fetchData = ({ pageIndex, pageSize, sortBy, filters }: FetchDataConfig) => {
-    this.setState({ loading: true });
-    const filterExps = Object.keys(filters)
-      .map(fk => ({
-        col: fk,
-        opr: filters[fk].filterId,
-        value: filters[fk].filterValue,
-      }))
-      .concat(
-        this.props.search
-          ? [
-              {
-                col: 'dashboard_title',
-                opr: 'ct',
-                value: this.props.search,
-              },
-            ]
-          : [],
-      );
-
-    const queryParams = JSON.stringify({
-      order_column: sortBy[0].id,
-      order_direction: sortBy[0].desc ? 'desc' : 'asc',
-      page: pageIndex,
-      page_size: pageSize,
-      ...(filterExps.length ? { filters: filterExps } : {}),
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
     });
+  }, [dashboardFilter]);
 
-    return SupersetClient.get({
-      endpoint: `/api/v1/dashboard/?q=${queryParams}`,
-    })
-      .then(({ json }) => {
-        this.setState({ dashboards: json.result, dashboard_count: json.count });
-      })
-      .catch(response => {
-        if (response.status === 401) {
-          this.props.addDangerToast(
-            t(
-              "You don't have the necessary permissions to load dashboards. Please contact your administrator.",
+  return (
+    <>
+      <SubMenu
+        activeChild={dashboardFilter}
+        tabs={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setDashboardFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setDashboardFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> Dashboard{' '}
+              </IconContainer>
             ),
-          );
-        } else {
-          this.props.addDangerToast(
-            t('An error occurred while fetching Dashboards'),
-          );
-        }
-      })
-      .finally(() => this.setState({ loading: false }));
-  };
-
-  // sort-comp disabled because of conflict with no-use-before-define rule
-  // eslint-disable-next-line react/sort-comp
-  fetchDataDebounced = debounce(this.fetchData, 200);
-
-  render() {
-    return (
-      <ListView
-        columns={this.columns}
-        data={this.state.dashboards}
-        count={this.state.dashboard_count}
-        pageSize={PAGE_SIZE}
-        fetchData={this.fetchData}
-        loading={this.state.loading}
-        initialSort={this.initialSort}
+            buttonStyle: 'tertiary',
+            onClick: () => {
+              window.location.href = '/dashboard/new';
+            },
+          },
+          {
+            name: 'View All »',
+            buttonStyle: 'link',
+            onClick: () => {
+              window.location.href = '/dashboard/list/';
+            },
+          },
+        ]}
       />
-    );
-  }
+      {editModal && (
+        <PropertiesModal
+          dashboardId={editModal?.id}
+          show
+          onHide={() => setEditModal(null)}
+          onSubmit={handleDashboardEdit}
+        />
+      )}
+      {dashboards.length > 0 ? (
+        <CardContainer>
+          {dashboards.map(e => (
+            <DashboardCard
+              {...{
+                dashboard: e,
+                hasPerm,
+                bulkSelectEnabled,
+                refreshData,
+                addDangerToast,
+                addSuccessToast,
+                loading,
+                openDashboardEditModal: dashboard => setEditModal(dashboard),
+              }}
+            />
+          ))}
+        </CardContainer>
+      ) : (
+        <EmptyState tableName="DASHBOARDS" tab={dashboardFilter} />

Review comment:
       Currently the`EmptyState` will render even if the data is still loading. You might want to make sure all sections have a valid loading state.

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { Empty } from 'src/common/components';
+import { t, styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;

Review comment:
       Can this be string literals? 
   
   ```
   tab?: 'viewed' | 'created' | 'examples'
   ```

##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,260 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient, styled } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+  .title {
+    font-weight: ${({ theme }) => theme.typography.weights.normal};
+    color: ${({ theme }) => theme.colors.grayscale.light2};
+  }
+  .holder {
+    margin: ${({ theme }) => theme.gridUnit * 2}px;
+  }
+`;
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            window.location.href = `/superset/sqllab?savedQueryId=${query.id}`;
+          }}
+        >
+          {t('Edit')}
+        </Menu.Item>

Review comment:
       ```tsx
           <Menu.Item>
            <a href={`/superset/sqllab?savedQueryId=${query.id}`} target="_blank">{t('Edit')}</a>
           </Menu.Item>
   ```
   
   Why not just a regular anchor element (just like [AntD's official example](https://ant.design/components/dropdown/))? It's more semantically correct and better for a11y. Users can also "cmd + click" to open things in new tabs if they want to.
   
   

##########
File path: superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
##########
@@ -16,169 +16,176 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React from 'react';
-import { t, SupersetClient } from '@superset-ui/core';
-import { debounce } from 'lodash';
-import ListView, { FetchDataConfig } from 'src/components/ListView';
+import React, { useEffect, useState } from 'react';
+import { SupersetClient, t } from '@superset-ui/core';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import { Dashboard, DashboardTableProps } from 'src/views/CRUD/types';
 import withToasts from 'src/messageToasts/enhancers/withToasts';
-import { Dashboard } from 'src/types/bootstrapTypes';
+import PropertiesModal from 'src/dashboard/components/PropertiesModal';
+import DashboardCard from 'src/views/CRUD/dashboard/DashboardCard';
+import SubMenu from 'src/components/Menu/SubMenu';
+import Icon from 'src/components/Icon';
+import EmptyState from './EmptyState';
+import { createErrorHandler, CardContainer, IconContainer } from '../utils';
 
-const PAGE_SIZE = 25;
+const PAGE_SIZE = 3;
 
-interface DashboardTableProps {
-  addDangerToast: (message: string) => void;
-  search?: string;
+export interface FilterValue {
+  col: string;
+  operator: string;
+  value: string | boolean | number | null | undefined;
 }
 
-interface DashboardTableState {
-  dashboards: Dashboard[];
-  dashboard_count: number;
-  loading: boolean;
-}
+function DashboardTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: DashboardTableProps) {
+  const {
+    state: { loading, resourceCollection: dashboards, bulkSelectEnabled },
+    setResourceCollection: setDashboards,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Dashboard>(
+    'dashboard',
+    t('dashboard'),
+    addDangerToast,
+  );
 
-class DashboardTable extends React.PureComponent<
-  DashboardTableProps,
-  DashboardTableState
-> {
-  columns = [
-    {
-      accessor: 'dashboard_title',
-      Header: 'Dashboard',
-      Cell: ({
-        row: {
-          original: { url, dashboard_title: dashboardTitle },
-        },
-      }: {
-        row: {
-          original: {
-            url: string;
-            dashboard_title: string;
-          };
-        };
-      }) => <a href={url}>{dashboardTitle}</a>,
-    },
-    {
-      accessor: 'changed_by.first_name',
-      Header: 'Modified By',
-      Cell: ({
-        row: {
-          original: { changed_by_name: changedByName, changedByUrl },
-        },
-      }: {
-        row: {
-          original: {
-            changed_by_name: string;
-            changedByUrl: string;
-          };
-        };
-      }) => <a href={changedByUrl}>{changedByName}</a>,
-    },
-    {
-      accessor: 'changed_on_delta_humanized',
-      Header: 'Modified',
-      Cell: ({
-        row: {
-          original: { changed_on_delta_humanized: changedOn },
-        },
-      }: {
-        row: {
-          original: {
-            changed_on_delta_humanized: string;
-          };
-        };
-      }) => <span className="no-wrap">{changedOn}</span>,
-    },
-  ];
+  const [editModal, setEditModal] = useState<Dashboard | null>(null);

Review comment:
       I'm not sure about opening the Dashboard Properties modal with this link.
   
   <img src="https://user-images.githubusercontent.com/335541/97531800-34ef5b80-1972-11eb-874f-d735aef3d169.png" width="300">
   
   It should probably just open the dashboard page in edit mode in a new window instead (`/superset/dashboard/${dashboard.id}/?edit=true`), since editing dashboard layout/charts is a much more common action than editing dashboard properties.
   
   I would probably also change the order of the links to "Edit > Export > Delete".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514603037



##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getRecentAcitivtyObjs, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface ActivityObjects {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  margin-top: ${({ theme }) => theme.gridUnit * -4}px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: ${({ theme }) => theme.gridUnit * 3}px;
+    margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  }
+  .ant-card-meta-title {
+    font-weight: ${({ theme }) => theme.typography.weights.bold};
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: ActivityObjects) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: ActivityObjects) => {
+    if (e.sql) return 'sql';
+    if (e.url?.includes('dashboard')) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.includes('explore') || e.item_url?.includes('explore')) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getRecentAcitivtyObjs(user.userId, recent, addDangerToast)
+      .then(res => {
+        const data: any = {
+          Created: [
+            ...res.createdByChart,
+            ...res.createdByDash,
+            ...res.createdByQuery,
+          ],
+          Edited: [...res.editedChart, ...res.editedDash],
+        };
+        if (res.viewed) {
+          const filtered = reject(res.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = res.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);

Review comment:
       My fix specifically excluded duplicates. It could be also because of React hot loading though, will do more testing when I have time.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514560736



##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/ActivityTable_spec.tsx
##########
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styledMount as mount } from 'spec/helpers/theming';
+import thunk from 'redux-thunk';
+import fetchMock from 'fetch-mock';
+
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+import configureStore from 'redux-mock-store';
+import ActivityTable from 'src/views/CRUD/welcome/ActivityTable';
+
+const mockStore = configureStore([thunk]);
+const store = mockStore({});
+
+const chartsEndpoint = 'glob:*/api/v1/chart/?*';
+const dashboardEndpoint = 'glob:*/api/v1/dashboard/?*';
+const savedQueryEndpoint = 'glob:*/api/v1/saved_query/?*';
+
+fetchMock.get(chartsEndpoint, {
+  result: [
+    {
+      slice_name: 'ChartyChart',
+      changed_on_utc: '24 Feb 2014 10:13:14',
+      url: '/fakeUrl/explore',
+      id: '4',
+      table: {},
+    },
+  ],
+});
+
+fetchMock.get(dashboardEndpoint, {
+  result: [
+    {
+      dashboard_title: 'Dashboard_Test',
+      changed_on_utc: '24 Feb 2014 10:13:14',
+      url: '/fakeUrl/dashboard',
+      id: '3',
+    },
+  ],
+});
+
+fetchMock.get(savedQueryEndpoint, {
+  result: [],
+});
+
+describe('ActivityTable', () => {
+  const activityProps = {
+    user: {
+      userId: '1',
+    },
+    activityFilter: 'Edited',
+  };
+  const wrapper = mount(<ActivityTable {...activityProps} />, {
+    context: { store },
+  });
+
+  beforeAll(async () => {
+    await waitForComponentToPaint(wrapper);
+  });
+
+  it('the component renders ', () => {
+    expect(wrapper.find(ActivityTable)).toExist();
+  });
+
+  it('calls batch method and renders ListViewCArd', async () => {
+    const chartCall = fetchMock.calls(/chart\/\?q/);
+    const dashboardCall = fetchMock.calls(/dashboard\/\?q/);
+    expect(chartCall).toHaveLength(2);
+    expect(dashboardCall).toHaveLength(2);

Review comment:
       @ktmud I think there are a few ways we can approach the performance issues... potentially each of the four sections run queries and render separately, and there may be some queries we can combine if they use the same endpoint but different parameters Is the current state a dealbreaker for you, or would you be comfortable enough we merge this as-is then follow up with performance improvements in a new PR or two?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r510307604



##########
File path: superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
##########
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t } from '@superset-ui/core';
+import { useListViewResource, useChartEditModal } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import PropertiesModal from 'src/explore/components/PropertiesModal';
+import { User } from 'src/types/bootstrapTypes';
+import Icon from 'src/components/Icon';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import Chart from 'src/types/Chart';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+import { CardContainer, IconContainer } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface ChartTableProps {
+  addDangerToast: (message: string) => void;
+  addSuccessToast: (message: string) => void;
+  search: string;
+  chartFilter?: string;
+  user?: User;
+}
+
+function ChartTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: ChartTableProps) {
+  const {
+    state: { loading, resourceCollection: charts, bulkSelectEnabled },
+    setResourceCollection: setCharts,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Chart>('chart', t('chart'), addDangerToast);
+
+  const {
+    sliceCurrentlyEditing,
+    openChartEditModal,
+    handleChartUpdated,
+    closeChartEditModal,
+  } = useChartEditModal(setCharts, charts);
+
+  const [chartFilter, setChartFilter] = useState('Favorite');
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (chartFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'chart_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [chartFilter]);
+
+  return (
+    <>
+      {sliceCurrentlyEditing && (
+        <PropertiesModal
+          onHide={closeChartEditModal}
+          onSave={handleChartUpdated}
+          show
+          slice={sliceCurrentlyEditing}
+        />
+      )}
+
+      <SubMenu
+        activeChild={chartFilter}
+        name=""
+        // eslint-disable-next-line react/no-children-prop
+        children={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setChartFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setChartFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> Chart{' '}

Review comment:
       `i18n`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.83%`.
   > The diff coverage is `59.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.73%   -4.84%     
   ==========================================
     Files         860      868       +8     
     Lines       40874    41332     +458     
     Branches     3694     3770      +76     
   ==========================================
   - Hits        27210    25515    -1695     
   - Misses      13566    15637    +2071     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.68% <59.61%> (-0.28%)` | :arrow_down: |
   | #python | `61.16% <ø> (-0.78%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `67.24% <48.57%> (-32.76%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [231 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...0f398b2](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r511084812



##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),

Review comment:
       Ehh better to keep it open just in case




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.57%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.07%   -5.58%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26061   -14987     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15917   -11442     
   + Misses      13592    10144    -3448     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.07% <100.00%> (-0.89%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | ... and [457 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...df56336](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.46%`.
   > The diff coverage is `58.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   62.10%   -4.47%     
   ==========================================
     Files         860      869       +9     
     Lines       40874    41335     +461     
     Branches     3694     3771      +77     
   ==========================================
   - Hits        27210    25672    -1538     
   - Misses      13566    15483    +1917     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.72% <58.96%> (-0.24%)` | :arrow_down: |
   | #python | `61.73% <ø> (-0.21%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [226 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...64ce929](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-718547527


   Couldn't continue with reviewing because this PR really needs a rebase. The diff is too large. 
   
   After rebasing, you should have only 35 changes files instead of 119.
   https://github.com/apache/incubator-superset/compare/master...ktmud:home-screen-mvp


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r510390461



##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -53,6 +54,84 @@ const createFetchResourceMethod = (method: string) => (
   return [];
 };
 
+export const getBatchData = (userId: string | number, recent: string) => {

Review comment:
       getRecentActivityObjects makes sense!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson closed pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson closed pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.45%`.
   > The diff coverage is `63.83%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   62.19%   -4.46%     
   ==========================================
     Files         863      868       +5     
     Lines       41048    41559     +511     
     Branches     3693     3792      +99     
   ==========================================
   - Hits        27359    25849    -1510     
   - Misses      13592    15531    +1939     
   - Partials       97      179      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.55% <62.48%> (-0.38%)` | :arrow_down: |
   | #python | `61.98% <79.41%> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `49.17% <ø> (-29.29%)` | :arrow_down: |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `62.22% <ø> (-6.67%)` | :arrow_down: |
   | [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `50.00% <0.00%> (ø)` | |
   | [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `0.00% <ø> (ø)` | |
   | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `66.32% <0.00%> (-17.35%)` | :arrow_down: |
   | [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `88.00% <ø> (-10.08%)` | :arrow_down: |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-75.30%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (-0.55%)` | :arrow_down: |
   | ... and [245 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.73%   -4.84%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    16028   -11182     
   + Misses      13566     9933    -3633     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.73% <ø> (-0.21%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-3.49%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `92.10% <0.00%> (-2.49%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `81.77% <0.00%> (-0.43%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...11b387a](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `0.18%`.
   > The diff coverage is `62.55%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   66.42%   -0.19%     
   ==========================================
     Files         862      869       +7     
     Lines       41215    41587     +372     
     Branches     3719     3797      +78     
   ==========================================
   + Hits        27454    27625     +171     
   - Misses      13660    13856     +196     
   - Partials      101      106       +5     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.16% <20.72%> (-1.27%)` | :arrow_down: |
   | #javascript | `62.57% <59.71%> (-0.13%)` | :arrow_down: |
   | #python | `62.03% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `63.77% <27.02%> (-15.11%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `50.00% <30.50%> (-50.00%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `46.47% <46.47%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `60.37% <58.82%> (-18.58%)` | :arrow_down: |
   | ... and [35 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...3af819d](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.75%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.85%   -4.76%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26078   -15137     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16131   -11323     
   + Misses      13660     9947    -3713     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.85% <100.00%> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.59%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   60.97%   -5.60%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25959   -14915     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15829   -11381     
   + Misses      13566    10130    -3436     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.97% <ø> (-0.97%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | ... and [461 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...d97dd73](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514004665



##########
File path: superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
##########
@@ -16,169 +16,176 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React from 'react';
-import { t, SupersetClient } from '@superset-ui/core';
-import { debounce } from 'lodash';
-import ListView, { FetchDataConfig } from 'src/components/ListView';
+import React, { useEffect, useState } from 'react';
+import { SupersetClient, t } from '@superset-ui/core';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import { Dashboard, DashboardTableProps } from 'src/views/CRUD/types';
 import withToasts from 'src/messageToasts/enhancers/withToasts';
-import { Dashboard } from 'src/types/bootstrapTypes';
+import PropertiesModal from 'src/dashboard/components/PropertiesModal';
+import DashboardCard from 'src/views/CRUD/dashboard/DashboardCard';
+import SubMenu from 'src/components/Menu/SubMenu';
+import Icon from 'src/components/Icon';
+import EmptyState from './EmptyState';
+import { createErrorHandler, CardContainer, IconContainer } from '../utils';
 
-const PAGE_SIZE = 25;
+const PAGE_SIZE = 3;
 
-interface DashboardTableProps {
-  addDangerToast: (message: string) => void;
-  search?: string;
+export interface FilterValue {
+  col: string;
+  operator: string;
+  value: string | boolean | number | null | undefined;
 }
 
-interface DashboardTableState {
-  dashboards: Dashboard[];
-  dashboard_count: number;
-  loading: boolean;
-}
+function DashboardTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: DashboardTableProps) {
+  const {
+    state: { loading, resourceCollection: dashboards, bulkSelectEnabled },
+    setResourceCollection: setDashboards,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Dashboard>(
+    'dashboard',
+    t('dashboard'),
+    addDangerToast,
+  );
 
-class DashboardTable extends React.PureComponent<
-  DashboardTableProps,
-  DashboardTableState
-> {
-  columns = [
-    {
-      accessor: 'dashboard_title',
-      Header: 'Dashboard',
-      Cell: ({
-        row: {
-          original: { url, dashboard_title: dashboardTitle },
-        },
-      }: {
-        row: {
-          original: {
-            url: string;
-            dashboard_title: string;
-          };
-        };
-      }) => <a href={url}>{dashboardTitle}</a>,
-    },
-    {
-      accessor: 'changed_by.first_name',
-      Header: 'Modified By',
-      Cell: ({
-        row: {
-          original: { changed_by_name: changedByName, changedByUrl },
-        },
-      }: {
-        row: {
-          original: {
-            changed_by_name: string;
-            changedByUrl: string;
-          };
-        };
-      }) => <a href={changedByUrl}>{changedByName}</a>,
-    },
-    {
-      accessor: 'changed_on_delta_humanized',
-      Header: 'Modified',
-      Cell: ({
-        row: {
-          original: { changed_on_delta_humanized: changedOn },
-        },
-      }: {
-        row: {
-          original: {
-            changed_on_delta_humanized: string;
-          };
-        };
-      }) => <span className="no-wrap">{changedOn}</span>,
-    },
-  ];
+  const [editModal, setEditModal] = useState<Dashboard | null>(null);

Review comment:
       I'm also not sure about opening the Dashboard Properties modal with this link.
   
   <img src="https://user-images.githubusercontent.com/335541/97531800-34ef5b80-1972-11eb-874f-d735aef3d169.png" width="300">
   
   It should probably just open the dashboard page in edit mode in a new window instead (`/superset/dashboard/${dashboard.id}/?edit=true`), since editing dashboard layout/charts is a much more common action than editing dashboard properties.
   
   I would probably also change the order of the links to "Edit > Export > Delete".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `3.88%`.
   > The diff coverage is `59.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   62.68%   -3.89%     
   ==========================================
     Files         860      451     -409     
     Lines       40874    15371   -25503     
     Branches     3694     3770      +76     
   ==========================================
   - Hits        27210     9636   -17574     
   + Misses      13566     5555    -8011     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.68% <59.61%> (-0.28%)` | :arrow_down: |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `67.24% <48.57%> (-32.76%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `58.49% <56.86%> (-20.46%)` | :arrow_down: |
   | [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `57.14% <57.14%> (ø)` | |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `68.88% <68.88%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `70.58% <70.58%> (ø)` | |
   | ... and [613 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...0f398b2](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r509768977



##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  img {
+    width: 114px;
+    display: block;
+    margin: 0 auto;
+  }
+  div:nth-child(2) {
+    text-align: center;
+    margin-top: 15px;
+    color: ${({ theme }) => theme.colors.grayscale.dark1};
+    font-weight: 400;
+  }
+  button {
+    margin: 0 auto;
+    padding: 6px 27px;
+    margin-top: 10px;
+    svg {
+      color: white;
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const Mine = (
+    <div>
+      <div>{`No ${tableName.toLowerCase()} yet`}</div>
+      <Button
+        buttonStyle="primary"
+        onClick={() => {
+          window.location = mineRedirects[tableName];
+        }}
+      >
+        <IconContainer>
+          <Icon name="plus-small" />{' '}
+          {tableName === 'SAVED_QUERIES'
+            ? 'SQL LAB QUERY'
+            : tableName
+                .split('')
+                .slice(0, tableName.length - 1)
+                .join('')}{' '}
+        </IconContainer>
+      </Button>
+    </div>
+  );
+  const span = (
+    <div className="no-recents">
+      Recently viewed charts, dashboards, and saved queries will appear here
+    </div>
+  );
+
+  if (tab === 'Mine') {
+    return (
+      <Container>
+        <img src="/static/assets/images/union.png" alt="union.png" />

Review comment:
       It looks like we have a new asset here. Should we reduce/reuse/recycle by including the `<Empty>` component (from AntD) leveraged in the ListView?
   
   https://github.com/apache/incubator-superset/pull/11372




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
nytai edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-718282308


   something looks a little off here .... 4k additions and 119 files changed 🤔 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `5.22%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.38%   -5.23%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26076   -15139     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16007   -11447     
   + Misses      13660    10069    -3591     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.38% <100.00%> (-0.62%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | ... and [443 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...3af819d](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.64%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   60.92%   -5.65%     
   ==========================================
     Files         860      415     -445     
     Lines       40874    25852   -15022     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15750   -11460     
   + Misses      13566    10102    -3464     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.92% <100.00%> (-1.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [457 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...69cda75](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.35%`.
   > The diff coverage is `58.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   62.21%   -4.36%     
   ==========================================
     Files         860      869       +9     
     Lines       40874    41335     +461     
     Branches     3694     3771      +77     
   ==========================================
   - Hits        27210    25718    -1492     
   - Misses      13566    15437    +1871     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.72% <58.96%> (-0.24%)` | :arrow_down: |
   | #python | `61.91% <ø> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [225 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...64ce929](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.75%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.85%   -4.76%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26078   -15137     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16131   -11323     
   + Misses      13660     9947    -3713     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.85% <100.00%> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [...rset-frontend/src/dashboard/util/componentTypes.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudFR5cGVzLnRz) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r511084662



##########
File path: superset-frontend/src/views/CRUD/hooks.ts
##########
@@ -348,5 +355,87 @@ export function useFavoriteStatus(
     );
   };
 
-  return [favoriteStatusRef, fetchFaveStar, saveFaveStar] as const;
+  return [
+    favoriteStatusRef,
+    fetchFaveStar,
+    saveFaveStar,
+    favoriteStatus,
+  ] as const;
 }
+
+export const useChartEditModal = (
+  setCharts: (charts: Array<Chart>) => void,
+  charts: Array<Chart>,
+) => {
+  const [
+    sliceCurrentlyEditing,
+    setSliceCurrentlyEditing,
+  ] = useState<Slice | null>(null);
+
+  function openChartEditModal(chart: Chart) {
+    setSliceCurrentlyEditing({
+      slice_id: chart.id,
+      slice_name: chart.slice_name,
+      description: chart.description,
+      cache_timeout: chart.cache_timeout,
+    });
+  }
+
+  function closeChartEditModal() {
+    setSliceCurrentlyEditing(null);
+  }
+
+  function handleChartUpdated(edits: Chart) {
+    // update the chart in our state with the edited info
+    const newCharts = charts.map((chart: Chart) =>
+      chart.id === edits.id ? { ...chart, ...edits } : chart,
+    );
+    setCharts(newCharts);
+  }
+
+  return {
+    sliceCurrentlyEditing,
+    handleChartUpdated,
+    openChartEditModal,
+    closeChartEditModal,
+  };
+};
+
+export const copyQueryLink = (

Review comment:
       I'm going to right a follow up ticket for this for moving this into a util folder




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r509770904



##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  img {
+    width: 114px;
+    display: block;
+    margin: 0 auto;
+  }
+  div:nth-child(2) {
+    text-align: center;
+    margin-top: 15px;
+    color: ${({ theme }) => theme.colors.grayscale.dark1};
+    font-weight: 400;
+  }
+  button {
+    margin: 0 auto;
+    padding: 6px 27px;
+    margin-top: 10px;
+    svg {
+      color: white;
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const Mine = (
+    <div>
+      <div>{`No ${tableName.toLowerCase()} yet`}</div>
+      <Button
+        buttonStyle="primary"
+        onClick={() => {
+          window.location = mineRedirects[tableName];
+        }}
+      >
+        <IconContainer>
+          <Icon name="plus-small" />{' '}
+          {tableName === 'SAVED_QUERIES'
+            ? 'SQL LAB QUERY'
+            : tableName
+                .split('')
+                .slice(0, tableName.length - 1)
+                .join('')}{' '}
+        </IconContainer>
+      </Button>
+    </div>
+  );
+  const span = (
+    <div className="no-recents">
+      Recently viewed charts, dashboards, and saved queries will appear here
+    </div>
+  );
+
+  if (tab === 'Mine') {
+    return (
+      <Container>
+        <img src="/static/assets/images/union.png" alt="union.png" />
+        {tableName === 'RECENTS' ? span : Mine}
+      </Container>
+    );
+  }
+
+  return (
+    <Container>
+      <img src="/static/assets/images/star-circle.png" alt="star.png" />

Review comment:
       If we do want to use the AntD `Empty` component, it can leverage custom images as seen in the "Customize" example [here](https://ant.design/components/empty/).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `3.85%`.
   > The diff coverage is `58.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   62.71%   -3.86%     
   ==========================================
     Files         860      452     -408     
     Lines       40874    15369   -25505     
     Branches     3694     3769      +75     
   ==========================================
   - Hits        27210     9639   -17571     
   + Misses      13566     5550    -8016     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.71% <58.88%> (-0.25%)` | :arrow_down: |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `58.49% <56.86%> (-20.46%)` | :arrow_down: |
   | [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `60.00% <60.00%> (ø)` | |
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `76.31% <76.31%> (ø)` | |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `74.22% <83.33%> (-0.98%)` | :arrow_down: |
   | ... and [617 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...6fb9516](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r513801739



##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -53,6 +57,97 @@ const createFetchResourceMethod = (method: string) => (
   return [];
 };
 
+export const getRecentAcitivtyObjs = (
+  userId: string | number,
+  recent: string,
+) => {
+  const getParams = (filters?: Array<any>) => {
+    const params = {
+      order_column: 'changed_on_delta_humanized',
+      order_direction: 'desc',
+      page: 0,
+      page_size: 3,
+      filters,
+    };
+    if (!filters) delete params.filters;
+    return rison.encode(params);
+  };
+  const filters = {
+    // chart and dashbaord uses same filters
+    // for edited and created
+    edited: [
+      {
+        col: 'changed_by',
+        opr: 'rel_o_m',
+        value: `${userId}`,
+      },
+    ],
+    created: [
+      {
+        col: 'created_by',
+        opr: 'rel_o_m',
+        value: `${userId}`,
+      },
+    ],
+  };
+  const baseBatch = [
+    SupersetClient.get({ endpoint: recent }),
+    SupersetClient.get({
+      endpoint: `/api/v1/dashboard/?q=${getParams(filters.edited)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/chart/?q=${getParams(filters.edited)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/dashboard/?q=${getParams(filters.created)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/chart/?q=${getParams(filters.created)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/saved_query/?q=${getParams(filters.created)}`,
+    }),
+  ];
+  return Promise.all(baseBatch).then(
+    // @ts-ignore
+    ([
+      recentsRes,
+      editedDash,
+      editedChart,
+      createdByDash,
+      createdByChart,
+      createdByQuery,
+    ]) => {
+      const res: any = {
+        editedDash: editedDash.json?.result.slice(0, 3),
+        editedChart: editedChart.json?.result.slice(0, 3),
+        createdByDash: createdByDash.json?.result.slice(0, 3),
+        createdByChart: createdByChart.json?.result.slice(0, 3),
+        createdByQuery: createdByQuery.json?.result.slice(0, 3),
+      };
+      if (recentsRes.json.length === 0) {
+        const newBatch = [
+          SupersetClient.get({ endpoint: `/api/v1/chart/?q=${getParams()}` }),
+          SupersetClient.get({
+            endpoint: `/api/v1/dashboard/?q=${getParams()}`,
+          }),
+        ];
+        return Promise.all(newBatch)
+          .then(([chartRes, dashboardRes]) => {
+            res.examples = [
+              ...chartRes.json.result,
+              ...dashboardRes.json.result,
+            ];
+            return res;
+          })
+          .catch(e => console.log('err', e));

Review comment:
       Can we toast this? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.45%`.
   > The diff coverage is `58.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   62.11%   -4.46%     
   ==========================================
     Files         860      869       +9     
     Lines       40874    41318     +444     
     Branches     3694     3769      +75     
   ==========================================
   - Hits        27210    25663    -1547     
   - Misses      13566    15475    +1909     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.71% <58.88%> (-0.25%)` | :arrow_down: |
   | #python | `61.75% <ø> (-0.19%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [234 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...6fb9516](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.61%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   60.95%   -5.62%     
   ==========================================
     Files         860      416     -444     
     Lines       40874    25892   -14982     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15782   -11428     
   + Misses      13566    10110    -3456     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.95% <ø> (-0.99%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [462 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...e12c2b9](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r510295852



##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -139,19 +139,39 @@ const SkeletonActions = styled(Skeleton.Button)`
   width: ${({ theme }) => theme.gridUnit * 10}px;
 `;
 
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid #e0e0e0;
+  .title {
+    font-weight: 500;
+    color: #b2b2b2;
+  }
+  .holder {
+    margin: 10px 10px 10px 10px;
+  }
+`;
+
 const paragraphConfig = { rows: 1, width: 150 };
 interface CardProps {
   title: React.ReactNode;
   url?: string;
   imgURL: string;
+  tables?: string | number;
   imgFallbackURL: string;
   imgPosition?: BackgroundPosition;
   description: string;
   loading: boolean;
   titleRight?: React.ReactNode;
   coverLeft?: React.ReactNode;
   coverRight?: React.ReactNode;
-  actions: React.ReactNode;
+  actions: React.ReactNode | null;
+  showImg?: boolean;
+  rows?: number | string;
+  avatar?: string;
+  isRecent?: boolean;
+  tableName?: string;
 }
 
 function ListViewCard({

Review comment:
       It's super late into this project to do component modeling! We should have done component modeling at the very beginning and figure out which component we'll alter and the ones we'll create / refactor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.79%`.
   > The diff coverage is `58.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.85%   -4.80%     
   ==========================================
     Files         863      869       +6     
     Lines       41048    41396     +348     
     Branches     3693     3769      +76     
   ==========================================
   - Hits        27359    25605    -1754     
   - Misses      13592    15611    +2019     
   - Partials       97      180      +83     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.76% <58.88%> (-0.17%)` | :arrow_down: |
   | #python | `61.31% <100.00%> (-0.65%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.69% <21.62%> (-22.20%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `58.49% <56.86%> (-20.46%)` | :arrow_down: |
   | ... and [206 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...8924264](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.66%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   60.98%   -5.67%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26052   -14996     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15888   -11471     
   + Misses      13592    10164    -3428     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.98% <100.00%> (-0.98%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [463 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `5.28%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.32%   -5.29%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26076   -15139     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    15991   -11463     
   + Misses      13660    10085    -3575     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.32% <100.00%> (-0.68%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | ... and [444 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...3af819d](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.63%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   65.43%   60.79%   -4.64%     
   ==========================================
     Files         829      392     -437     
     Lines       39200    24555   -14645     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        25649    14928   -10721     
   + Misses      13444     9627    -3817     
   + Partials      107        0     -107     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.79% <100.00%> (+0.18%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `74.56% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.86% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | ... and [439 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [9785667...f190768](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-718944579


   > Couldn't continue with reviewing because this PR really needs a rebase. The diff is too large.
   > 
   > After rebasing, you should have only 35 changed files instead of 119.
   > [master...ktmud:home-screen-mvp](https://github.com/apache/incubator-superset/compare/master...ktmud:home-screen-mvp)
   
   All cleared up now, back to 34 files. Thanks for your input so far. Good to have fresh eyes on this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.63%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   65.43%   60.79%   -4.64%     
   ==========================================
     Files         829      392     -437     
     Lines       39200    24555   -14645     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        25649    14928   -10721     
   + Misses      13444     9627    -3817     
   + Partials      107        0     -107     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.79% <100.00%> (+0.18%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `74.56% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.86% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | ... and [439 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [9785667...f190768](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-718547527


   Couldn't continue with reviewing because this PR really needs a rebase. The diff is too large. 
   
   After rebasing, you should have only 35 changed files instead of 119.
   https://github.com/apache/incubator-superset/compare/master...ktmud:home-screen-mvp


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514473796



##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,260 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient, styled } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+  .title {
+    font-weight: ${({ theme }) => theme.typography.weights.normal};
+    color: ${({ theme }) => theme.colors.grayscale.light2};
+  }
+  .holder {
+    margin: ${({ theme }) => theme.gridUnit * 2}px;
+  }
+`;
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            window.location.href = `/superset/sqllab?savedQueryId=${query.id}`;
+          }}
+        >
+          {t('Edit')}
+        </Menu.Item>

Review comment:
       Regular anchor element might have an underscore. So #11491 is needed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.34%`.
   > The diff coverage is `79.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.30%   -5.35%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26052   -14996     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15972   -11387     
   + Misses      13592    10080    -3512     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.30% <79.41%> (-0.66%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.86% <ø> (-0.49%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <50.00%> (-2.76%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.87% <100.00%> (+0.45%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.15% <100.00%> (+0.15%)` | :arrow_up: |
   | ... and [418 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.77%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.83%   -4.78%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26067   -15148     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16119   -11335     
   + Misses      13660     9948    -3712     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.83% <100.00%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...ff22e81](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.24%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.32%   -5.25%     
   ==========================================
     Files         860      416     -444     
     Lines       40874    25903   -14971     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15885   -11325     
   + Misses      13566    10018    -3548     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.32% <ø> (-0.62%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | ... and [444 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...e12c2b9](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.50%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.06%   -5.51%     
   ==========================================
     Files         860      415     -445     
     Lines       40874    25861   -15013     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15793   -11417     
   + Misses      13566    10068    -3498     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.06% <100.00%> (-0.88%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.10% <0.00%> (-25.33%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...8edf056](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.20%   -5.37%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15890   -11320     
   + Misses      13566    10071    -3495     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.20% <ø> (-0.74%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-3.49%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...64ce929](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.75%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.85%   -4.76%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26078   -15137     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16131   -11323     
   + Misses      13660     9947    -3713     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.85% <100.00%> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.57%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   62.03%   -4.58%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26078   -15137     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16177   -11277     
   + Misses      13660     9901    -3759     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `62.03% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | | |
   | [superset-frontend/src/components/ListView/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvaW5kZXgudHM=) | | |
   | [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | | |
   | [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | | |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | | |
   | ... and [434 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.59%   -4.98%     
   ==========================================
     Files         860      415     -445     
     Lines       40874    25861   -15013     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15928   -11282     
   + Misses      13566     9933    -3633     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.59% <100.00%> (-0.36%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.38% <0.00%> (-3.36%)` | :arrow_down: |
   | ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...8edf056](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.77%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.83%   -4.78%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26067   -15148     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16119   -11335     
   + Misses      13660     9948    -3712     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.83% <100.00%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f14cf9d6dc742be1a1d676db6ab9f5b39d6a2d28?el=desc) will **decrease** coverage by `1.57%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   61.57%   60.00%   -1.58%     
   ==========================================
     Files         838      394     -444     
     Lines       39839    24953   -14886     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        24532    14973    -9559     
   + Misses      15126     9980    -5146     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.00% <100.00%> (-0.95%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `74.56% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.86% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [f14cf9d...cb140ed](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r513065371



##########
File path: superset-frontend/src/views/CRUD/chart/ChartCard.tsx
##########
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { useFavoriteStatus } from 'src/views/CRUD/hooks';
+import { SupersetClient, t } from '@superset-ui/core';
+import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
+import Icon from 'src/components/Icon';
+import Chart from 'src/types/Chart';
+
+import ListViewCard from 'src/components/ListViewCard';
+import Label from 'src/components/Label';
+import { Dropdown, Menu } from 'src/common/components';
+import FaveStar from 'src/components/FaveStar';
+import FacePile from 'src/components/FacePile';
+
+const FAVESTAR_BASE_URL = '/superset/favstar/slice';
+
+interface ChartCardProps {
+  chart: Chart;
+  hasPerm: (perm: string) => boolean;
+  openChartEditModal: (chart: Chart) => void;
+  bulkSelectEnabled: boolean;
+  addDangerToast: (msg: string) => void;
+  addSuccessToast: (msg: string) => void;
+  refreshData: () => void;
+  loading: boolean;
+}
+
+export default function ChartCard({
+  chart,
+  hasPerm,
+  openChartEditModal,
+  bulkSelectEnabled,
+  addDangerToast,
+  addSuccessToast,
+  refreshData,
+  loading,
+}: ChartCardProps) {
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+  const [, fetchFaveStar, saveFaveStar, favoriteStatus] = useFavoriteStatus(
+    {},
+    FAVESTAR_BASE_URL,
+    addDangerToast,
+  );
+  function handleChartDelete({ id, slice_name: sliceName }: Chart) {
+    SupersetClient.delete({
+      endpoint: `/api/v1/chart/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        addSuccessToast(t('Deleted: %s', sliceName));
+      },
+      () => {
+        addDangerToast(t('There was an issue deleting: %s', sliceName));
+      },
+    );
+  }

Review comment:
       yup, my comment was mainly around the inconsistency. Ideally, both edit and delete should be treated the same (either delegate to props or define the handlers here). This isn't such a big deal here, as this isn't meant to be a shared lib component, but these inconsistencies can lead to lots of fragmented logic spread across many files. 
   
   The main issue I see here is the duplication of the useFavortieStatus hook. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.65%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.99%   -4.66%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26063   -14985     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    16159   -11200     
   + Misses      13592     9904    -3688     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.99% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <0.00%> (-2.76%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <0.00%> (-0.97%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <0.00%> (ø)` | |
   | [...-frontend/src/dashboard/util/getDragDropManager.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyYWdEcm9wTWFuYWdlci5qcw==) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f14cf9d6dc742be1a1d676db6ab9f5b39d6a2d28?el=desc) will **decrease** coverage by `0.32%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   61.57%   61.24%   -0.33%     
   ==========================================
     Files         838      415     -423     
     Lines       39839    25852   -13987     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        24532    15834    -8698     
   + Misses      15126    10018    -5108     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.24% <100.00%> (+0.30%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (+2.42%)` | :arrow_up: |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (+2.00%)` | :arrow_up: |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <0.00%> (-2.94%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [477 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [f14cf9d...ba1ebd7](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] junlincc commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
junlincc commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514764082



##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/ActivityTable_spec.tsx
##########
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styledMount as mount } from 'spec/helpers/theming';
+import thunk from 'redux-thunk';
+import fetchMock from 'fetch-mock';
+
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+import configureStore from 'redux-mock-store';
+import ActivityTable from 'src/views/CRUD/welcome/ActivityTable';
+
+const mockStore = configureStore([thunk]);
+const store = mockStore({});
+
+const chartsEndpoint = 'glob:*/api/v1/chart/?*';
+const dashboardEndpoint = 'glob:*/api/v1/dashboard/?*';
+const savedQueryEndpoint = 'glob:*/api/v1/saved_query/?*';
+
+fetchMock.get(chartsEndpoint, {
+  result: [
+    {
+      slice_name: 'ChartyChart',
+      changed_on_utc: '24 Feb 2014 10:13:14',
+      url: '/fakeUrl/explore',
+      id: '4',
+      table: {},
+    },
+  ],
+});
+
+fetchMock.get(dashboardEndpoint, {
+  result: [
+    {
+      dashboard_title: 'Dashboard_Test',
+      changed_on_utc: '24 Feb 2014 10:13:14',
+      url: '/fakeUrl/dashboard',
+      id: '3',
+    },
+  ],
+});
+
+fetchMock.get(savedQueryEndpoint, {
+  result: [],
+});
+
+describe('ActivityTable', () => {
+  const activityProps = {
+    user: {
+      userId: '1',
+    },
+    activityFilter: 'Edited',
+  };
+  const wrapper = mount(<ActivityTable {...activityProps} />, {
+    context: { store },
+  });
+
+  beforeAll(async () => {
+    await waitForComponentToPaint(wrapper);
+  });
+
+  it('the component renders ', () => {
+    expect(wrapper.find(ActivityTable)).toExist();
+  });
+
+  it('calls batch method and renders ListViewCArd', async () => {
+    const chartCall = fetchMock.calls(/chart\/\?q/);
+    const dashboardCall = fetchMock.calls(/dashboard\/\?q/);
+    expect(chartCall).toHaveLength(2);
+    expect(dashboardCall).toHaveLength(2);

Review comment:
       yes please address performance issues separately after we get through most of the roadmap items....




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f14cf9d6dc742be1a1d676db6ab9f5b39d6a2d28?el=desc) will **decrease** coverage by `0.34%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   61.57%   61.23%   -0.35%     
   ==========================================
     Files         838      415     -423     
     Lines       39839    25863   -13976     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        24532    15837    -8695     
   + Misses      15126    10026    -5100     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.23% <100.00%> (+0.28%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (+2.42%)` | :arrow_up: |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (+2.00%)` | :arrow_up: |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <0.00%> (-2.94%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [473 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [f14cf9d...3f30d1b](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.36%`.
   > The diff coverage is `58.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   62.20%   -4.37%     
   ==========================================
     Files         860      869       +9     
     Lines       40874    41329     +455     
     Branches     3694     3769      +75     
   ==========================================
   - Hits        27210    25709    -1501     
   - Misses      13566    15440    +1874     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.71% <58.88%> (-0.25%)` | :arrow_down: |
   | #python | `61.90% <ø> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [229 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...6fb9516](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.75%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.85%   -4.76%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26078   -15137     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16131   -11323     
   + Misses      13660     9947    -3713     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.85% <100.00%> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.58%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   62.03%   -4.59%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26076   -15139     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16175   -11279     
   + Misses      13660     9901    -3759     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `62.03% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `75.80% <0.00%> (-0.39%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <0.00%> (-0.04%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | | |
   | [superset-frontend/src/utils/safeStringify.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3NhZmVTdHJpbmdpZnkudHM=) | | |
   | [...t-frontend/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlQWRkZXIuanN4) | | |
   | ... and [436 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...3af819d](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r512872758



##########
File path: superset-frontend/src/views/CRUD/chart/ChartCard.tsx
##########
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { useFavoriteStatus } from 'src/views/CRUD/hooks';
+import { SupersetClient, t } from '@superset-ui/core';
+import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
+import Icon from 'src/components/Icon';
+import Chart from 'src/types/Chart';
+
+import ListViewCard from 'src/components/ListViewCard';
+import Label from 'src/components/Label';
+import { Dropdown, Menu } from 'src/common/components';
+import FaveStar from 'src/components/FaveStar';
+import FacePile from 'src/components/FacePile';
+
+const FAVESTAR_BASE_URL = '/superset/favstar/slice';
+
+interface ChartCardProps {
+  chart: Chart;
+  hasPerm: (perm: string) => boolean;
+  openChartEditModal: (chart: Chart) => void;
+  bulkSelectEnabled: boolean;
+  addDangerToast: (msg: string) => void;
+  addSuccessToast: (msg: string) => void;
+  refreshData: () => void;
+  loading: boolean;
+}
+
+export default function ChartCard({
+  chart,
+  hasPerm,
+  openChartEditModal,
+  bulkSelectEnabled,
+  addDangerToast,
+  addSuccessToast,
+  refreshData,
+  loading,
+}: ChartCardProps) {
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+  const [, fetchFaveStar, saveFaveStar, favoriteStatus] = useFavoriteStatus(
+    {},
+    FAVESTAR_BASE_URL,
+    addDangerToast,
+  );
+  function handleChartDelete({ id, slice_name: sliceName }: Chart) {
+    SupersetClient.delete({
+      endpoint: `/api/v1/chart/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        addSuccessToast(t('Deleted: %s', sliceName));
+      },
+      () => {
+        addDangerToast(t('There was an issue deleting: %s', sliceName));
+      },
+    );
+  }

Review comment:
       gotcha, there was no particular reason other than ease of use. But it make sense to move these into a shared utils!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f14cf9d6dc742be1a1d676db6ab9f5b39d6a2d28?el=desc) will **increase** coverage by `0.36%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   + Coverage   61.57%   61.94%   +0.36%     
   ==========================================
     Files         838      415     -423     
     Lines       39839    25863   -13976     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        24532    16020    -8512     
   + Misses      15126     9843    -5283     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.94% <100.00%> (+0.99%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (+2.42%)` | :arrow_up: |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (+2.00%)` | :arrow_up: |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <0.00%> (-2.94%)` | :arrow_down: |
   | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `75.48% <0.00%> (-0.99%)` | :arrow_down: |
   | [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `89.65% <0.00%> (-0.35%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <0.00%> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.47% <0.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | ... and [464 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [f14cf9d...ba1ebd7](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.58%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   60.98%   -5.59%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25959   -14915     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15832   -11378     
   + Misses      13566    10127    -3439     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.98% <ø> (-0.96%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | ... and [461 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...d97dd73](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.50%`.
   > The diff coverage is `58.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   62.14%   -4.51%     
   ==========================================
     Files         863      869       +6     
     Lines       41048    41396     +348     
     Branches     3693     3769      +76     
   ==========================================
   - Hits        27359    25727    -1632     
   - Misses      13592    15489    +1897     
   - Partials       97      180      +83     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.76% <58.88%> (-0.17%)` | :arrow_down: |
   | #python | `61.78% <100.00%> (-0.18%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.69% <21.62%> (-22.20%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `58.49% <56.86%> (-20.46%)` | :arrow_down: |
   | ... and [203 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...8924264](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.73%`.
   > The diff coverage is `59.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.83%   -4.74%     
   ==========================================
     Files         860      867       +7     
     Lines       40874    41276     +402     
     Branches     3694     3774      +80     
   ==========================================
   - Hits        27210    25524    -1686     
   - Misses      13566    15571    +2005     
   - Partials       98      181      +83     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.70% <59.61%> (-0.27%)` | :arrow_down: |
   | #python | `61.32% <ø> (-0.62%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `67.24% <48.57%> (-32.76%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [221 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...e12c2b9](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r510311152



##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  margin-top: 20px;
+  img {
+    width: 114px;
+    display: block;
+    margin: 0 auto;
+    margin-bottom: 15px;
+  }
+  div:nth-child(2) {
+    text-align: center;
+    margin-top: 15px;
+    color: ${({ theme }) => theme.colors.grayscale.dark1};
+    font-weight: 400;
+  }
+  button {
+    margin: 0 auto;
+    padding: 6px 27px;
+    margin-top: 10px;
+    svg {
+      color: white;
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const tableIcon = {
+    RECENTS: 'union.png',
+    DASHBOARDS: 'empty-dashboard.png',
+    CHARTS: 'empty-charts.png',
+    SAVED_QUERIES: 'empty-queries.png',
+  };
+  const mine = (
+    <div>
+      <div>{`No ${
+        tableName === 'SAVED_QUERIES'
+          ? 'saved queries'
+          : tableName.toLowerCase()
+      } yet`}</div>
+      <Button
+        buttonStyle="primary"
+        onClick={() => {
+          window.location = mineRedirects[tableName];
+        }}
+      >
+        <IconContainer>
+          <Icon name="plus-small" />{' '}
+          {tableName === 'SAVED_QUERIES'
+            ? 'SQL QUERY'
+            : tableName
+                .split('')
+                .slice(0, tableName.length - 1)
+                .join('')}{' '}
+        </IconContainer>
+      </Button>
+    </div>
+  );
+  const span = (
+    <div className="no-recents">
+      Recently {tab?.toLowerCase()} charts, dashboards, and saved queries will
+      appear here
+    </div>
+  );
+  // Mine and Recent Activity(all tabs) tab empty state
+  if (tab === 'Mine' || tableName === 'RECENTS') {
+    return (
+      <Container>
+        <img
+          src={`/static/assets/images/${tableIcon[tableName]}`}
+          alt={`${tableName}`}
+        />
+        {tableName === 'RECENTS' ? span : mine}
+      </Container>
+    );
+  }
+  // Favorite tab empty state
+  return (
+    <Container>
+      <img src="/static/assets/images/star-circle.png" alt="star.png" />
+      <div>
+        <div className="no-favorites">You don't have any favorites yet!</div>

Review comment:
       YES! All strings shown to the user belongs in `t('{HERE}')` so it can be translated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/917d02efbd80ef490f121ffb8e2211e919311596?el=desc) will **decrease** coverage by `5.09%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   65.67%   60.58%   -5.10%     
   ==========================================
     Files         835      394     -441     
     Lines       39656    24935   -14721     
     Branches     3604        0    -3604     
   ==========================================
   - Hits        26045    15106   -10939     
   + Misses      13502     9829    -3673     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.58% <100.00%> (-0.34%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `74.56% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.86% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <100.00%> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | ... and [442 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [917d02e...641f5c5](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.20%   -5.37%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15890   -11320     
   + Misses      13566    10071    -3495     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.20% <ø> (-0.74%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-3.49%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...11b387a](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r509947927



##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/ChartTable_spec.tsx
##########
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { mount } from 'enzyme';
+import thunk from 'redux-thunk';
+import fetchMock from 'fetch-mock';
+
+import configureStore from 'redux-mock-store';
+import ChartTable from 'src/views/CRUD/welcome/ChartTable';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+
+// store needed for withToasts(DashboardTable)

Review comment:
       Yah I'm updating these




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.33%`.
   > The diff coverage is `59.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   62.23%   -4.34%     
   ==========================================
     Files         860      867       +7     
     Lines       40874    41276     +402     
     Branches     3694     3774      +80     
   ==========================================
   - Hits        27210    25688    -1522     
   - Misses      13566    15407    +1841     
   - Partials       98      181      +83     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.70% <59.61%> (-0.27%)` | :arrow_down: |
   | #python | `61.95% <ø> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `67.24% <48.57%> (-32.76%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [217 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...e12c2b9](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f14cf9d6dc742be1a1d676db6ab9f5b39d6a2d28?el=desc) will **increase** coverage by `0.18%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   + Coverage   61.57%   61.76%   +0.18%     
   ==========================================
     Files         838      415     -423     
     Lines       39839    25863   -13976     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        24532    15975    -8557     
   + Misses      15126     9888    -5238     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.76% <100.00%> (+0.82%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (+2.42%)` | :arrow_up: |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (+2.00%)` | :arrow_up: |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
   | [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <0.00%> (-2.94%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `75.48% <0.00%> (-0.99%)` | :arrow_down: |
   | [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `89.65% <0.00%> (-0.35%)` | :arrow_down: |
   | ... and [469 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [f14cf9d...ba1ebd7](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.29%`.
   > The diff coverage is `79.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.35%   -5.30%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26063   -14985     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15991   -11368     
   + Misses      13592    10072    -3520     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.35% <79.41%> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <ø> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <50.00%> (-2.76%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.87% <100.00%> (+0.45%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.15% <100.00%> (+0.15%)` | :arrow_up: |
   | ... and [412 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-718285459


   I'm confused why github is including them here, they have the same hash as the ones on master, it shouldn't be picking them up as a new commits in this branch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514111465



##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,260 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient, styled } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+  .title {
+    font-weight: ${({ theme }) => theme.typography.weights.normal};
+    color: ${({ theme }) => theme.colors.grayscale.light2};
+  }
+  .holder {
+    margin: ${({ theme }) => theme.gridUnit * 2}px;
+  }
+`;
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            window.location.href = `/superset/sqllab?savedQueryId=${query.id}`;
+          }}
+        >
+          {t('Edit')}
+        </Menu.Item>

Review comment:
       ```tsx
           <Menu.Item>
            <a href={`/superset/sqllab?savedQueryId=${query.id}`} target="_blank">{t('Edit')}</a>
           </Menu.Item>
   ```
   
   Could just a regular anchor element (just like [AntD's official example](https://ant.design/components/dropdown/)). It's more semantically correct and better for a11y. Users can also "cmd + click" to open things in new tabs if they want to.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.73%   -4.84%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    16027   -11183     
   + Misses      13566     9934    -3632     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.73% <ø> (-0.21%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-3.49%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `92.10% <0.00%> (-2.49%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `81.77% <0.00%> (-0.43%)` | :arrow_down: |
   | ... and [447 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...11b387a](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.58%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   62.03%   -4.59%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26076   -15139     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16175   -11279     
   + Misses      13660     9901    -3759     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `62.03% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `75.80% <0.00%> (-0.39%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <0.00%> (-0.04%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | | |
   | [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | | |
   | [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | | |
   | ... and [436 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...3af819d](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `0.04%`.
   > The diff coverage is `62.55%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   66.56%   -0.05%     
   ==========================================
     Files         862      869       +7     
     Lines       41215    41587     +372     
     Branches     3719     3797      +78     
   ==========================================
   + Hits        27454    27684     +230     
   - Misses      13660    13801     +141     
   - Partials      101      102       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.81% <20.72%> (-0.62%)` | :arrow_down: |
   | #javascript | `62.57% <59.71%> (-0.13%)` | :arrow_down: |
   | #python | `62.03% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `63.77% <27.02%> (-15.11%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `50.00% <30.50%> (-50.00%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `46.47% <46.47%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `60.37% <58.82%> (-18.58%)` | :arrow_down: |
   | ... and [27 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...3af819d](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.75%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.85%   -4.76%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26078   -15137     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16131   -11323     
   + Misses      13660     9947    -3713     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.85% <100.00%> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckNvbmZpZ3NGcm9tRm9ybWRhdGEuanM=) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.84%`.
   > The diff coverage is `58.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.80%   -4.85%     
   ==========================================
     Files         863      868       +5     
     Lines       41048    41559     +511     
     Branches     3693     3792      +99     
   ==========================================
   - Hits        27359    25684    -1675     
   - Misses      13592    15696    +2104     
   - Partials       97      179      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.55% <58.88%> (-0.38%)` | :arrow_down: |
   | #python | `61.35% <100.00%> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.69% <21.62%> (-22.20%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `58.49% <56.86%> (-20.46%)` | :arrow_down: |
   | ... and [235 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...512ecc0](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514562991



##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/EmptyState_spec.tsx
##########
@@ -0,0 +1,92 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styledMount as mount } from 'spec/helpers/theming';
+import EmptyState from 'src/views/CRUD/welcome/EmptyState';
+
+describe('EmptyState', () => {
+  const variants = [
+    {
+      tab: 'Favorite',
+      tableName: 'DASHBOARDS',
+    },
+    {
+      tab: 'Mine',
+      tableName: 'DASHBOARDS',
+    },
+    {
+      tab: 'Favorite',
+      tableName: 'CHARTS',
+    },
+    {
+      tab: 'Mine',
+      tableName: 'CHARTS',
+    },
+    {
+      tab: 'Favorite',
+      tableName: 'SAVED_QUERIES',
+    },
+    {
+      tab: 'Mine',
+      tableName: 'SAVED_QUEREIS',
+    },
+  ];
+  const recents = [
+    {
+      tab: 'Viewed',
+      tableName: 'RECENTS',
+    },
+    {
+      tab: 'Edited',
+      tableName: 'RECENTS',
+    },
+    {
+      tab: 'Created',
+      tableName: 'RECENTS',
+    },
+  ];

Review comment:
       Remembering selections is on the follow-up docket (in localstorage, probably, but flexible on that front)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.75%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.85%   -4.76%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26078   -15137     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16131   -11323     
   + Misses      13660     9947    -3713     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.85% <100.00%> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/917d02efbd80ef490f121ffb8e2211e919311596?el=desc) will **decrease** coverage by `4.94%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   65.67%   60.73%   -4.95%     
   ==========================================
     Files         835      394     -441     
     Lines       39656    24935   -14721     
     Branches     3604        0    -3604     
   ==========================================
   - Hits        26045    15144   -10901     
   + Misses      13502     9791    -3711     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.73% <66.66%> (-0.19%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `74.56% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.86% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <50.00%> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.60% <0.00%> (-0.14%)` | :arrow_down: |
   | ... and [432 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [917d02e...641f5c5](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f14cf9d6dc742be1a1d676db6ab9f5b39d6a2d28?el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   61.57%   61.29%   -0.29%     
   ==========================================
     Files         838      415     -423     
     Lines       39839    25863   -13976     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        24532    15853    -8679     
   + Misses      15126    10010    -5116     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.29% <100.00%> (+0.35%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (+2.42%)` | :arrow_up: |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (+2.00%)` | :arrow_up: |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <0.00%> (-2.94%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | ... and [472 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [f14cf9d...3f30d1b](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.99%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.57%   -5.00%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15985   -11225     
   + Misses      13566     9976    -3590     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.57% <ø> (-0.37%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.38% <0.00%> (-3.36%)` | :arrow_down: |
   | ... and [458 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...d97dd73](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.29%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.27%   -5.30%     
   ==========================================
     Files         860      416     -444     
     Lines       40874    25892   -14982     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15866   -11344     
   + Misses      13566    10026    -3540     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.27% <ø> (-0.67%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...e12c2b9](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514460106



##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getRecentAcitivtyObjs, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface ActivityObjects {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  margin-top: ${({ theme }) => theme.gridUnit * -4}px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: ${({ theme }) => theme.gridUnit * 3}px;
+    margin-left: ${({ theme }) => theme.gridUnit * 2}px;
+  }
+  .ant-card-meta-title {
+    font-weight: ${({ theme }) => theme.typography.weights.bold};
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: ActivityObjects) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: ActivityObjects) => {
+    if (e.sql) return 'sql';
+    if (e.url?.includes('dashboard')) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.includes('explore') || e.item_url?.includes('explore')) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getRecentAcitivtyObjs(user.userId, recent, addDangerToast)
+      .then(res => {
+        const data: any = {
+          Created: [
+            ...res.createdByChart,
+            ...res.createdByDash,
+            ...res.createdByQuery,
+          ],
+          Edited: [...res.editedChart, ...res.editedDash],
+        };
+        if (res.viewed) {
+          const filtered = reject(res.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = res.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);

Review comment:
       Can you tell me what the type of cards these un-iconed cards are ie..chart, dashboard, query?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.46%`.
   > The diff coverage is `58.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   62.10%   -4.47%     
   ==========================================
     Files         860      869       +9     
     Lines       40874    41329     +455     
     Branches     3694     3769      +75     
   ==========================================
   - Hits        27210    25666    -1544     
   - Misses      13566    15483    +1917     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.71% <58.88%> (-0.25%)` | :arrow_down: |
   | #python | `61.73% <ø> (-0.21%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [230 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...6fb9516](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.99%`.
   > The diff coverage is `58.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.57%   -5.00%     
   ==========================================
     Files         860      869       +9     
     Lines       40874    41318     +444     
     Branches     3694     3769      +75     
   ==========================================
   - Hits        27210    25441    -1769     
   - Misses      13566    15697    +2131     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.71% <58.88%> (-0.25%)` | :arrow_down: |
   | #python | `60.89% <ø> (-1.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [250 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...6fb9516](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.67%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   60.89%   -5.68%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25950   -14924     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15803   -11407     
   + Misses      13566    10147    -3419     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.89% <ø> (-1.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [466 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...64ce929](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.65%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.99%   -4.66%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26063   -14985     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    16159   -11200     
   + Misses      13592     9904    -3688     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.99% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <0.00%> (-2.76%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <0.00%> (-0.97%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <0.00%> (ø)` | |
   | [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.64%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.93%   -4.65%     
   ==========================================
     Files         860      415     -445     
     Lines       40874    25863   -15011     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    16017   -11193     
   + Misses      13566     9846    -3720     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.93% <100.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.42% <0.00%> (-0.65%)` | :arrow_down: |
   | [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
   | [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Ryb3BPdmVyZmxvd3NQYXJlbnQuanM=) | | |
   | [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | | |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | | |
   | [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | | |
   | ... and [431 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...8edf056](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r513802734



##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -53,6 +57,97 @@ const createFetchResourceMethod = (method: string) => (
   return [];
 };
 
+export const getRecentAcitivtyObjs = (
+  userId: string | number,
+  recent: string,
+) => {
+  const getParams = (filters?: Array<any>) => {
+    const params = {
+      order_column: 'changed_on_delta_humanized',
+      order_direction: 'desc',
+      page: 0,
+      page_size: 3,
+      filters,
+    };
+    if (!filters) delete params.filters;
+    return rison.encode(params);
+  };
+  const filters = {
+    // chart and dashbaord uses same filters
+    // for edited and created
+    edited: [
+      {
+        col: 'changed_by',
+        opr: 'rel_o_m',
+        value: `${userId}`,
+      },
+    ],
+    created: [
+      {
+        col: 'created_by',
+        opr: 'rel_o_m',
+        value: `${userId}`,
+      },
+    ],
+  };
+  const baseBatch = [
+    SupersetClient.get({ endpoint: recent }),
+    SupersetClient.get({
+      endpoint: `/api/v1/dashboard/?q=${getParams(filters.edited)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/chart/?q=${getParams(filters.edited)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/dashboard/?q=${getParams(filters.created)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/chart/?q=${getParams(filters.created)}`,
+    }),
+    SupersetClient.get({
+      endpoint: `/api/v1/saved_query/?q=${getParams(filters.created)}`,
+    }),
+  ];
+  return Promise.all(baseBatch).then(
+    // @ts-ignore
+    ([
+      recentsRes,
+      editedDash,
+      editedChart,
+      createdByDash,
+      createdByChart,
+      createdByQuery,
+    ]) => {
+      const res: any = {
+        editedDash: editedDash.json?.result.slice(0, 3),
+        editedChart: editedChart.json?.result.slice(0, 3),
+        createdByDash: createdByDash.json?.result.slice(0, 3),
+        createdByChart: createdByChart.json?.result.slice(0, 3),
+        createdByQuery: createdByQuery.json?.result.slice(0, 3),
+      };
+      if (recentsRes.json.length === 0) {
+        const newBatch = [
+          SupersetClient.get({ endpoint: `/api/v1/chart/?q=${getParams()}` }),
+          SupersetClient.get({
+            endpoint: `/api/v1/dashboard/?q=${getParams()}`,
+          }),
+        ];
+        return Promise.all(newBatch)
+          .then(([chartRes, dashboardRes]) => {
+            res.examples = [
+              ...chartRes.json.result,
+              ...dashboardRes.json.result,
+            ];
+            return res;
+          })
+          .catch(e => console.log('err', e));

Review comment:
       Yep on it!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `5.20%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.40%   -5.21%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26067   -15148     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16006   -11448     
   + Misses      13660    10061    -3599     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.40% <100.00%> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.75%`.
   > The diff coverage is `58.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.81%   -4.76%     
   ==========================================
     Files         860      869       +9     
     Lines       40874    41335     +461     
     Branches     3694     3771      +77     
   ==========================================
   - Hits        27210    25550    -1660     
   - Misses      13566    15605    +2039     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.72% <58.96%> (-0.24%)` | :arrow_down: |
   | #python | `61.26% <ø> (-0.68%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [229 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...64ce929](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.82%`.
   > The diff coverage is `59.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.74%   -4.83%     
   ==========================================
     Files         860      868       +8     
     Lines       40874    41321     +447     
     Branches     3694     3770      +76     
   ==========================================
   - Hits        27210    25512    -1698     
   - Misses      13566    15629    +2063     
   - Partials       98      180      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.68% <59.61%> (-0.28%)` | :arrow_down: |
   | #python | `61.17% <ø> (-0.77%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `67.24% <48.57%> (-32.76%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [235 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...0f398b2](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.30%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.26%   -5.31%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15906   -11304     
   + Misses      13566    10055    -3511     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.26% <ø> (-0.68%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-3.49%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `92.10% <0.00%> (-2.49%)` | :arrow_down: |
   | ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...64ce929](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r514387559



##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/ActivityTable_spec.tsx
##########
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styledMount as mount } from 'spec/helpers/theming';
+import thunk from 'redux-thunk';
+import fetchMock from 'fetch-mock';
+
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+import configureStore from 'redux-mock-store';
+import ActivityTable from 'src/views/CRUD/welcome/ActivityTable';
+
+const mockStore = configureStore([thunk]);
+const store = mockStore({});
+
+const chartsEndpoint = 'glob:*/api/v1/chart/?*';
+const dashboardEndpoint = 'glob:*/api/v1/dashboard/?*';
+const savedQueryEndpoint = 'glob:*/api/v1/saved_query/?*';
+
+fetchMock.get(chartsEndpoint, {
+  result: [
+    {
+      slice_name: 'ChartyChart',
+      changed_on_utc: '24 Feb 2014 10:13:14',
+      url: '/fakeUrl/explore',
+      id: '4',
+      table: {},
+    },
+  ],
+});
+
+fetchMock.get(dashboardEndpoint, {
+  result: [
+    {
+      dashboard_title: 'Dashboard_Test',
+      changed_on_utc: '24 Feb 2014 10:13:14',
+      url: '/fakeUrl/dashboard',
+      id: '3',
+    },
+  ],
+});
+
+fetchMock.get(savedQueryEndpoint, {
+  result: [],
+});
+
+describe('ActivityTable', () => {
+  const activityProps = {
+    user: {
+      userId: '1',
+    },
+    activityFilter: 'Edited',
+  };
+  const wrapper = mount(<ActivityTable {...activityProps} />, {
+    context: { store },
+  });
+
+  beforeAll(async () => {
+    await waitForComponentToPaint(wrapper);
+  });
+
+  it('the component renders ', () => {
+    expect(wrapper.find(ActivityTable)).toExist();
+  });
+
+  it('calls batch method and renders ListViewCArd', async () => {
+    const chartCall = fetchMock.calls(/chart\/\?q/);
+    const dashboardCall = fetchMock.calls(/dashboard\/\?q/);
+    expect(chartCall).toHaveLength(2);
+    expect(dashboardCall).toHaveLength(2);

Review comment:
       @junlincc Does it make sense to render less tabs in on first page load to cut down on these call. Our current implementation does batch call for recent activity, and signle calls for charts, dashboards and saved queries favorites.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.34%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.22%   -5.35%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25950   -14924     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15887   -11323     
   + Misses      13566    10063    -3503     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.22% <ø> (-0.73%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-3.49%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...11b387a](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.82%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.82%   -4.83%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26063   -14985     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    16113   -11246     
   + Misses      13592     9950    -3642     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.82% <100.00%> (-0.14%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <0.00%> (-2.76%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <0.00%> (-0.97%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | ... and [443 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.65%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.91%   -4.66%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    16074   -11136     
   + Misses      13566     9887    -3679     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.91% <ø> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `92.10% <0.00%> (-2.49%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `98.83% <0.00%> (-1.17%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `81.77% <0.00%> (-0.43%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (-0.12%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <0.00%> (ø)` | |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <0.00%> (ø)` | |
   | ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...11b387a](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r509783034



##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/DashboardTable_spec.tsx
##########
@@ -17,48 +17,75 @@
  * under the License.
  */
 import React from 'react';
-import { mount } from 'enzyme';
+import { styledMount as mount } from 'spec/helpers/theming';
 import thunk from 'redux-thunk';
 import configureStore from 'redux-mock-store';
 import fetchMock from 'fetch-mock';
-import { supersetTheme, ThemeProvider } from '@superset-ui/core';
+import { act } from 'react-dom/test-utils';
 
-import ListView from 'src/components/ListView';
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+import SubMenu from 'src/components/Menu/SubMenu';
 import DashboardTable from 'src/views/CRUD/welcome/DashboardTable';
+import DashboardCard from 'src/views/CRUD/dashboard/DashboardCard';
 
 // store needed for withToasts(DashboardTable)
 const mockStore = configureStore([thunk]);
 const store = mockStore({});
 
-const dashboardsEndpoint = 'glob:*/api/v1/dashboard/*';
-const mockDashboards = [{ id: 1, url: 'url', dashboard_title: 'title' }];
+const dashboardsEndpoint = 'glob:*/api/v1/dashboard/?*';
+const chartsInfoEndpoint = 'glob:*/api/v1/chart/_info*';
+const mockDashboards = [
+  {
+    id: 1,
+    url: 'url',
+    dashboard_title: 'title',
+    changed_on_utc: '24 Feb 2014 10:13:14',
+  },
+];
 
 fetchMock.get(dashboardsEndpoint, { result: mockDashboards });
+fetchMock.get(chartsInfoEndpoint, {
+  permissions: ['can_list', 'can_edit', 'can_delete'],
+});
 
-function setup() {
-  // use mount because data fetching is triggered on mount
-  return mount(<DashboardTable />, {
+describe('DashboardTable', () => {
+  const dashboardProps = {
+    dashboardFilter: 'Favorite',
+    user: {
+      userId: '2',
+    },
+  };
+  const wrapper = mount(<DashboardTable {...dashboardProps} />, {
     context: { store },
-    wrappingComponent: ThemeProvider,
-    wrappingComponentProps: { theme: supersetTheme },
   });
-}
 
-describe('DashboardTable', () => {
-  beforeEach(fetchMock.resetHistory);
+  beforeAll(async () => {
+    await waitForComponentToPaint(wrapper);
+  });
 
-  it('fetches dashboards and renders a ListView', () => {
-    return new Promise(done => {
-      const wrapper = setup();
+  it('renders', () => {
+    expect(wrapper.find(DashboardTable)).toExist();
+  });
 
-      setTimeout(() => {
-        expect(fetchMock.calls(dashboardsEndpoint)).toHaveLength(1);
-        // there's a delay between response and updating state, so manually set it
-        // rather than adding a timeout which could introduce flakiness
-        wrapper.setState({ dashboards: mockDashboards });
-        expect(wrapper.find(ListView)).toExist();
-        done();
-      });
+  it('render a submenu with clickable tabs and buttons', async () => {
+    expect(wrapper.find(SubMenu)).toExist();
+    expect(wrapper.find('MenuItem')).toHaveLength(2);
+    expect(wrapper.find('Button')).toHaveLength(4);
+    act(() => {
+      wrapper.find('MenuItem').at(1).simulate('click');
     });
+    await waitForComponentToPaint(wrapper);
+    expect(fetchMock.calls(/dashboard\/\?q/)).toHaveLength(1);
+  });
+
+  it('fetches dashboards and renders a card', () => {
+    expect(fetchMock.calls(/dashboard\/\?q/)).toHaveLength(1);
+    wrapper.setState({ dashboards: mockDashboards });
+    expect(wrapper.find(DashboardCard)).toExist();
+  });
+
+  it('display EmptyState if there is no data', () => {

Review comment:
       Might be worth testing (in a loop, even!) the various flavors of this component, e.g:
   ```
   describe('EmptyState', () => {
   
     const variants = [
       {
         tab: 'Favorite',
         tableName: 'DASHBOARDS',
       },
       {
         tab: 'Mine',
         tableName: 'DASHBOARDS',
       },
       {
         tab: 'Favorite',
         tableName: 'CHARTS',
       },
       {
         tab: 'MINE',
         tableName: 'CHARTS',
       }
     ];
   
     variants.forEach(variant => {
         it(`it renders an ${variant.tab} ${variant.tableName} empty state`, () => {
           const wrapper = mount(<EmptyState {...variant} />);
           expect(wrapper).toExist();
           // ... you could add other bits (img path, text bits, etc) to the "variants" to assert against here, too.
         });
     });
   });
   ```

##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/ChartTable_spec.tsx
##########
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { mount } from 'enzyme';
+import thunk from 'redux-thunk';
+import fetchMock from 'fetch-mock';
+
+import configureStore from 'redux-mock-store';
+import ChartTable from 'src/views/CRUD/welcome/ChartTable';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+
+// store needed for withToasts(DashboardTable)

Review comment:
       ChartTable?

##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/ChartTable_spec.tsx
##########
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { mount } from 'enzyme';
+import thunk from 'redux-thunk';
+import fetchMock from 'fetch-mock';
+
+import configureStore from 'redux-mock-store';
+import ChartTable from 'src/views/CRUD/welcome/ChartTable';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+
+// store needed for withToasts(DashboardTable)
+const mockStore = configureStore([thunk]);
+const store = mockStore({});
+
+const chartsEndpoint = 'glob:*/api/v1/chart/?*';
+// fetchMock.get(chartsEndpoint, { result: mockDashboards });
+
+const mockCharts = [...new Array(3)].map((_, i) => ({
+  changed_on_utc: new Date().toISOString(),
+  created_by: 'super user',
+  id: i,
+  slice_name: `cool chart ${i}`,
+  url: 'url',
+  viz_type: 'bar',
+  datasource_title: `ds${i}`,
+  thumbnail_url: '/thumbnail',
+}));
+
+/* fetchMock.get(chartsEndpoint, {
+  result: [],
+});
+*/

Review comment:
       Comment looks deletable.

##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -139,19 +139,39 @@ const SkeletonActions = styled(Skeleton.Button)`
   width: ${({ theme }) => theme.gridUnit * 10}px;
 `;
 
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid #e0e0e0;
+  .title {
+    font-weight: 500;
+    color: #b2b2b2;
+  }
+  .holder {
+    margin: 10px 10px 10px 10px;

Review comment:
       shorthand would be `margin: 10px;` but let's try to use `gridUnit` here. Since most of the design system is on a 4px grid, it seems like this should either be `${... gridUnit *2}px` or `${... gridUnit *3}px`

##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -139,19 +139,39 @@ const SkeletonActions = styled(Skeleton.Button)`
   width: ${({ theme }) => theme.gridUnit * 10}px;
 `;
 
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid #e0e0e0;
+  .title {
+    font-weight: 500;

Review comment:
       Let's go with either `typography.weights.normal` (400) or `typography.weights.bold` (700) depending on which look you're going for. If we need a semi-bold variant, let's add it to the webfont styles and make sure it's in the `superset-ui` theme.

##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -139,19 +139,39 @@ const SkeletonActions = styled(Skeleton.Button)`
   width: ${({ theme }) => theme.gridUnit * 10}px;
 `;
 
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid #e0e0e0;
+  .title {
+    font-weight: 500;
+    color: #b2b2b2;
+  }
+  .holder {
+    margin: 10px 10px 10px 10px;
+  }
+`;
+
 const paragraphConfig = { rows: 1, width: 150 };
 interface CardProps {
   title: React.ReactNode;
   url?: string;
   imgURL: string;
+  tables?: string | number;
   imgFallbackURL: string;
   imgPosition?: BackgroundPosition;
   description: string;
   loading: boolean;
   titleRight?: React.ReactNode;
   coverLeft?: React.ReactNode;
   coverRight?: React.ReactNode;
-  actions: React.ReactNode;
+  actions: React.ReactNode | null;
+  showImg?: boolean;
+  rows?: number | string;
+  avatar?: string;
+  isRecent?: boolean;
+  tableName?: string;
 }
 
 function ListViewCard({

Review comment:
       Philosophical questions here... may warrant a call with @nytai and the gang.
   
   If we're breaking out DashboardCard and ChartCard as components, I'm wondering:
   * If we should do so for the other card variants as well
   * If we should put them somewhere outside the `crud` folder
   * If we can add storybook entries
   

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    if (e.item_url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getBatchData(user.userId, recent)
+      .then(r => {
+        const data: any = {
+          Created: [...r.createdByChart, ...r.createdByDash],
+          Edited: [...r.editedChart, ...r.editedDash],
+        };
+        if (r.viewed) {
+          const filtered = reject(r.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = r.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);
+        setLoading(false);
+      })
+      .catch(e => {
+        setLoading(false);
+        addDangerToast(
+          `There was an issue fetching your recent Acitivity: ${e}`,
+        );
+      });
+  }, []);
+
+  const renderActivity = () => {
+    return activityData[activeChild].map((e: MapProps, i: any) => (
+      <ListViewCard
+        key={`${i}`}

Review comment:
       This jumped out at me, and I wanted to say it should just be `key={i}` but then React would bark at you... so... if this works... well... cool, I guess

##########
File path: superset-frontend/src/views/CRUD/welcome/Welcome.tsx
##########
@@ -16,128 +16,79 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React, { useCallback, useState } from 'react';
-import {
-  Panel,
-  Row,
-  Col,
-  Tabs,
-  Tab,
-  FormControl,
-  FormControlProps,
-} from 'react-bootstrap';
-import { t } from '@superset-ui/core';
-import { useQueryParam, StringParam, QueryParamConfig } from 'use-query-params';
+import React from 'react';
+import { styled, t } from '@superset-ui/core';
+import { Collapse } from 'src/common/components';
 import { User } from 'src/types/bootstrapTypes';
-import RecentActivity from 'src/profile/components/RecentActivity';
-import Favorites from 'src/profile/components/Favorites';
+import { mq } from '../utils';
+import ActivityTable from './ActivityTable';
+import ChartTable from './ChartTable';
+import SavedQueries from './SavedQueries';
 import DashboardTable from './DashboardTable';
 
+const { Panel } = Collapse;
+
 interface WelcomeProps {
   user: User;
 }
 
-function useSyncQueryState(
-  queryParam: string,
-  queryParamType: QueryParamConfig<
-    string | null | undefined,
-    string | undefined
-  >,
-  defaultState: string,
-): [string, (val: string) => void] {
-  const [queryState, setQueryState] = useQueryParam(queryParam, queryParamType);
-  const [state, setState] = useState(queryState || defaultState);
-
-  const setQueryStateAndState = (val: string) => {
-    setQueryState(val);
-    setState(val);
-  };
-
-  return [state, setQueryStateAndState];
-}
+const WelcomeContainer = styled.div`
+  background-color: ${({ theme }) => theme.colors.grayscale.light4};
+  nav {
+    margin-top: -15px;
+    background-color: ${({ theme }) => theme.colors.grayscale.light4};
+    &:after {
+      content: '';
+      display: block;
+      border: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+      margin: 0px 26px;
+      position: relative;
+      ${[mq[1]]} {
+        margin-top: 5px;
+        margin: 0px 2px;
+      }
+    }
+    .nav.navbar-nav {
+      & > li:nth-child(1),
+      & > li:nth-child(2),
+      & > li:nth-child(3) {
+        margin-top: 8px;
+      }
+    }
+    button {
+      padding: 3px 21px;
+    }
+    .navbar-right {
+      position: relative;
+      top: 11px;
+    }
+  }
+  .ant-card.ant-card-bordered {
+    border: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+  }
+  .ant-collapse-header {
+    font-weight: 500;

Review comment:
       Theme has font-weights for 400 and 700 (medium and bold, respectively) if those can work here. If not, let's add to the theme!

##########
File path: superset/config.py
##########
@@ -846,7 +846,7 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
 # Enables the replacement react views for all the FAB views (list, edit, show) with
 # designs introduced in SIP-34: https://github.com/apache/incubator-superset/issues/8976
 # This is a work in progress so not all features available in FAB have been implemented
-ENABLE_REACT_CRUD_VIEWS = True
+ENABLE_REACT_CRUD_VIEWS = True 

Review comment:
       I think one of the python linters might bark about this trailing space.

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  margin-top: 20px;
+  img {
+    width: 114px;
+    display: block;
+    margin: 0 auto;
+    margin-bottom: 15px;
+  }
+  div:nth-child(2) {
+    text-align: center;
+    margin-top: 15px;
+    color: ${({ theme }) => theme.colors.grayscale.dark1};
+    font-weight: 400;
+  }
+  button {
+    margin: 0 auto;
+    padding: 6px 27px;
+    margin-top: 10px;
+    svg {
+      color: white;

Review comment:
       `colors.grayscale.light5` from the Theme is better than white :)

##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/ChartTable_spec.tsx
##########
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { mount } from 'enzyme';
+import thunk from 'redux-thunk';
+import fetchMock from 'fetch-mock';
+
+import configureStore from 'redux-mock-store';
+import ChartTable from 'src/views/CRUD/welcome/ChartTable';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+
+// store needed for withToasts(DashboardTable)
+const mockStore = configureStore([thunk]);
+const store = mockStore({});
+
+const chartsEndpoint = 'glob:*/api/v1/chart/?*';
+// fetchMock.get(chartsEndpoint, { result: mockDashboards });

Review comment:
       delete comment?

##########
File path: superset-frontend/src/views/CRUD/chart/ChartCard.tsx
##########
@@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { useFavoriteStatus } from 'src/views/CRUD/hooks';
+import { SupersetClient, t } from '@superset-ui/core';
+import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
+import Icon from 'src/components/Icon';
+import Chart from 'src/types/Chart';
+
+import ListViewCard from 'src/components/ListViewCard';
+import Label from 'src/components/Label';
+import { Dropdown, Menu } from 'src/common/components';
+import FaveStar from 'src/components/FaveStar';
+import FacePile from 'src/components/FacePile';
+
+const FAVESTAR_BASE_URL = '/superset/favstar/slice';
+
+interface ChartCardProps {
+  chart: Chart;
+  hasPerm: (perm: string) => boolean;
+  openChartEditModal: (chart: Chart) => void;
+  bulkSelectEnabled: boolean;
+  addDangerToast: (msg: string) => void;
+  addSuccessToast: (msg: string) => void;
+  refreshData: () => void;
+  loading: boolean;
+}
+
+export default function ChartCard({
+  chart,
+  hasPerm,
+  openChartEditModal,
+  bulkSelectEnabled,
+  addDangerToast,
+  addSuccessToast,
+  refreshData,
+  loading,
+}: ChartCardProps) {
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+  const [
+    favoriteStatusRef,
+    fetchFaveStar,
+    saveFaveStar,
+    favoriteStatus,
+  ] = useFavoriteStatus({}, FAVESTAR_BASE_URL, addDangerToast);
+
+  function handleChartDelete({ id, slice_name: sliceName }: Chart) {
+    SupersetClient.delete({
+      endpoint: `/api/v1/chart/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        addSuccessToast(t('Deleted: %s', sliceName));
+      },
+      () => {
+        addDangerToast(t('There was an issue deleting: %s', sliceName));
+      },
+    );
+  }
+
+  const menu = (
+    <Menu>
+      {canDelete && (
+        <Menu.Item>
+          <ConfirmStatusChange
+            title={t('Please Confirm')}
+            description={
+              <>
+                {t('Are you sure you want to delete')} <b>{chart.slice_name}</b>
+                ?
+              </>
+            }
+            onConfirm={() => handleChartDelete(chart)}
+          >
+            {confirmDelete => (
+              <div
+                role="button"
+                tabIndex={0}
+                className="action-button"
+                onClick={confirmDelete}
+              >
+                <ListViewCard.MenuIcon name="trash" /> Delete
+              </div>
+            )}
+          </ConfirmStatusChange>
+        </Menu.Item>
+      )}
+      {canEdit && (
+        <Menu.Item
+          role="button"
+          tabIndex={0}
+          onClick={() => openChartEditModal(chart)}
+        >
+          <ListViewCard.MenuIcon name="edit-alt" /> Edit

Review comment:
       Not sure if the space is needed before Edit, but maybe also make it `t('Edit')`

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  margin-top: 20px;
+  img {
+    width: 114px;
+    display: block;
+    margin: 0 auto;
+    margin-bottom: 15px;
+  }
+  div:nth-child(2) {
+    text-align: center;
+    margin-top: 15px;
+    color: ${({ theme }) => theme.colors.grayscale.dark1};
+    font-weight: 400;
+  }
+  button {
+    margin: 0 auto;
+    padding: 6px 27px;
+    margin-top: 10px;
+    svg {
+      color: white;
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const tableIcon = {
+    RECENTS: 'union.png',
+    DASHBOARDS: 'empty-dashboard.png',
+    CHARTS: 'empty-charts.png',
+    SAVED_QUERIES: 'empty-queries.png',
+  };
+  const mine = (
+    <div>
+      <div>{`No ${
+        tableName === 'SAVED_QUERIES'
+          ? 'saved queries'
+          : tableName.toLowerCase()
+      } yet`}</div>
+      <Button
+        buttonStyle="primary"
+        onClick={() => {
+          window.location = mineRedirects[tableName];
+        }}
+      >
+        <IconContainer>
+          <Icon name="plus-small" />{' '}
+          {tableName === 'SAVED_QUERIES'
+            ? 'SQL QUERY'
+            : tableName
+                .split('')
+                .slice(0, tableName.length - 1)
+                .join('')}{' '}
+        </IconContainer>
+      </Button>
+    </div>
+  );
+  const span = (
+    <div className="no-recents">
+      Recently {tab?.toLowerCase()} charts, dashboards, and saved queries will
+      appear here
+    </div>
+  );
+  // Mine and Recent Activity(all tabs) tab empty state
+  if (tab === 'Mine' || tableName === 'RECENTS') {
+    return (
+      <Container>
+        <img
+          src={`/static/assets/images/${tableIcon[tableName]}`}
+          alt={`${tableName}`}
+        />
+        {tableName === 'RECENTS' ? span : mine}
+      </Container>
+    );
+  }
+  // Favorite tab empty state
+  return (
+    <Container>
+      <img src="/static/assets/images/star-circle.png" alt="star.png" />
+      <div>
+        <div className="no-favorites">You don't have any favorites yet!</div>

Review comment:
       I'm not sure any more if it's best practice to wrap _all_ text content in `t()` or if it's kind of case-by-case, and we'll just get to it one day. Thoughts, @nytai / @mistercrunch ?

##########
File path: superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
##########
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t } from '@superset-ui/core';
+import { useListViewResource, useChartEditModal } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import PropertiesModal from 'src/explore/components/PropertiesModal';
+import { User } from 'src/types/bootstrapTypes';
+import Icon from 'src/components/Icon';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import Chart from 'src/types/Chart';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+import { CardContainer, IconContainer } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface ChartTableProps {
+  addDangerToast: (message: string) => void;
+  addSuccessToast: (message: string) => void;
+  search: string;
+  chartFilter?: string;
+  user?: User;
+}
+
+function ChartTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: ChartTableProps) {
+  const {
+    state: { loading, resourceCollection: charts, bulkSelectEnabled },
+    setResourceCollection: setCharts,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Chart>('chart', t('chart'), addDangerToast);
+
+  const {
+    sliceCurrentlyEditing,
+    openChartEditModal,
+    handleChartUpdated,
+    closeChartEditModal,
+  } = useChartEditModal(setCharts, charts);
+
+  const [chartFilter, setChartFilter] = useState('Favorite');
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (chartFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'chart_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [chartFilter]);
+
+  return (
+    <>
+      {sliceCurrentlyEditing && (
+        <PropertiesModal
+          onHide={closeChartEditModal}
+          onSave={handleChartUpdated}
+          show
+          slice={sliceCurrentlyEditing}
+        />
+      )}
+
+      <SubMenu
+        activeChild={chartFilter}
+        name=""

Review comment:
       make prop optional (_proptional?_) and delete it here?

##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -63,3 +142,39 @@ export function createErrorHandler(handleErrorFunc: (errMsg?: string) => void) {
     handleErrorFunc(parsedError.message || parsedError.error);
   };
 }
+
+export function handleDashboardDelete(id: string) {
+  return SupersetClient.delete({
+    endpoint: `/api/v1/dashboard/${id}`,
+  });
+}
+
+const breakpoints = [576, 768, 992, 1200];
+export const mq = breakpoints.map(bp => `@media (max-width: ${bp}px)`);
+
+export const CardContainer = styled.div`
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(48%, max-content));
+  }
+
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(50%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 6}px;
+`;
+
+export const IconContainer = styled.div`
+  svg {
+    vertical-align: -7px;

Review comment:
       Hmm... this raises a couple of questions:
   1) Do we need it? There's another PR open (The Filters P0 one) where I've tweaked on the Icon component to make them display a little differently. It basically sets them to `inline-block` at height/width of `1em` so they scale with the typography of their element. Not sure if it'll solve the alignment issue. I hope so.
   2) If we _DO_ wind up needing the vertical-align, does it work well with a nominal value (e.g. 'middle) or a percentage-based value?

##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -139,19 +139,39 @@ const SkeletonActions = styled(Skeleton.Button)`
   width: ${({ theme }) => theme.gridUnit * 10}px;
 `;
 
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid #e0e0e0;

Review comment:
       Please use Theme for all colors, typography variants and (when it makes sense) margins/paddings/spacings (i.e. gridUnit multiples).
   
   This #e0e0e0 should be `grayscale.light2`

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    if (e.item_url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getBatchData(user.userId, recent)
+      .then(r => {

Review comment:
       Pedantic nit, but something more explicit than `r` might be nice... is it a `recentObject` or something?

##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/ChartTable_spec.tsx
##########
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { mount } from 'enzyme';
+import thunk from 'redux-thunk';
+import fetchMock from 'fetch-mock';
+
+import configureStore from 'redux-mock-store';
+import ChartTable from 'src/views/CRUD/welcome/ChartTable';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+
+// store needed for withToasts(DashboardTable)
+const mockStore = configureStore([thunk]);
+const store = mockStore({});
+
+const chartsEndpoint = 'glob:*/api/v1/chart/?*';
+// fetchMock.get(chartsEndpoint, { result: mockDashboards });
+
+const mockCharts = [...new Array(3)].map((_, i) => ({
+  changed_on_utc: new Date().toISOString(),
+  created_by: 'super user',
+  id: i,
+  slice_name: `cool chart ${i}`,
+  url: 'url',
+  viz_type: 'bar',
+  datasource_title: `ds${i}`,
+  thumbnail_url: '/thumbnail',
+}));
+
+/* fetchMock.get(chartsEndpoint, {
+  result: [],
+});
+*/
+fetchMock.get(chartsEndpoint, {
+  result: mockCharts,
+});
+
+describe('DashboardTable', () => {

Review comment:
       ChartTable

##########
File path: superset-frontend/src/views/CRUD/welcome/Welcome.tsx
##########
@@ -16,128 +16,79 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React, { useCallback, useState } from 'react';
-import {
-  Panel,
-  Row,
-  Col,
-  Tabs,
-  Tab,
-  FormControl,
-  FormControlProps,
-} from 'react-bootstrap';
-import { t } from '@superset-ui/core';
-import { useQueryParam, StringParam, QueryParamConfig } from 'use-query-params';
+import React from 'react';
+import { styled, t } from '@superset-ui/core';
+import { Collapse } from 'src/common/components';
 import { User } from 'src/types/bootstrapTypes';
-import RecentActivity from 'src/profile/components/RecentActivity';
-import Favorites from 'src/profile/components/Favorites';
+import { mq } from '../utils';
+import ActivityTable from './ActivityTable';
+import ChartTable from './ChartTable';
+import SavedQueries from './SavedQueries';
 import DashboardTable from './DashboardTable';
 
+const { Panel } = Collapse;
+
 interface WelcomeProps {
   user: User;
 }
 
-function useSyncQueryState(
-  queryParam: string,
-  queryParamType: QueryParamConfig<
-    string | null | undefined,
-    string | undefined
-  >,
-  defaultState: string,
-): [string, (val: string) => void] {
-  const [queryState, setQueryState] = useQueryParam(queryParam, queryParamType);
-  const [state, setState] = useState(queryState || defaultState);
-
-  const setQueryStateAndState = (val: string) => {
-    setQueryState(val);
-    setState(val);
-  };
-
-  return [state, setQueryStateAndState];
-}
+const WelcomeContainer = styled.div`

Review comment:
       Let's make all the `px` values in this `WelcomeContainer` be clean multiples of `gridUnit` wherever possible.

##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -139,19 +139,39 @@ const SkeletonActions = styled(Skeleton.Button)`
   width: ${({ theme }) => theme.gridUnit * 10}px;
 `;
 
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid #e0e0e0;
+  .title {
+    font-weight: 500;
+    color: #b2b2b2;

Review comment:
       grayscale.light1

##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -63,3 +142,39 @@ export function createErrorHandler(handleErrorFunc: (errMsg?: string) => void) {
     handleErrorFunc(parsedError.message || parsedError.error);
   };
 }
+
+export function handleDashboardDelete(id: string) {
+  return SupersetClient.delete({
+    endpoint: `/api/v1/dashboard/${id}`,
+  });
+}
+
+const breakpoints = [576, 768, 992, 1200];
+export const mq = breakpoints.map(bp => `@media (max-width: ${bp}px)`);
+
+export const CardContainer = styled.div`
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(48%, max-content));
+  }
+
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(50%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 6}px;
+`;
+
+export const IconContainer = styled.div`
+  svg {
+    vertical-align: -7px;
+    color: ${({ theme }) => theme.colors.primary.dark1};

Review comment:
       What color does the icon show up as if you don't set the `color` here? Seems like the `Button` component should be providing that color to be picked up by the icon. If it's not doing that, maybe we can open an Issue around the getting that to work correctly, referencing this.
   
   Also, for this whole Styled implementation is for these `+ Object` buttons, it might be worth noting that the other ones (in list view SubNav components and possibly elsewhere) use the <i className="fa fa-plus" /> treatment. I'd _much rather_ use the new Design System and Icon component like you're on to in this PR, so maybe we can make a `cosmetic-issue` on GitHub to consolidate those as a follow-up task?

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;

Review comment:
       Not sure if 15px is _just right_ here or if -16 works just as well, but I'd like to see the various pixel measurements here use the `gridUnit` wherever possible

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    if (e.item_url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getBatchData(user.userId, recent)
+      .then(r => {
+        const data: any = {
+          Created: [...r.createdByChart, ...r.createdByDash],
+          Edited: [...r.editedChart, ...r.editedDash],
+        };
+        if (r.viewed) {
+          const filtered = reject(r.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = r.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);
+        setLoading(false);
+      })
+      .catch(e => {
+        setLoading(false);
+        addDangerToast(
+          `There was an issue fetching your recent Acitivity: ${e}`,
+        );
+      });
+  }, []);
+
+  const renderActivity = () => {
+    return activityData[activeChild].map((e: MapProps, i: any) => (
+      <ListViewCard
+        key={`${i}`}
+        isRecent
+        loading={loading}
+        imgURL=""
+        imgFallbackURL=""
+        url={e.sql ? `/supserset/sqllab?queryId=${e.id}` : e.url}
+        title={getFilterTitle(e)}
+        description={`Last Edited: ${moment(e.changed_on_utc).format(
+          'MM/DD/YYYY HH:mm:ss',
+        )}`}
+        avatar={getIconName(e)}
+        actions={null}
+      />
+    ));
+  };
+  if (loading) return <>loading ...</>;
+  return (
+    <>
+      <>

Review comment:
       Are two layers of `<>` necessary here?

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    if (e.item_url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }

Review comment:
       You could do both of these with the `.includes` syntax as well. 
   
   Combining the two is also possible:
   ```
       if (e.url?.includes('explore') || e.item_url?.includes('explore')) {
         return 'nav-charts';
       }
   ```
   or (this is pretty goofy... but... well... I'm typing it anyway)
   ```
       if (e.url?.concat(e.item_url || []).includes('explore')) {
         return 'nav-charts';
       }
   ```

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {

Review comment:
       ```suggestion
       if (e.url?.includes('dashboard')) {
   ```
   This might be easier to read

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    if (e.item_url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getBatchData(user.userId, recent)
+      .then(r => {
+        const data: any = {
+          Created: [...r.createdByChart, ...r.createdByDash],
+          Edited: [...r.editedChart, ...r.editedDash],
+        };
+        if (r.viewed) {
+          const filtered = reject(r.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = r.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);
+        setLoading(false);
+      })
+      .catch(e => {
+        setLoading(false);
+        addDangerToast(
+          `There was an issue fetching your recent Acitivity: ${e}`,
+        );
+      });
+  }, []);
+
+  const renderActivity = () => {
+    return activityData[activeChild].map((e: MapProps, i: any) => (
+      <ListViewCard
+        key={`${i}`}
+        isRecent
+        loading={loading}
+        imgURL=""
+        imgFallbackURL=""
+        url={e.sql ? `/supserset/sqllab?queryId=${e.id}` : e.url}
+        title={getFilterTitle(e)}
+        description={`Last Edited: ${moment(e.changed_on_utc).format(
+          'MM/DD/YYYY HH:mm:ss',
+        )}`}
+        avatar={getIconName(e)}
+        actions={null}
+      />
+    ));
+  };
+  if (loading) return <>loading ...</>;

Review comment:
       Not sure how long this is usually loading, but we DO have a Loading component if you wanna get fancy.

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    if (e.item_url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    return '';

Review comment:
       Hmm... should this be null?

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;

Review comment:
       Theme: typography.weights.bold

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    if (e.item_url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getBatchData(user.userId, recent)
+      .then(r => {
+        const data: any = {
+          Created: [...r.createdByChart, ...r.createdByDash],
+          Edited: [...r.editedChart, ...r.editedDash],
+        };
+        if (r.viewed) {
+          const filtered = reject(r.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = r.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);
+        setLoading(false);
+      })
+      .catch(e => {
+        setLoading(false);
+        addDangerToast(
+          `There was an issue fetching your recent Acitivity: ${e}`,
+        );
+      });
+  }, []);
+
+  const renderActivity = () => {
+    return activityData[activeChild].map((e: MapProps, i: any) => (

Review comment:
       `i` should be of type `number`

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    if (e.item_url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getBatchData(user.userId, recent)
+      .then(r => {
+        const data: any = {
+          Created: [...r.createdByChart, ...r.createdByDash],
+          Edited: [...r.editedChart, ...r.editedDash],
+        };
+        if (r.viewed) {
+          const filtered = reject(r.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = r.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);
+        setLoading(false);
+      })
+      .catch(e => {
+        setLoading(false);
+        addDangerToast(
+          `There was an issue fetching your recent Acitivity: ${e}`,
+        );
+      });
+  }, []);
+
+  const renderActivity = () => {
+    return activityData[activeChild].map((e: MapProps, i: any) => (
+      <ListViewCard
+        key={`${i}`}
+        isRecent
+        loading={loading}
+        imgURL=""
+        imgFallbackURL=""

Review comment:
       Maybe these shouldn't be provided here, and should be made optional?

##########
File path: superset-frontend/src/views/CRUD/hooks.ts
##########
@@ -33,6 +35,11 @@ interface ListViewResourceState<D extends object = any> {
   bulkSelectEnabled: boolean;
 }
 
+interface EditChartModal {
+  setCharts: () => void;
+  charts: Array<any>;

Review comment:
       Should this be `Array<Chart>`?

##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),

Review comment:
       Do you anticipate the `getFilters` logic getting more complicated with other cases/filters? If you're planning for expansion, no worries, but if it's just the two options, maybe it's simpler to get rid of `getFilters` entirely and just do 
   ```
         filters: [
            queryFilter === 'Mine' ?
               {
                 id: 'created_by',
                 operator: 'rel_o_m',
                 value: `${user?.userId}`,
               } :
               {
                 id: 'id',
                 operator: 'saved_query_is_fav',
                 value: true,
               }
         ],
   ```
   

##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/ActivityTable_spec.tsx
##########
@@ -0,0 +1,89 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styledMount as mount } from 'spec/helpers/theming';
+import thunk from 'redux-thunk';
+import fetchMock from 'fetch-mock';
+
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+import configureStore from 'redux-mock-store';
+import ActivityTable from 'src/views/CRUD/welcome/ActivityTable';
+import ListViewCard from 'src/components/ListViewCard';
+
+const mockStore = configureStore([thunk]);
+const store = mockStore({});
+
+const chartsEndpoint = 'glob:*/api/v1/chart/?*';
+const dashboardEndpoint = 'glob:*/api/v1/dashboard/?*';
+const savedQueryEndpoint = 'glob:*/api/v1/saved_query/?*';
+
+fetchMock.get(chartsEndpoint, {
+  result: [
+    {
+      slice_name: 'ChartyChart',

Review comment:
       NIT: ChartyMcChart

##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            // @ts-ignore
+            window.location = `/superset/sqllab?savedQueryId=${query.id}`;
+          }}
+        >
+          Edit
+        </Menu.Item>
+      )}
+      <Menu.Item
+        onClick={() => {
+          if (query.id)
+            copyQueryLink(query.id, addDangerToast, addSuccessToast);
+        }}
+      >
+        Share
+      </Menu.Item>
+      {canDelete && (
+        <Menu.Item
+          onClick={() => {
+            setQueryDeleteModal(true);
+            setCurrentlyEdited(query);
+          }}
+        >
+          Delete
+        </Menu.Item>
+      )}
+    </Menu>
+  );
+  return (
+    <>
+      {queryDeleteModal && (
+        <DeleteModal
+          description={t(
+            'This action will permanently delete the saved query.',
+          )}
+          onConfirm={() => {
+            if (queryDeleteModal) {
+              handleQueryDelete(currentlyEdited);
+            }
+          }}
+          onHide={() => {
+            setQueryDeleteModal(false);
+          }}
+          open
+          title={t('Delete Query?')}
+        />
+      )}
+      <SubMenu
+        activeChild={queryFilter}
+        name=""
+        // eslint-disable-next-line react/no-children-prop
+        children={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setQueryFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setQueryFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> SQL Query{' '}

Review comment:
       Not sure the `{' '}` space is doing real work here, is it a byproduct of the linter?

##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            // @ts-ignore
+            window.location = `/superset/sqllab?savedQueryId=${query.id}`;
+          }}
+        >
+          Edit
+        </Menu.Item>
+      )}
+      <Menu.Item
+        onClick={() => {
+          if (query.id)
+            copyQueryLink(query.id, addDangerToast, addSuccessToast);
+        }}
+      >
+        Share
+      </Menu.Item>
+      {canDelete && (
+        <Menu.Item
+          onClick={() => {
+            setQueryDeleteModal(true);
+            setCurrentlyEdited(query);
+          }}
+        >
+          Delete
+        </Menu.Item>
+      )}
+    </Menu>
+  );
+  return (
+    <>
+      {queryDeleteModal && (
+        <DeleteModal
+          description={t(
+            'This action will permanently delete the saved query.',
+          )}
+          onConfirm={() => {
+            if (queryDeleteModal) {
+              handleQueryDelete(currentlyEdited);
+            }
+          }}
+          onHide={() => {
+            setQueryDeleteModal(false);
+          }}
+          open
+          title={t('Delete Query?')}
+        />
+      )}
+      <SubMenu
+        activeChild={queryFilter}
+        name=""
+        // eslint-disable-next-line react/no-children-prop
+        children={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setQueryFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setQueryFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> SQL Query{' '}
+              </IconContainer>
+            ),
+            buttonStyle: 'tertiary',
+            onClick: () => {
+              // @ts-ignore
+              window.location = '/superset/sqllab';

Review comment:
       see prior comment about trying `window.location.href`

##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            // @ts-ignore
+            window.location = `/superset/sqllab?savedQueryId=${query.id}`;
+          }}
+        >
+          Edit
+        </Menu.Item>
+      )}
+      <Menu.Item
+        onClick={() => {
+          if (query.id)
+            copyQueryLink(query.id, addDangerToast, addSuccessToast);
+        }}
+      >
+        Share
+      </Menu.Item>
+      {canDelete && (
+        <Menu.Item
+          onClick={() => {
+            setQueryDeleteModal(true);
+            setCurrentlyEdited(query);
+          }}
+        >
+          Delete

Review comment:
       `t(Delete)`?

##########
File path: superset-frontend/spec/javascripts/views/CRUD/welcome/DashboardTable_spec.tsx
##########
@@ -17,48 +17,75 @@
  * under the License.
  */
 import React from 'react';
-import { mount } from 'enzyme';
+import { styledMount as mount } from 'spec/helpers/theming';
 import thunk from 'redux-thunk';
 import configureStore from 'redux-mock-store';
 import fetchMock from 'fetch-mock';
-import { supersetTheme, ThemeProvider } from '@superset-ui/core';
+import { act } from 'react-dom/test-utils';
 
-import ListView from 'src/components/ListView';
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+import SubMenu from 'src/components/Menu/SubMenu';
 import DashboardTable from 'src/views/CRUD/welcome/DashboardTable';
+import DashboardCard from 'src/views/CRUD/dashboard/DashboardCard';
 
 // store needed for withToasts(DashboardTable)
 const mockStore = configureStore([thunk]);
 const store = mockStore({});
 
-const dashboardsEndpoint = 'glob:*/api/v1/dashboard/*';
-const mockDashboards = [{ id: 1, url: 'url', dashboard_title: 'title' }];
+const dashboardsEndpoint = 'glob:*/api/v1/dashboard/?*';
+const chartsInfoEndpoint = 'glob:*/api/v1/chart/_info*';
+const mockDashboards = [
+  {
+    id: 1,
+    url: 'url',
+    dashboard_title: 'title',
+    changed_on_utc: '24 Feb 2014 10:13:14',
+  },
+];
 
 fetchMock.get(dashboardsEndpoint, { result: mockDashboards });
+fetchMock.get(chartsInfoEndpoint, {
+  permissions: ['can_list', 'can_edit', 'can_delete'],
+});
 
-function setup() {
-  // use mount because data fetching is triggered on mount
-  return mount(<DashboardTable />, {
+describe('DashboardTable', () => {
+  const dashboardProps = {
+    dashboardFilter: 'Favorite',
+    user: {
+      userId: '2',
+    },
+  };
+  const wrapper = mount(<DashboardTable {...dashboardProps} />, {
     context: { store },
-    wrappingComponent: ThemeProvider,

Review comment:
       Thanks for the cleanup

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getBatchData, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {
+  action?: string;
+  item_title?: string;
+  slice_name: string;
+  time: string;
+  changed_on_utc: string;
+  url: string;
+  sql: string;
+  dashboard_title: string;
+  label: string;
+  id: string;
+  table: object;
+  item_url: string;
+}
+
+interface ActivityProps {
+  user: {
+    userId: string | number;
+  };
+}
+
+interface ActivityData {
+  Created?: Array<object>;
+  Edited?: Array<object>;
+  Viewed?: Array<object>;
+  Examples?: Array<object>;
+}
+
+const ActivityContainer = styled.div`
+  margin-left: 10px;
+  margin-top: -15px;
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
+  }
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(63%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 4}px;
+  .ant-card-meta-avatar {
+    margin-top: 10px;
+    margin-left: 5px;
+  }
+  .ant-card-meta-title {
+    font-weight: 700;
+  }
+`;
+
+export default function ActivityTable({ user }: ActivityProps) {
+  const [activityData, setActivityData] = useState<ActivityData>({});
+  const [loading, setLoading] = useState(true);
+  const [activeChild, setActiveChild] = useState('Viewed');
+  // this api uses log for data which in some cases can be empty
+  const recent = `/superset/recent_activity/${user.userId}/?limit=5`;
+
+  const getFilterTitle = (e: MapProps) => {
+    if (e.dashboard_title) return e.dashboard_title;
+    if (e.label) return e.label;
+    if (e.url && !e.table) return e.item_title;
+    if (e.item_title) return e.item_title;
+    return e.slice_name;
+  };
+
+  const getIconName = (e: MapProps) => {
+    if (e.sql) return 'sql';
+    if (e.url?.indexOf('dashboard') !== -1) {
+      return 'nav-dashboard';
+    }
+    if (e.url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    if (e.item_url?.indexOf('explore') !== -1) {
+      return 'nav-charts';
+    }
+    return '';
+  };
+
+  const tabs = [
+    {
+      name: 'Edited',
+      label: t('Edited'),
+      onClick: () => {
+        setActiveChild('Edited');
+      },
+    },
+    {
+      name: 'Created',
+      label: t('Created'),
+      onClick: () => {
+        setActiveChild('Created');
+      },
+    },
+  ];
+
+  if (activityData.Viewed) {
+    tabs.unshift({
+      name: 'Viewed',
+      label: t('Viewed'),
+      onClick: () => {
+        setActiveChild('Viewed');
+      },
+    });
+  } else {
+    tabs.unshift({
+      name: 'Examples',
+      label: t('Examples'),
+      onClick: () => {
+        setActiveChild('Examples');
+      },
+    });
+  }
+
+  useEffect(() => {
+    getBatchData(user.userId, recent)
+      .then(r => {
+        const data: any = {
+          Created: [...r.createdByChart, ...r.createdByDash],
+          Edited: [...r.editedChart, ...r.editedDash],
+        };
+        if (r.viewed) {
+          const filtered = reject(r.viewed, ['item_url', null]).map(r => r);
+          data.Viewed = filtered;
+          setActiveChild('Viewed');
+        } else {
+          data.Examples = r.examples;
+          setActiveChild('Examples');
+        }
+        setActivityData(data);
+        setLoading(false);
+      })
+      .catch(e => {
+        setLoading(false);
+        addDangerToast(
+          `There was an issue fetching your recent Acitivity: ${e}`,
+        );
+      });
+  }, []);
+
+  const renderActivity = () => {
+    return activityData[activeChild].map((e: MapProps, i: any) => (
+      <ListViewCard
+        key={`${i}`}
+        isRecent
+        loading={loading}
+        imgURL=""
+        imgFallbackURL=""
+        url={e.sql ? `/supserset/sqllab?queryId=${e.id}` : e.url}
+        title={getFilterTitle(e)}
+        description={`Last Edited: ${moment(e.changed_on_utc).format(
+          'MM/DD/YYYY HH:mm:ss',
+        )}`}
+        avatar={getIconName(e)}
+        actions={null}
+      />
+    ));
+  };
+  if (loading) return <>loading ...</>;
+  return (
+    <>
+      <>
+        <SubMenu
+          activeChild={activeChild}
+          name=""

Review comment:
       If `name` is not needed by the component, maybe we should make that optional, and just not provide it here.

##########
File path: superset-frontend/src/views/CRUD/hooks.ts
##########
@@ -348,5 +355,87 @@ export function useFavoriteStatus(
     );
   };
 
-  return [favoriteStatusRef, fetchFaveStar, saveFaveStar] as const;
+  return [
+    favoriteStatusRef,
+    fetchFaveStar,
+    saveFaveStar,
+    favoriteStatus,
+  ] as const;
 }
+
+export const useChartEditModal = (
+  setCharts: (charts: Array<Chart>) => void,
+  charts: Array<Chart>,
+) => {
+  const [
+    sliceCurrentlyEditing,
+    setSliceCurrentlyEditing,
+  ] = useState<Slice | null>(null);
+
+  function openChartEditModal(chart: Chart) {
+    setSliceCurrentlyEditing({
+      slice_id: chart.id,
+      slice_name: chart.slice_name,
+      description: chart.description,
+      cache_timeout: chart.cache_timeout,
+    });
+  }
+
+  function closeChartEditModal() {
+    setSliceCurrentlyEditing(null);
+  }
+
+  function handleChartUpdated(edits: Chart) {
+    // update the chart in our state with the edited info
+    const newCharts = charts.map((chart: Chart) =>
+      chart.id === edits.id ? { ...chart, ...edits } : chart,
+    );
+    setCharts(newCharts);
+  }
+
+  return {
+    sliceCurrentlyEditing,
+    handleChartUpdated,
+    openChartEditModal,
+    closeChartEditModal,
+  };
+};
+
+export const copyQueryLink = (

Review comment:
       This doesn't seem like a `hook` so much as a util. Curious what @nytai thinks about the reusability opportunities here, but I'm seeing this same basic logic play out in `SavedQueryList.tsx` and in `CopyToClipboard.tsx`
   
   It seems like we could share this whole block of clipboard logic in some global `utils` file. I think you would just need to pass it your text content, and (optional) override strings for success/error toasts.
   
   If y'all don't think it's worth DRYing up in this PR, but think it IS worth doing, please create an Issue and it can be followed up on separately.

##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            // @ts-ignore
+            window.location = `/superset/sqllab?savedQueryId=${query.id}`;
+          }}
+        >
+          Edit

Review comment:
       `t(Edit)`?

##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            // @ts-ignore

Review comment:
       If this is `ts-ignored` because `window.location` expects a `Location` type, you might be able to get it to work with `window.location.href` which takes a `string`.

##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            // @ts-ignore
+            window.location = `/superset/sqllab?savedQueryId=${query.id}`;
+          }}
+        >
+          Edit
+        </Menu.Item>
+      )}
+      <Menu.Item
+        onClick={() => {
+          if (query.id)
+            copyQueryLink(query.id, addDangerToast, addSuccessToast);
+        }}
+      >
+        Share
+      </Menu.Item>
+      {canDelete && (
+        <Menu.Item
+          onClick={() => {
+            setQueryDeleteModal(true);
+            setCurrentlyEdited(query);
+          }}
+        >
+          Delete
+        </Menu.Item>
+      )}
+    </Menu>
+  );
+  return (
+    <>
+      {queryDeleteModal && (
+        <DeleteModal
+          description={t(
+            'This action will permanently delete the saved query.',
+          )}
+          onConfirm={() => {
+            if (queryDeleteModal) {
+              handleQueryDelete(currentlyEdited);
+            }
+          }}
+          onHide={() => {
+            setQueryDeleteModal(false);
+          }}
+          open
+          title={t('Delete Query?')}
+        />
+      )}
+      <SubMenu
+        activeChild={queryFilter}
+        name=""
+        // eslint-disable-next-line react/no-children-prop
+        children={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setQueryFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setQueryFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> SQL Query{' '}
+              </IconContainer>
+            ),
+            buttonStyle: 'tertiary',
+            onClick: () => {
+              // @ts-ignore
+              window.location = '/superset/sqllab';
+            },
+          },
+          {
+            name: 'View All »',
+            buttonStyle: 'link',
+            onClick: () => {
+              // @ts-ignore
+              window.location = '/savedqueryview/list';
+            },
+          },
+        ]}
+      />
+      {queries.length > 0 ? (
+        <CardContainer>
+          {queries.map((q, i) => (
+            <ListViewCard
+              key={`${i}`}

Review comment:
       There was another spot where I saw this and thought it was OK, but actually, this could lead to problems ([see here](https://medium.com/@robinpokorny/index-as-a-key-is-an-anti-pattern-e0349aece318)). Long story short, if the order of some items in the array changes, you may see the wrong content! Better to use something like  `q.id` here.

##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            // @ts-ignore
+            window.location = `/superset/sqllab?savedQueryId=${query.id}`;
+          }}
+        >
+          Edit
+        </Menu.Item>
+      )}
+      <Menu.Item
+        onClick={() => {
+          if (query.id)
+            copyQueryLink(query.id, addDangerToast, addSuccessToast);
+        }}
+      >
+        Share
+      </Menu.Item>
+      {canDelete && (
+        <Menu.Item
+          onClick={() => {
+            setQueryDeleteModal(true);
+            setCurrentlyEdited(query);
+          }}
+        >
+          Delete
+        </Menu.Item>
+      )}
+    </Menu>
+  );
+  return (
+    <>
+      {queryDeleteModal && (
+        <DeleteModal
+          description={t(
+            'This action will permanently delete the saved query.',
+          )}
+          onConfirm={() => {
+            if (queryDeleteModal) {
+              handleQueryDelete(currentlyEdited);
+            }
+          }}
+          onHide={() => {
+            setQueryDeleteModal(false);
+          }}
+          open
+          title={t('Delete Query?')}
+        />
+      )}
+      <SubMenu
+        activeChild={queryFilter}
+        name=""
+        // eslint-disable-next-line react/no-children-prop
+        children={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setQueryFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setQueryFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> SQL Query{' '}
+              </IconContainer>
+            ),
+            buttonStyle: 'tertiary',
+            onClick: () => {
+              // @ts-ignore
+              window.location = '/superset/sqllab';
+            },
+          },
+          {
+            name: 'View All »',
+            buttonStyle: 'link',
+            onClick: () => {
+              // @ts-ignore
+              window.location = '/savedqueryview/list';

Review comment:
       see prior comment about trying `window.location.href` to make typescript happier.

##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t, SupersetClient } from '@superset-ui/core';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dropdown, Menu } from 'src/common/components';
+import { useListViewResource, copyQueryLink } from 'src/views/CRUD/hooks';
+import ListViewCard from 'src/components/ListViewCard';
+import DeleteModal from 'src/components/DeleteModal';
+import Icon from 'src/components/Icon';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+
+import { IconContainer, CardContainer, createErrorHandler } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface Query {
+  id?: number;
+  sql_tables?: Array<any>;
+  database?: {
+    database_name: string;
+  };
+  rows?: string;
+  description?: string;
+  end_time?: string;
+  label?: string;
+}
+
+interface SavedQueriesProps {
+  user: {
+    userId: string | number;
+  };
+  queryFilter: string;
+  addDangerToast: (arg0: string) => void;
+  addSuccessToast: (arg0: string) => void;
+}
+
+const SavedQueries = ({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: SavedQueriesProps) => {
+  const {
+    state: { loading, resourceCollection: queries },
+    hasPerm,
+    fetchData,
+    refreshData,
+  } = useListViewResource<Query>('saved_query', t('query'), addDangerToast);
+  const [queryFilter, setQueryFilter] = useState('Favorite');
+  const [queryDeleteModal, setQueryDeleteModal] = useState(false);
+  const [currentlyEdited, setCurrentlyEdited] = useState<Query>({});
+
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+
+  const handleQueryDelete = ({ id, label }: Query) => {
+    SupersetClient.delete({
+      endpoint: `/api/v1/saved_query/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        setQueryDeleteModal(false);
+        addSuccessToast(t('Deleted: %s', label));
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(t('There was an issue deleting %s: %s', label, errMsg)),
+      ),
+    );
+  };
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (queryFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'saved_query_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [queryFilter]);
+
+  const renderMenu = (query: Query) => (
+    <Menu>
+      {canEdit && (
+        <Menu.Item
+          onClick={() => {
+            // @ts-ignore
+            window.location = `/superset/sqllab?savedQueryId=${query.id}`;
+          }}
+        >
+          Edit
+        </Menu.Item>
+      )}
+      <Menu.Item
+        onClick={() => {
+          if (query.id)
+            copyQueryLink(query.id, addDangerToast, addSuccessToast);
+        }}
+      >
+        Share

Review comment:
       `t(Share)`?

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  margin-top: 20px;
+  img {
+    width: 114px;
+    display: block;
+    margin: 0 auto;
+    margin-bottom: 15px;
+  }
+  div:nth-child(2) {
+    text-align: center;
+    margin-top: 15px;
+    color: ${({ theme }) => theme.colors.grayscale.dark1};
+    font-weight: 400;
+  }
+  button {
+    margin: 0 auto;
+    padding: 6px 27px;
+    margin-top: 10px;
+    svg {
+      color: white;
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const tableIcon = {
+    RECENTS: 'union.png',
+    DASHBOARDS: 'empty-dashboard.png',
+    CHARTS: 'empty-charts.png',
+    SAVED_QUERIES: 'empty-queries.png',
+  };
+  const mine = (
+    <div>
+      <div>{`No ${
+        tableName === 'SAVED_QUERIES'
+          ? 'saved queries'
+          : tableName.toLowerCase()
+      } yet`}</div>

Review comment:
       If the underscore is the issue here, you could do 
   ```suggestion
         <div>{`No ${tableName.split('_').join(' ').toLowerCase()} yet`}</div>
   ```

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`

Review comment:
       would love to see more gridUnits and fewer static pixel measurements in this block.

##########
File path: superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
##########
@@ -16,169 +16,180 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React from 'react';
-import { t, SupersetClient } from '@superset-ui/core';
-import { debounce } from 'lodash';
-import ListView, { FetchDataConfig } from 'src/components/ListView';
+import React, { useEffect, useState } from 'react';
+import { SupersetClient, t } from '@superset-ui/core';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import { Dashboard, DashboardTableProps } from 'src/views/CRUD/types';
 import withToasts from 'src/messageToasts/enhancers/withToasts';
-import { Dashboard } from 'src/types/bootstrapTypes';
+import PropertiesModal from 'src/dashboard/components/PropertiesModal';
+import DashboardCard from 'src/views/CRUD/dashboard/DashboardCard';
+import SubMenu from 'src/components/Menu/SubMenu';
+import Icon from 'src/components/Icon';
+import EmptyState from './EmptyState';
+import { createErrorHandler, CardContainer, IconContainer } from '../utils';
 
-const PAGE_SIZE = 25;
+const PAGE_SIZE = 3;
 
-interface DashboardTableProps {
-  addDangerToast: (message: string) => void;
-  search?: string;
+export interface FilterValue {
+  col: string;
+  operator: string;
+  value: string | boolean | number | null | undefined;
 }
 
-interface DashboardTableState {
-  dashboards: Dashboard[];
-  dashboard_count: number;
-  loading: boolean;
-}
+function DashboardTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: DashboardTableProps) {
+  const {
+    state: { loading, resourceCollection: dashboards, bulkSelectEnabled },
+    setResourceCollection: setDashboards,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Dashboard>(
+    'dashboard',
+    t('dashboard'),
+    addDangerToast,
+  );
 
-class DashboardTable extends React.PureComponent<
-  DashboardTableProps,
-  DashboardTableState
-> {
-  columns = [
-    {
-      accessor: 'dashboard_title',
-      Header: 'Dashboard',
-      Cell: ({
-        row: {
-          original: { url, dashboard_title: dashboardTitle },
-        },
-      }: {
-        row: {
-          original: {
-            url: string;
-            dashboard_title: string;
-          };
-        };
-      }) => <a href={url}>{dashboardTitle}</a>,
-    },
-    {
-      accessor: 'changed_by.first_name',
-      Header: 'Modified By',
-      Cell: ({
-        row: {
-          original: { changed_by_name: changedByName, changedByUrl },
-        },
-      }: {
-        row: {
-          original: {
-            changed_by_name: string;
-            changedByUrl: string;
-          };
-        };
-      }) => <a href={changedByUrl}>{changedByName}</a>,
-    },
-    {
-      accessor: 'changed_on_delta_humanized',
-      Header: 'Modified',
-      Cell: ({
-        row: {
-          original: { changed_on_delta_humanized: changedOn },
-        },
-      }: {
-        row: {
-          original: {
-            changed_on_delta_humanized: string;
-          };
-        };
-      }) => <span className="no-wrap">{changedOn}</span>,
-    },
-  ];
+  const [editModal, setEditModal] = useState<Dashboard | null>(null);
+  const [dashboardFilter, setDashboardFilter] = useState('Favorite');
 
-  initialSort = [{ id: 'changed_on_delta_humanized', desc: true }];
+  const handleDashboardEdit = (edits: Dashboard) => {
+    return SupersetClient.get({
+      endpoint: `/api/v1/dashboard/${edits.id}`,
+    }).then(
+      ({ json = {} }) => {
+        setDashboards(
+          dashboards.map(dashboard => {
+            if (dashboard.id === json.id) {
+              return json.result;
+            }
+            return dashboard;
+          }),
+        );
+      },
+      createErrorHandler(errMsg =>
+        addDangerToast(
+          t('An error occurred while fetching dashboards: %s', errMsg),
+        ),
+      ),
+    );
+  };
 
-  constructor(props: DashboardTableProps) {
-    super(props);
-    this.state = {
-      dashboards: [],
-      dashboard_count: 0,
-      loading: false,
-    };
-  }
+  const getFilters = () => {
+    const filters = [];
 
-  componentDidUpdate(prevProps: DashboardTableProps) {
-    if (prevProps.search !== this.props.search) {
-      this.fetchDataDebounced({
-        pageSize: PAGE_SIZE,
-        pageIndex: 0,
-        sortBy: this.initialSort,
-        filters: [],
+    if (dashboardFilter === 'Mine') {
+      filters.push({
+        id: 'owners',
+        operator: 'rel_m_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'dashboard_is_fav',
+        value: true,
       });
     }
+    return filters;
+  };
+  const subMenus = [];
+  if (dashboards.length > 0 && dashboardFilter === 'favorite') {
+    subMenus.push({
+      name: 'Favorite',
+      label: t('Favorite'),
+      onClick: () => setDashboardFilter('Favorite'),
+    });
   }
 
-  fetchData = ({ pageIndex, pageSize, sortBy, filters }: FetchDataConfig) => {
-    this.setState({ loading: true });
-    const filterExps = Object.keys(filters)
-      .map(fk => ({
-        col: fk,
-        opr: filters[fk].filterId,
-        value: filters[fk].filterValue,
-      }))
-      .concat(
-        this.props.search
-          ? [
-              {
-                col: 'dashboard_title',
-                opr: 'ct',
-                value: this.props.search,
-              },
-            ]
-          : [],
-      );
-
-    const queryParams = JSON.stringify({
-      order_column: sortBy[0].id,
-      order_direction: sortBy[0].desc ? 'desc' : 'asc',
-      page: pageIndex,
-      page_size: pageSize,
-      ...(filterExps.length ? { filters: filterExps } : {}),
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
     });
+  }, [dashboardFilter]);
 
-    return SupersetClient.get({
-      endpoint: `/api/v1/dashboard/?q=${queryParams}`,
-    })
-      .then(({ json }) => {
-        this.setState({ dashboards: json.result, dashboard_count: json.count });
-      })
-      .catch(response => {
-        if (response.status === 401) {
-          this.props.addDangerToast(
-            t(
-              "You don't have the necessary permissions to load dashboards. Please contact your administrator.",
+  return (
+    <>
+      <SubMenu
+        activeChild={dashboardFilter}
+        name=""
+        // eslint-disable-next-line react/no-children-prop
+        children={[

Review comment:
       would it make sense to rename these to something other than "children" just to shut up the linter? Maybe "tabs"?

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  margin-top: 20px;
+  img {
+    width: 114px;
+    display: block;
+    margin: 0 auto;
+    margin-bottom: 15px;
+  }
+  div:nth-child(2) {
+    text-align: center;
+    margin-top: 15px;
+    color: ${({ theme }) => theme.colors.grayscale.dark1};
+    font-weight: 400;

Review comment:
       `typography.weights.normal` from theme

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  margin-top: 20px;
+  img {
+    width: 114px;
+    display: block;
+    margin: 0 auto;
+    margin-bottom: 15px;
+  }
+  div:nth-child(2) {
+    text-align: center;
+    margin-top: 15px;
+    color: ${({ theme }) => theme.colors.grayscale.dark1};
+    font-weight: 400;
+  }
+  button {
+    margin: 0 auto;
+    padding: 6px 27px;
+    margin-top: 10px;
+    svg {
+      color: white;
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const tableIcon = {
+    RECENTS: 'union.png',
+    DASHBOARDS: 'empty-dashboard.png',
+    CHARTS: 'empty-charts.png',
+    SAVED_QUERIES: 'empty-queries.png',
+  };
+  const mine = (
+    <div>
+      <div>{`No ${
+        tableName === 'SAVED_QUERIES'
+          ? 'saved queries'
+          : tableName.toLowerCase()
+      } yet`}</div>
+      <Button
+        buttonStyle="primary"
+        onClick={() => {
+          window.location = mineRedirects[tableName];

Review comment:
       Hmmm... is typescript letting this instance slide for some reason?

##########
File path: superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
##########
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t } from '@superset-ui/core';
+import { useListViewResource, useChartEditModal } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import PropertiesModal from 'src/explore/components/PropertiesModal';
+import { User } from 'src/types/bootstrapTypes';
+import Icon from 'src/components/Icon';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import Chart from 'src/types/Chart';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+import { CardContainer, IconContainer } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface ChartTableProps {
+  addDangerToast: (message: string) => void;
+  addSuccessToast: (message: string) => void;
+  search: string;
+  chartFilter?: string;
+  user?: User;
+}
+
+function ChartTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: ChartTableProps) {
+  const {
+    state: { loading, resourceCollection: charts, bulkSelectEnabled },
+    setResourceCollection: setCharts,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Chart>('chart', t('chart'), addDangerToast);
+
+  const {
+    sliceCurrentlyEditing,
+    openChartEditModal,
+    handleChartUpdated,
+    closeChartEditModal,
+  } = useChartEditModal(setCharts, charts);
+
+  const [chartFilter, setChartFilter] = useState('Favorite');
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (chartFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'chart_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [chartFilter]);
+
+  return (
+    <>
+      {sliceCurrentlyEditing && (
+        <PropertiesModal
+          onHide={closeChartEditModal}
+          onSave={handleChartUpdated}
+          show
+          slice={sliceCurrentlyEditing}
+        />
+      )}
+
+      <SubMenu
+        activeChild={chartFilter}
+        name=""
+        // eslint-disable-next-line react/no-children-prop
+        children={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setChartFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setChartFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> Chart{' '}

Review comment:
       NIT: not sure the `{' '}` is doing anything

##########
File path: superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
##########
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t } from '@superset-ui/core';
+import { useListViewResource, useChartEditModal } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import PropertiesModal from 'src/explore/components/PropertiesModal';
+import { User } from 'src/types/bootstrapTypes';
+import Icon from 'src/components/Icon';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import Chart from 'src/types/Chart';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+import { CardContainer, IconContainer } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface ChartTableProps {
+  addDangerToast: (message: string) => void;
+  addSuccessToast: (message: string) => void;
+  search: string;
+  chartFilter?: string;
+  user?: User;
+}
+
+function ChartTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: ChartTableProps) {
+  const {
+    state: { loading, resourceCollection: charts, bulkSelectEnabled },
+    setResourceCollection: setCharts,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Chart>('chart', t('chart'), addDangerToast);
+
+  const {
+    sliceCurrentlyEditing,
+    openChartEditModal,
+    handleChartUpdated,
+    closeChartEditModal,
+  } = useChartEditModal(setCharts, charts);
+
+  const [chartFilter, setChartFilter] = useState('Favorite');
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (chartFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'chart_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [chartFilter]);
+
+  return (
+    <>
+      {sliceCurrentlyEditing && (
+        <PropertiesModal
+          onHide={closeChartEditModal}
+          onSave={handleChartUpdated}
+          show
+          slice={sliceCurrentlyEditing}
+        />
+      )}
+
+      <SubMenu
+        activeChild={chartFilter}
+        name=""
+        // eslint-disable-next-line react/no-children-prop
+        children={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setChartFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setChartFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> Chart{' '}
+              </IconContainer>
+            ),
+            buttonStyle: 'tertiary',
+            onClick: () => {
+              // @ts-ignore
+              window.location = '/chart/add';

Review comment:
       If I'm not mistaken in other comments about using `window.location.href` working for this, we can nab this `ts-ignore` and the one below it, too.

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  margin-top: 20px;
+  img {
+    width: 114px;
+    display: block;
+    margin: 0 auto;
+    margin-bottom: 15px;
+  }
+  div:nth-child(2) {
+    text-align: center;
+    margin-top: 15px;
+    color: ${({ theme }) => theme.colors.grayscale.dark1};
+    font-weight: 400;
+  }
+  button {
+    margin: 0 auto;
+    padding: 6px 27px;
+    margin-top: 10px;
+    svg {
+      color: white;
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const tableIcon = {
+    RECENTS: 'union.png',
+    DASHBOARDS: 'empty-dashboard.png',
+    CHARTS: 'empty-charts.png',
+    SAVED_QUERIES: 'empty-queries.png',
+  };
+  const mine = (
+    <div>
+      <div>{`No ${
+        tableName === 'SAVED_QUERIES'
+          ? 'saved queries'
+          : tableName.toLowerCase()
+      } yet`}</div>
+      <Button
+        buttonStyle="primary"
+        onClick={() => {
+          window.location = mineRedirects[tableName];
+        }}
+      >
+        <IconContainer>
+          <Icon name="plus-small" />{' '}
+          {tableName === 'SAVED_QUERIES'
+            ? 'SQL QUERY'
+            : tableName
+                .split('')
+                .slice(0, tableName.length - 1)
+                .join('')}{' '}
+        </IconContainer>
+      </Button>
+    </div>
+  );
+  const span = (

Review comment:
       `span` might be a confusing name choice for this `div` - is there a more explicit/meaningful name?

##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -139,19 +139,39 @@ const SkeletonActions = styled(Skeleton.Button)`
   width: ${({ theme }) => theme.gridUnit * 10}px;
 `;
 
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid #e0e0e0;
+  .title {
+    font-weight: 500;
+    color: #b2b2b2;
+  }
+  .holder {
+    margin: 10px 10px 10px 10px;
+  }
+`;
+
 const paragraphConfig = { rows: 1, width: 150 };
 interface CardProps {
   title: React.ReactNode;
   url?: string;
   imgURL: string;
+  tables?: string | number;
   imgFallbackURL: string;
   imgPosition?: BackgroundPosition;
   description: string;
   loading: boolean;
   titleRight?: React.ReactNode;
   coverLeft?: React.ReactNode;
   coverRight?: React.ReactNode;
-  actions: React.ReactNode;
+  actions: React.ReactNode | null;
+  showImg?: boolean;
+  rows?: number | string;
+  avatar?: string;
+  isRecent?: boolean;
+  tableName?: string;
 }
 
 function ListViewCard({

Review comment:
       As per our call, it's probably worth doing the above, but it can be done in a followup PR.

##########
File path: superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
##########
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { t } from '@superset-ui/core';
+import { useListViewResource, useChartEditModal } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import PropertiesModal from 'src/explore/components/PropertiesModal';
+import { User } from 'src/types/bootstrapTypes';
+import Icon from 'src/components/Icon';
+import ChartCard from 'src/views/CRUD/chart/ChartCard';
+import Chart from 'src/types/Chart';
+import SubMenu from 'src/components/Menu/SubMenu';
+import EmptyState from './EmptyState';
+import { CardContainer, IconContainer } from '../utils';
+
+const PAGE_SIZE = 3;
+
+interface ChartTableProps {
+  addDangerToast: (message: string) => void;
+  addSuccessToast: (message: string) => void;
+  search: string;
+  chartFilter?: string;
+  user?: User;
+}
+
+function ChartTable({
+  user,
+  addDangerToast,
+  addSuccessToast,
+}: ChartTableProps) {
+  const {
+    state: { loading, resourceCollection: charts, bulkSelectEnabled },
+    setResourceCollection: setCharts,
+    hasPerm,
+    refreshData,
+    fetchData,
+  } = useListViewResource<Chart>('chart', t('chart'), addDangerToast);
+
+  const {
+    sliceCurrentlyEditing,
+    openChartEditModal,
+    handleChartUpdated,
+    closeChartEditModal,
+  } = useChartEditModal(setCharts, charts);
+
+  const [chartFilter, setChartFilter] = useState('Favorite');
+
+  const getFilters = () => {
+    const filters = [];
+
+    if (chartFilter === 'Mine') {
+      filters.push({
+        id: 'created_by',
+        operator: 'rel_o_m',
+        value: `${user?.userId}`,
+      });
+    } else {
+      filters.push({
+        id: 'id',
+        operator: 'chart_is_fav',
+        value: true,
+      });
+    }
+    return filters;
+  };
+
+  useEffect(() => {
+    fetchData({
+      pageIndex: 0,
+      pageSize: PAGE_SIZE,
+      sortBy: [
+        {
+          id: 'changed_on_delta_humanized',
+          desc: true,
+        },
+      ],
+      filters: getFilters(),
+    });
+  }, [chartFilter]);
+
+  return (
+    <>
+      {sliceCurrentlyEditing && (
+        <PropertiesModal
+          onHide={closeChartEditModal}
+          onSave={handleChartUpdated}
+          show
+          slice={sliceCurrentlyEditing}
+        />
+      )}
+
+      <SubMenu
+        activeChild={chartFilter}
+        name=""
+        // eslint-disable-next-line react/no-children-prop
+        children={[
+          {
+            name: 'Favorite',
+            label: t('Favorite'),
+            onClick: () => setChartFilter('Favorite'),
+          },
+          {
+            name: 'Mine',
+            label: t('Mine'),
+            onClick: () => setChartFilter('Mine'),
+          },
+        ]}
+        buttons={[
+          {
+            name: (
+              <IconContainer>
+                <Icon name="plus-small" /> Chart{' '}
+              </IconContainer>
+            ),
+            buttonStyle: 'tertiary',
+            onClick: () => {
+              // @ts-ignore
+              window.location = '/chart/add';
+            },
+          },
+          {
+            name: 'View All »',
+            buttonStyle: 'link',
+            onClick: () => {
+              // @ts-ignore
+              window.location = '/chart/list';
+            },
+          },
+        ]}
+      />
+      {charts.length ? (
+        <CardContainer>
+          {charts.map((e, i) => (
+            <ChartCard
+              key={`${i}`}

Review comment:
       Would be good to avoid using the index here, and use something unique... maybe`chart` has a `chart.id` or something useful?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.39%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.25%   -5.40%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26000   -15048     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15926   -11433     
   + Misses      13592    10074    -3518     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.25% <100.00%> (-0.71%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | ... and [440 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...8924264](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.63%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   65.43%   60.79%   -4.64%     
   ==========================================
     Files         829      392     -437     
     Lines       39200    24555   -14645     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        25649    14928   -10721     
   + Misses      13444     9627    -3817     
   + Partials      107        0     -107     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.79% <100.00%> (+0.18%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `74.56% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.86% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | ... and [439 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [9785667...f190768](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.34%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.30%   -5.35%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26052   -14996     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15972   -11387     
   + Misses      13592    10080    -3512     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.30% <100.00%> (-0.66%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <0.00%> (-2.76%)` | :arrow_down: |
   | ... and [451 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/917d02efbd80ef490f121ffb8e2211e919311596?el=desc) will **decrease** coverage by `5.10%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   65.67%   60.56%   -5.11%     
   ==========================================
     Files         835      394     -441     
     Lines       39656    24935   -14721     
     Branches     3604        0    -3604     
   ==========================================
   - Hits        26045    15103   -10942     
   + Misses      13502     9832    -3670     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.56% <100.00%> (-0.35%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `74.56% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.86% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <100.00%> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | ... and [443 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [917d02e...641f5c5](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.65%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.91%   -4.66%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    16074   -11136     
   + Misses      13566     9887    -3679     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.91% <ø> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `92.10% <0.00%> (-2.49%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `98.83% <0.00%> (-1.17%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `81.77% <0.00%> (-0.43%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (-0.12%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <0.00%> (ø)` | |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <0.00%> (ø)` | |
   | ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...d97dd73](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.75%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.85%   -4.76%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26078   -15137     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16131   -11323     
   + Misses      13660     9947    -3713     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.85% <100.00%> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <0.00%> (ø)` | |
   | [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r512363132



##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -139,19 +139,39 @@ const SkeletonActions = styled(Skeleton.Button)`
   width: ${({ theme }) => theme.gridUnit * 10}px;
 `;
 
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+  .title {
+    font-weight: ${({ theme }) => theme.typography.weights.normal};
+    color: ${({ theme }) => theme.colors.grayscale.light2};
+  }
+  .holder {
+    margin: ${({ theme }) => theme.gridUnit * 2}px;
+  }
+`;
+
 const paragraphConfig = { rows: 1, width: 150 };
 interface CardProps {
   title: React.ReactNode;
   url?: string;
-  imgURL: string;
-  imgFallbackURL: string;
+  imgURL?: string;
+  tables?: string | number;
+  imgFallbackURL?: string;
   imgPosition?: BackgroundPosition;
   description: string;
   loading: boolean;
   titleRight?: React.ReactNode;
   coverLeft?: React.ReactNode;
   coverRight?: React.ReactNode;
-  actions: React.ReactNode;
+  actions: React.ReactNode | null;
+  showImg?: boolean;
+  rows?: number | string;
+  avatar?: string;

Review comment:
       nit: this should be `IconName` or `IconProps["name"]`.

##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -162,35 +182,54 @@ function ListViewCard({
   imgFallbackURL,
   description,
   coverLeft,
+  tables,
   coverRight,
   actions,
+  avatar,
+  tableName,
   loading,
   imgPosition = 'top',
+  showImg = true,
+  isRecent,
 }: CardProps) {
   return (
     <StyledCard
       data-test="styled-card"
       cover={
-        <Cover>
-          <a href={url}>
-            <div className="gradient-container">
-              <ImageLoader
-                src={imgURL}
-                fallback={imgFallbackURL}
-                isLoading={loading}
-                position={imgPosition}
-              />
+        !isRecent &&
+        (showImg ? (
+          <Cover>
+            <a href={url}>
+              <div className="gradient-container">
+                <ImageLoader
+                  src={imgURL || ''}
+                  fallback={imgFallbackURL || ''}
+                  isLoading={loading}
+                  position={imgPosition}
+                />
+              </div>
+            </a>
+            <CoverFooter className="cover-footer">
+              {!loading && coverLeft && (
+                <CoverFooterLeft>{coverLeft}</CoverFooterLeft>
+              )}
+              {!loading && coverRight && (
+                <CoverFooterRight>{coverRight}</CoverFooterRight>
+              )}
+            </CoverFooter>
+          </Cover>
+        ) : (
+          <QueryData>

Review comment:
       This seems highly coupled to the Query card implementation. Can we move this up into the parent and instead have a `renderCover` that renders the cover slot, or `cover` prop for this jsx. 
   
   We could also probably get rid of the `isRecent` and `showImg` props and instead check the presence of this prop. 

##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,124 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { Empty } from 'src/common/components';
+import { t, styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const ButtonContainer = styled.div`
+  Button {
+    svg {
+      color: ${({ theme }) => theme.colors.grayscale.light5};
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const tableIcon = {
+    RECENTS: 'union.png',
+    DASHBOARDS: 'empty-dashboard.png',
+    CHARTS: 'empty-charts.png',
+    SAVED_QUERIES: 'empty-queries.png',
+  };
+  const mine = (
+    <div>{`No ${
+      tableName === 'SAVED_QUERIES'
+        ? t('saved queries')
+        : t(`${tableName.toLowerCase()}`)
+    } yet`}</div>
+  );
+  const recent = (
+    <div className="no-recents">
+      {t(
+        `Recently ${tab?.toLowerCase()} charts, dashboards, and saved queries will appear here`,

Review comment:
       I don't think translations work like this. Not all languages follow the same grammar as english. You could use string interpolation eg `t('Recently %s charts...', tab.toLowerCase())` so that the %s can be moved around to where it makes the most sense but then `tab` wouldn't be translated. The correct solution is probably to list out the variations.  

##########
File path: superset-frontend/src/views/CRUD/hooks.ts
##########
@@ -348,5 +355,87 @@ export function useFavoriteStatus(
     );
   };
 
-  return [favoriteStatusRef, fetchFaveStar, saveFaveStar] as const;
+  return [
+    favoriteStatusRef,
+    fetchFaveStar,
+    saveFaveStar,
+    favoriteStatus,
+  ] as const;
 }
+
+export const useChartEditModal = (
+  setCharts: (charts: Array<Chart>) => void,
+  charts: Array<Chart>,
+) => {
+  const [
+    sliceCurrentlyEditing,
+    setSliceCurrentlyEditing,
+  ] = useState<Slice | null>(null);
+
+  function openChartEditModal(chart: Chart) {
+    setSliceCurrentlyEditing({
+      slice_id: chart.id,
+      slice_name: chart.slice_name,
+      description: chart.description,
+      cache_timeout: chart.cache_timeout,
+    });
+  }
+
+  function closeChartEditModal() {
+    setSliceCurrentlyEditing(null);
+  }
+
+  function handleChartUpdated(edits: Chart) {
+    // update the chart in our state with the edited info
+    const newCharts = charts.map((chart: Chart) =>
+      chart.id === edits.id ? { ...chart, ...edits } : chart,
+    );
+    setCharts(newCharts);
+  }
+
+  return {
+    sliceCurrentlyEditing,
+    handleChartUpdated,
+    openChartEditModal,
+    closeChartEditModal,
+  };
+};
+
+export const copyQueryLink = (

Review comment:
       👍 we should only have 1 copy to clipboard util function

##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -162,35 +182,54 @@ function ListViewCard({
   imgFallbackURL,
   description,
   coverLeft,
+  tables,
   coverRight,
   actions,
+  avatar,
+  tableName,
   loading,
   imgPosition = 'top',
+  showImg = true,
+  isRecent,

Review comment:
       Is this prop doing anything else besides showing/hiding the cover image (along with the showImg prop)? 

##########
File path: superset-frontend/src/views/CRUD/hooks.ts
##########
@@ -348,5 +349,87 @@ export function useFavoriteStatus(
     );
   };
 
-  return [favoriteStatusRef, fetchFaveStar, saveFaveStar] as const;
+  return [
+    favoriteStatusRef,
+    fetchFaveStar,
+    saveFaveStar,
+    favoriteStatus,

Review comment:
       There's an issue with exposing this state, due to closures some functions end up with a stale ref to this state. We expose the favoriteStatusRef for this reason, it's always pointing to the latest version of favoriteStatus object. Is there a reason we're exposing this instead of using `favoriteStatusRef.current` as we do elsewhere? 

##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -162,35 +182,54 @@ function ListViewCard({
   imgFallbackURL,
   description,
   coverLeft,
+  tables,
   coverRight,
   actions,
+  avatar,
+  tableName,
   loading,
   imgPosition = 'top',
+  showImg = true,
+  isRecent,
 }: CardProps) {
   return (
     <StyledCard
       data-test="styled-card"
       cover={
-        <Cover>
-          <a href={url}>
-            <div className="gradient-container">
-              <ImageLoader
-                src={imgURL}
-                fallback={imgFallbackURL}
-                isLoading={loading}
-                position={imgPosition}
-              />
+        !isRecent &&
+        (showImg ? (
+          <Cover>
+            <a href={url}>
+              <div className="gradient-container">
+                <ImageLoader
+                  src={imgURL || ''}
+                  fallback={imgFallbackURL || ''}
+                  isLoading={loading}
+                  position={imgPosition}
+                />
+              </div>
+            </a>
+            <CoverFooter className="cover-footer">
+              {!loading && coverLeft && (
+                <CoverFooterLeft>{coverLeft}</CoverFooterLeft>
+              )}
+              {!loading && coverRight && (
+                <CoverFooterRight>{coverRight}</CoverFooterRight>
+              )}
+            </CoverFooter>
+          </Cover>
+        ) : (
+          <QueryData>
+            <div className="holder">
+              <div className="title">Tables</div>

Review comment:
       ```suggestion
                 <div className="title">{t('Tables')}</div>
   ```

##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -418,83 +417,18 @@ function DashboardList(props: DashboardListProps) {
     },
   ];
 
-  function renderCard(dashboard: Dashboard & { loading: boolean }) {
-    const menu = (
-      <Menu>
-        {canDelete && (
-          <Menu.Item>
-            <ConfirmStatusChange
-              title={t('Please Confirm')}
-              description={
-                <>
-                  {t('Are you sure you want to delete')}{' '}
-                  <b>{dashboard.dashboard_title}</b>?
-                </>
-              }
-              onConfirm={() => handleDashboardDelete(dashboard)}
-            >
-              {confirmDelete => (
-                <div
-                  role="button"
-                  tabIndex={0}
-                  className="action-button"
-                  onClick={confirmDelete}
-                >
-                  <ListViewCard.MenuIcon
-                    data-test="dashboard-list-view-card-trash-icon"
-                    name="trash"
-                  />{' '}
-                  Delete
-                </div>
-              )}
-            </ConfirmStatusChange>
-          </Menu.Item>
-        )}
-        {canExport && (
-          <Menu.Item
-            role="button"
-            tabIndex={0}
-            onClick={() => handleBulkDashboardExport([dashboard])}
-          >
-            <ListViewCard.MenuIcon name="share" /> Export
-          </Menu.Item>
-        )}
-        {canEdit && (
-          <Menu.Item
-            data-test="dashboard-list-edit-option"
-            role="button"
-            tabIndex={0}
-            onClick={() => openDashboardEditModal(dashboard)}
-          >
-            <ListViewCard.MenuIcon name="edit-alt" /> Edit
-          </Menu.Item>
-        )}
-      </Menu>
-    );
-
+  function renderCard(dashboard: Dashboard) {
     return (
-      <ListViewCard
-        loading={dashboard.loading}
-        title={dashboard.dashboard_title}
-        titleRight={
-          <Label>{dashboard.published ? 'published' : 'draft'}</Label>
-        }
-        url={bulkSelectEnabled ? undefined : dashboard.url}
-        imgURL={dashboard.thumbnail_url}
-        imgFallbackURL="/static/assets/images/dashboard-card-fallback.png"
-        description={t(
-          'Last modified %s',
-          dashboard.changed_on_delta_humanized,
-        )}
-        coverLeft={<FacePile users={dashboard.owners || []} />}
-        actions={
-          <ListViewCard.Actions>
-            {renderFaveStar(dashboard.id)}
-            <Dropdown overlay={menu}>
-              <Icon name="more-horiz" />
-            </Dropdown>
-          </ListViewCard.Actions>
-        }
+      <DashboardCard
+        {...{

Review comment:
       nit: is there a reason to spread these instead of just listing out the props? 

##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -162,35 +182,54 @@ function ListViewCard({
   imgFallbackURL,
   description,
   coverLeft,
+  tables,
   coverRight,
   actions,
+  avatar,
+  tableName,
   loading,
   imgPosition = 'top',
+  showImg = true,
+  isRecent,
 }: CardProps) {
   return (
     <StyledCard
       data-test="styled-card"
       cover={
-        <Cover>
-          <a href={url}>
-            <div className="gradient-container">
-              <ImageLoader
-                src={imgURL}
-                fallback={imgFallbackURL}
-                isLoading={loading}
-                position={imgPosition}
-              />
+        !isRecent &&
+        (showImg ? (
+          <Cover>
+            <a href={url}>
+              <div className="gradient-container">
+                <ImageLoader
+                  src={imgURL || ''}
+                  fallback={imgFallbackURL || ''}
+                  isLoading={loading}
+                  position={imgPosition}
+                />
+              </div>
+            </a>
+            <CoverFooter className="cover-footer">
+              {!loading && coverLeft && (
+                <CoverFooterLeft>{coverLeft}</CoverFooterLeft>
+              )}
+              {!loading && coverRight && (
+                <CoverFooterRight>{coverRight}</CoverFooterRight>
+              )}
+            </CoverFooter>
+          </Cover>
+        ) : (
+          <QueryData>
+            <div className="holder">
+              <div className="title">Tables</div>
+              <div>{tables}</div>
+            </div>
+            <div className="holder">
+              <div className="title">Datasource Name</div>

Review comment:
       ```suggestion
                 <div className="title">{t('Datasource Name')}</div>
   ```

##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx
##########
@@ -0,0 +1,159 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { SupersetClient, t } from '@superset-ui/core';
+import rison from 'rison';
+import { Dropdown, Menu } from 'src/common/components';
+import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
+import ListViewCard from 'src/components/ListViewCard';
+import Icon from 'src/components/Icon';
+import Label from 'src/components/Label';
+import FacePile from 'src/components/FacePile';
+import FaveStar from 'src/components/FaveStar';
+import { DashboardCardProps, Dashboard } from 'src/views/CRUD/types';
+import { createErrorHandler } from 'src/views/CRUD/utils';
+import { useFavoriteStatus } from 'src/views/CRUD/hooks';
+
+const FAVESTAR_BASE_URL = '/superset/favstar/Dashboard';
+
+function DashboardCard({
+  isChart,

Review comment:
       What does this prop do? It doesn't look like it's actually being passed in anywhere

##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -53,6 +54,98 @@ const createFetchResourceMethod = (method: string) => (
   return [];
 };
 
+export const getRecentAcitivtyObjs = (
+  userId: string | number,
+  recent: string,
+) => {
+  const getParams = (filters?: Array<any>) => {
+    const params = {
+      order_column: 'changed_on_delta_humanized',

Review comment:
       should this be `changed_on`? 

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import moment from 'antd/node_modules/moment';
+import { styled, t } from '@superset-ui/core';
+
+import ListViewCard from 'src/components/ListViewCard';
+import { addDangerToast } from 'src/messageToasts/actions';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { reject } from 'lodash';
+import { getRecentAcitivtyObjs, mq } from '../utils';
+import EmptyState from './EmptyState';
+
+interface MapProps {

Review comment:
       nit: `ActivityProps` or `ActivityObjectProps` seems more descriptive. My mind went to a map 🗺️ when I saw this. 

##########
File path: superset-frontend/src/views/CRUD/chart/ChartCard.tsx
##########
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { useFavoriteStatus } from 'src/views/CRUD/hooks';
+import { SupersetClient, t } from '@superset-ui/core';
+import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
+import Icon from 'src/components/Icon';
+import Chart from 'src/types/Chart';
+
+import ListViewCard from 'src/components/ListViewCard';
+import Label from 'src/components/Label';
+import { Dropdown, Menu } from 'src/common/components';
+import FaveStar from 'src/components/FaveStar';
+import FacePile from 'src/components/FacePile';
+
+const FAVESTAR_BASE_URL = '/superset/favstar/slice';
+
+interface ChartCardProps {
+  chart: Chart;
+  hasPerm: (perm: string) => boolean;
+  openChartEditModal: (chart: Chart) => void;
+  bulkSelectEnabled: boolean;
+  addDangerToast: (msg: string) => void;
+  addSuccessToast: (msg: string) => void;
+  refreshData: () => void;
+  loading: boolean;
+}
+
+export default function ChartCard({
+  chart,
+  hasPerm,
+  openChartEditModal,
+  bulkSelectEnabled,
+  addDangerToast,
+  addSuccessToast,
+  refreshData,
+  loading,
+}: ChartCardProps) {
+  const canEdit = hasPerm('can_edit');
+  const canDelete = hasPerm('can_delete');
+  const [, fetchFaveStar, saveFaveStar, favoriteStatus] = useFavoriteStatus(
+    {},
+    FAVESTAR_BASE_URL,
+    addDangerToast,
+  );
+  function handleChartDelete({ id, slice_name: sliceName }: Chart) {
+    SupersetClient.delete({
+      endpoint: `/api/v1/chart/${id}`,
+    }).then(
+      () => {
+        refreshData();
+        addSuccessToast(t('Deleted: %s', sliceName));
+      },
+      () => {
+        addDangerToast(t('There was an issue deleting: %s', sliceName));
+      },
+    );
+  }

Review comment:
       I'm not sure it makes the most sense to move all this logic down into these card components. It does make these components more standalone, however the logic will be duplicated in the case of the DashboardList and ChartList components. There will be 2 instances of the `useFaveStar` hook mounted. Also why is `openChartEditModal` passed in as a prop, yet `handleChartDelete` is implemented here? 
   
   If we're trying to dry up these actions between the home screen and the (Chart|Dashboard)List we could probably achieve this by moving them into a shared utils module, eg.
   
   `export const createChartDeleteFunction = (handleSuccess, handleError) => ({id, slice_name....`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.30%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   61.26%   -5.31%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25961   -14913     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15906   -11304     
   + Misses      13566    10055    -3511     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.26% <ø> (-0.68%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-3.49%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `92.10% <0.00%> (-2.49%)` | :arrow_down: |
   | ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...11b387a](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r512431433



##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx
##########
@@ -0,0 +1,159 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { SupersetClient, t } from '@superset-ui/core';
+import rison from 'rison';
+import { Dropdown, Menu } from 'src/common/components';
+import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
+import ListViewCard from 'src/components/ListViewCard';
+import Icon from 'src/components/Icon';
+import Label from 'src/components/Label';
+import FacePile from 'src/components/FacePile';
+import FaveStar from 'src/components/FaveStar';
+import { DashboardCardProps, Dashboard } from 'src/views/CRUD/types';
+import { createErrorHandler } from 'src/views/CRUD/utils';
+import { useFavoriteStatus } from 'src/views/CRUD/hooks';
+
+const FAVESTAR_BASE_URL = '/superset/favstar/Dashboard';
+
+function DashboardCard({
+  isChart,

Review comment:
       Looks like on like 81, this prop may have been used so the card could share code between charts/dashboards. If you're right, then perhaps that line and and the `cardTitle` variable aren't needed anymore either. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `4.43%`.
   > The diff coverage is `59.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   62.13%   -4.44%     
   ==========================================
     Files         860      867       +7     
     Lines       40874    41276     +402     
     Branches     3694     3774      +80     
   ==========================================
   - Hits        27210    25645    -1565     
   - Misses      13566    15450    +1884     
   - Partials       98      181      +83     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.70% <59.61%> (-0.27%)` | :arrow_down: |
   | #python | `61.79% <ø> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.34% <21.62%> (-22.31%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `67.24% <48.57%> (-32.76%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | ... and [219 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...e12c2b9](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r509788611



##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import Button from 'src/components/Button';
+import { styled } from '@superset-ui/core';
+import Icon from 'src/components/Icon';
+import { IconContainer } from '../utils';
+
+interface EmptyStateProps {
+  tableName: string;
+  tab?: string;
+}
+
+const Container = styled.div`
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  img {
+    width: 114px;
+    display: block;
+    margin: 0 auto;
+  }
+  div:nth-child(2) {
+    text-align: center;
+    margin-top: 15px;
+    color: ${({ theme }) => theme.colors.grayscale.dark1};
+    font-weight: 400;
+  }
+  button {
+    margin: 0 auto;
+    padding: 6px 27px;
+    margin-top: 10px;
+    svg {
+      color: white;
+    }
+  }
+`;
+
+export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+  const mineRedirects = {
+    DASHBOARDS: '/dashboard/new',
+    CHARTS: '/chart/add',
+    SAVED_QUERIES: '/superset/sqllab',
+  };
+  const favRedirects = {
+    DASHBOARDS: '/dashboard/list/',
+    CHARTS: '/chart/list',
+    SAVED_QUERIES: '/savedqueryview/list/',
+  };
+  const Mine = (
+    <div>
+      <div>{`No ${tableName.toLowerCase()} yet`}</div>
+      <Button
+        buttonStyle="primary"
+        onClick={() => {
+          window.location = mineRedirects[tableName];
+        }}
+      >
+        <IconContainer>
+          <Icon name="plus-small" />{' '}
+          {tableName === 'SAVED_QUERIES'
+            ? 'SQL LAB QUERY'
+            : tableName
+                .split('')
+                .slice(0, tableName.length - 1)
+                .join('')}{' '}
+        </IconContainer>
+      </Button>
+    </div>
+  );
+  const span = (
+    <div className="no-recents">
+      Recently viewed charts, dashboards, and saved queries will appear here
+    </div>
+  );
+
+  if (tab === 'Mine') {
+    return (
+      <Container>
+        <img src="/static/assets/images/union.png" alt="union.png" />

Review comment:
       Yes REUSE! I'll change over to <Empty>!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-717574041


   FYI, @riahk also created an empty list state in https://github.com/apache/incubator-superset/pull/11432 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.66%`.
   > The diff coverage is `79.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   60.98%   -5.67%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26052   -14996     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15888   -11471     
   + Misses      13592    10164    -3428     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.98% <79.41%> (-0.98%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.86% <ø> (-0.49%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <50.00%> (-2.76%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.27% <100.00%> (-0.15%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.15% <100.00%> (+0.15%)` | :arrow_up: |
   | ... and [431 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `4.55%`.
   > The diff coverage is `63.83%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   62.09%   -4.56%     
   ==========================================
     Files         863      868       +5     
     Lines       41048    41559     +511     
     Branches     3693     3792      +99     
   ==========================================
   - Hits        27359    25806    -1553     
   - Misses      13592    15574    +1982     
   - Partials       97      179      +82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.55% <62.48%> (-0.38%)` | :arrow_down: |
   | #python | `61.82% <79.41%> (-0.14%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `49.17% <ø> (-29.29%)` | :arrow_down: |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `62.22% <ø> (-6.67%)` | :arrow_down: |
   | [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `25.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `50.00% <0.00%> (ø)` | |
   | [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `0.00% <ø> (ø)` | |
   | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `66.32% <0.00%> (-17.35%)` | :arrow_down: |
   | [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `88.00% <ø> (-10.08%)` | :arrow_down: |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-75.30%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.30% <ø> (-0.55%)` | :arrow_down: |
   | ... and [249 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r510306117



##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -53,6 +54,84 @@ const createFetchResourceMethod = (method: string) => (
   return [];
 };
 
+export const getBatchData = (userId: string | number, recent: string) => {

Review comment:
       Does this get recent objects? If so, how about `getRecentActivityObjects`? How are we thinking about "recently viewed?"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.66%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   60.98%   -5.67%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26052   -14996     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15888   -11471     
   + Misses      13592    10164    -3428     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.98% <100.00%> (-0.98%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [463 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...df56336](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.28%`.
   > The diff coverage is `79.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.36%   -5.29%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26052   -14996     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15988   -11371     
   + Misses      13592    10064    -3528     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.36% <79.41%> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.35% <ø> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <50.00%> (-2.76%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.87% <100.00%> (+0.45%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.15% <100.00%> (+0.15%)` | :arrow_up: |
   | ... and [416 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] pkdotson commented on a change in pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r510459568



##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -63,3 +142,39 @@ export function createErrorHandler(handleErrorFunc: (errMsg?: string) => void) {
     handleErrorFunc(parsedError.message || parsedError.error);
   };
 }
+
+export function handleDashboardDelete(id: string) {
+  return SupersetClient.delete({
+    endpoint: `/api/v1/dashboard/${id}`,
+  });
+}
+
+const breakpoints = [576, 768, 992, 1200];
+export const mq = breakpoints.map(bp => `@media (max-width: ${bp}px)`);
+
+export const CardContainer = styled.div`
+  display: grid;
+  grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  ${[mq[3]]} {
+    grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
+  }
+
+  ${[mq[2]]} {
+    grid-template-columns: repeat(auto-fit, minmax(48%, max-content));
+  }
+
+  ${[mq[1]]} {
+    grid-template-columns: repeat(auto-fit, minmax(50%, max-content));
+  }
+  grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
+  justify-content: left;
+  padding: ${({ theme }) => theme.gridUnit * 2}px
+    ${({ theme }) => theme.gridUnit * 6}px;
+`;
+
+export const IconContainer = styled.div`
+  svg {
+    vertical-align: -7px;
+    color: ${({ theme }) => theme.colors.primary.dark1};

Review comment:
       The icon defaults to the whatever the button color is. I think that makes sense to follow up on this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f14cf9d6dc742be1a1d676db6ab9f5b39d6a2d28?el=desc) will **decrease** coverage by `0.65%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   61.57%   60.92%   -0.66%     
   ==========================================
     Files         838      415     -423     
     Lines       39839    25852   -13987     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        24532    15750    -8782     
   + Misses      15126    10102    -5024     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.92% <100.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (+2.42%)` | :arrow_up: |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (+2.00%)` | :arrow_up: |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [489 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [f14cf9d...ba1ebd7](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.37%`.
   > The diff coverage is `59.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   62.23%   -4.38%     
   ==========================================
     Files         862      869       +7     
     Lines       41215    41582     +367     
     Branches     3719     3797      +78     
   ==========================================
   - Hits        27454    25878    -1576     
   - Misses      13660    15525    +1865     
   - Partials      101      179      +78     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.57% <59.71%> (-0.13%)` | :arrow_down: |
   | #python | `62.03% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `61.83% <ø> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `56.69% <21.62%> (-22.20%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `47.56% <28.81%> (-52.44%)` | :arrow_down: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `40.84% <40.84%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `60.00% <52.94%> (-16.00%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `60.37% <58.82%> (-18.58%)` | :arrow_down: |
   | ... and [205 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...3af819d](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `5.22%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.61%   61.38%   -5.23%     
   ==========================================
     Files         862      418     -444     
     Lines       41215    26078   -15137     
     Branches     3719        0    -3719     
   ==========================================
   - Hits        27454    16009   -11445     
   + Misses      13660    10069    -3591     
   + Partials      101        0     -101     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.38% <100.00%> (-0.62%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | ... and [441 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [ed3dca4...09ff645](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-718282308


   something looks a little off here .... 4k changes and 119 files changed 🤔 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52294c836abe2b8ec89c76fefea54154037c14aa?el=desc) will **decrease** coverage by `5.35%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.65%   61.29%   -5.36%     
   ==========================================
     Files         863      417     -446     
     Lines       41048    26063   -14985     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27359    15975   -11384     
   + Misses      13592    10088    -3504     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.29% <100.00%> (-0.67%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.19% <0.00%> (-2.76%)` | :arrow_down: |
   | ... and [447 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [52294c8...06781ab](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f14cf9d6dc742be1a1d676db6ab9f5b39d6a2d28?el=desc) will **increase** coverage by `0.35%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   + Coverage   61.57%   61.93%   +0.35%     
   ==========================================
     Files         838      415     -423     
     Lines       39839    25863   -13976     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        24532    16017    -8515     
   + Misses      15126     9846    -5280     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.93% <100.00%> (+0.98%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (+2.42%)` | :arrow_up: |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (+2.00%)` | :arrow_up: |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <100.00%> (ø)` | |
   | [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `89.65% <0.00%> (-2.94%)` | :arrow_down: |
   | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `75.48% <0.00%> (-0.99%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.42% <0.00%> (-0.65%)` | :arrow_down: |
   | [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `89.65% <0.00%> (-0.35%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <0.00%> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.47% <0.00%> (ø)` | |
   | ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [f14cf9d...ba1ebd7](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11206: feat: home screen mvp

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-705847243


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=h1) Report
   > Merging [#11206](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0ab15373fae651bbb6854b40e9c252e38812b444?el=desc) will **decrease** coverage by `5.67%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11206/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11206      +/-   ##
   ==========================================
   - Coverage   66.57%   60.89%   -5.68%     
   ==========================================
     Files         860      417     -443     
     Lines       40874    25950   -14924     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27210    15803   -11407     
   + Misses      13566    10147    -3419     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.89% <ø> (-1.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
   | [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `82.87% <ø> (ø)` | |
   | [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <ø> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [466 more](https://codecov.io/gh/apache/incubator-superset/pull/11206/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=footer). Last update [0ab1537...11b387a](https://codecov.io/gh/apache/incubator-superset/pull/11206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org