You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ashb (via GitHub)" <gi...@apache.org> on 2024/10/10 12:10:02 UTC
[PR] Upgrade dependencies to allow us to use SQLAlchemy v2 in Airflow 3.0/main [airflow]
ashb opened a new pull request, #42898:
URL: https://github.com/apache/airflow/pull/42898
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade dependencies to allow us to use SQLAlchemy v2 in Airflow 3.0/main [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #42898:
URL: https://github.com/apache/airflow/pull/42898#discussion_r1795384958
##########
generated/provider_dependencies.json:
##########
@@ -38,7 +38,6 @@
"jsonpath_ng>=1.5.3",
"python3-saml>=1.16.0",
"redshift_connector>=2.0.918",
- "sqlalchemy_redshift>=0.8.6",
Review Comment:
I tried to remove it in #42830 but it seems some tests failed (but after the merge, which was really weird). We reverted it then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade dependencies to allow us to use SQLAlchemy v2 in Airflow 3.0/main [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #42898:
URL: https://github.com/apache/airflow/pull/42898#discussion_r1796870272
##########
providers/src/airflow/providers/fab/auth_manager/models/__init__.py:
##########
@@ -58,12 +58,25 @@
"""
metadata = MetaData(schema=_get_schema(), naming_convention=naming_convention)
-mapper_registry = registry(metadata=metadata)
if packaging.version.parse(packaging.version.parse(airflow_version).base_version) >= packaging.version.parse(
"3.0.0"
):
+
+ class Model(DeclarativeBase):
+ """
+ Base class to ease transition to SQLAv2.
+
+ :meta private:
+ """
+
+ metadata = metadata
+ # https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#migration-20-step-six
+ __allow_unmapped__ = True
+
Model.metadata = metadata
+
+ flask_appbuilder.models.sqla.Model = Model
Review Comment:
This is almost certainly horribly horribly wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade dependencies to allow us to use SQLAlchemy v2 in Airflow 3.0/main [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #42898:
URL: https://github.com/apache/airflow/pull/42898#issuecomment-2404919806
This failed before once landed in main https://github.com/apache/airflow/pull/42898 -- but lets try again/more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade dependencies to allow us to use SQLAlchemy v2 in Airflow 3.0/main [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #42898:
URL: https://github.com/apache/airflow/pull/42898#discussion_r1795395120
##########
generated/provider_dependencies.json:
##########
@@ -38,7 +38,6 @@
"jsonpath_ng>=1.5.3",
"python3-saml>=1.16.0",
"redshift_connector>=2.0.918",
- "sqlalchemy_redshift>=0.8.6",
Review Comment:
Cool :D Godspeed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade dependencies to allow us to use SQLAlchemy v2 in Airflow 3.0/main [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb closed pull request #42898: Upgrade dependencies to allow us to use SQLAlchemy v2 in Airflow 3.0/main
URL: https://github.com/apache/airflow/pull/42898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade dependencies to allow us to use SQLAlchemy v2 in Airflow 3.0/main [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #42898:
URL: https://github.com/apache/airflow/pull/42898#issuecomment-2406944059
How do I get it up update the constrains files using the version in this PR, not the released version of the FAB provider?
> And because apache-airflow==3.0.0.dev0 depends on sqlalchemy>=2.0,<3.0 and apache-airflow-providers-fab>=1.0.2, we can conclude that apache-airflow==3.0.0.dev0 cannot be used.
> And because only apache-airflow[all-core]==3.0.0.dev0 is available and you require apache-airflow[all-core], we can conclude that your requirements are unsatisfiable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade dependencies to allow us to use SQLAlchemy v2 in Airflow 3.0/main [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #42898:
URL: https://github.com/apache/airflow/pull/42898#issuecomment-2408620867
Too much in this PR, trying smaller in #42963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade dependencies to allow us to use SQLAlchemy v2 in Airflow 3.0/main [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #42898:
URL: https://github.com/apache/airflow/pull/42898#discussion_r1795388871
##########
generated/provider_dependencies.json:
##########
@@ -38,7 +38,6 @@
"jsonpath_ng>=1.5.3",
"python3-saml>=1.16.0",
"redshift_connector>=2.0.918",
- "sqlalchemy_redshift>=0.8.6",
Review Comment:
Yeah I was aware and going to try poking at it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org