You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "bvolpato (via GitHub)" <gi...@apache.org> on 2023/11/16 04:10:32 UTC

[PR] Add Maven archetype for examples with Dataflow Runner only [beam]

bvolpato opened a new pull request, #29447:
URL: https://github.com/apache/beam/pull/29447

   Generates POM following https://beam.apache.org/blog/managing-beam-dependencies-in-java/
   
   This will allow more runner-specific project so profiles don't have to be used. It allows a user to get started on Dataflow with 2 commands:
   
   ```
   mvn archetype:generate \
       -DarchetypeGroupId=org.apache.beam \
       -DarchetypeArtifactId=beam-sdks-java-maven-archetypes-dataflow-examples \
       -DarchetypeVersion=2.53.0-SNAPSHOT \
       -DtargetPlatform=11 \
       -DgroupId=org.example \
       -DartifactId=word-count-beam \
       -Dversion="0.1" \
       -Dpackage=org.apache.beam.dataflow.examples \
       -DinteractiveMode=false
   ```
   
   And
   
   ```
   mvn clean package exec:java -Dexec.mainClass="org.apache.beam.dataflow.examples.WordCount" -Dexec.args='--runner=DataflowRunner --project={PROJECT} --output=gs://{BUCKET}/output'
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato closed pull request #29447: Add Maven archetype for examples with Dataflow Runner only
URL: https://github.com/apache/beam/pull/29447


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1815014735

   > iiuc the src code are the same as current examples maven-artifact, and only the pom.xml is different (most dependency arragement). And it simplifies the need of `-Pdataflow-runner` comparing to https://beam.apache.org/get-started/quickstart-java/
   > 
   > If there are problem or anything making it inconvenient using existing examples maven-artifact for Dataflow runner we should fix there, personally I am -1 to create a new dataflow only artifact, as Beam acts/markets as it runs on different runners.
   
   Thanks!
   I helped someone trying to use the examples to start a Dataflow project and it wasn't the user friendly. But I agree that maybe the archetype here isn't the best venue.
   
   The main concern is that there's a bloat and version properties for all runners which make it confusing. I'll see if there's a way to add profiles conditionally to the archetype. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1814910686

   iiuc the src code are the same as current examples maven-artifact, and only the pom.xml is different (most dependency arragement). And it simplifies the need of `-Pdataflow-runner` comparing to https://beam.apache.org/get-started/quickstart-java/
   
   If there are problem or anything making it inconvenient using existing examples maven-artifact for Dataflow runner we should fix there, personally I am -1 to create a new dataflow only artifact, as Beam acts/markets as it runs on different runners.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1825590709

   Reminder, please take a look at this pr: @kennknowles @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1814665399

   assign set of reviewers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1814668047

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @kennknowles for label java.
   R: @Abacn for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1829722837

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @robertwb for label java.
   R: @damccorm for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1842750071

   Reminder, please take a look at this pr: @robertwb @damccorm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1847136317

   Not proceeding for now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1813796071

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1847072277

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn for label java.
   R: @Abacn for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Maven archetype for examples with Dataflow Runner only [beam]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #29447:
URL: https://github.com/apache/beam/pull/29447#issuecomment-1813772723

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/29447?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`2ad4591`)](https://app.codecov.io/gh/apache/beam/commit/2ad459113134dfffd3caeeb15e821bb644e08663?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 38.34% compared to head [(`f615212`)](https://app.codecov.io/gh/apache/beam/pull/29447?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 38.33%.
   > Report is 30 commits behind head on master.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #29447      +/-   ##
   ==========================================
   - Coverage   38.34%   38.33%   -0.01%     
   ==========================================
     Files         693      694       +1     
     Lines      102235   102265      +30     
   ==========================================
   + Hits        39199    39204       +5     
   - Misses      61444    61469      +25     
     Partials     1592     1592              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/beam/pull/29447/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [python](https://app.codecov.io/gh/apache/beam/pull/29447/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `29.88% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/29447?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org