You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "pilichoumao (via GitHub)" <gi...@apache.org> on 2026/10/14 03:34:58 UTC

[PR] fix(alerts): restore open-ended event time filters [rocketmq-dashboard]

pilichoumao opened a new pull request, #6637:
URL: https://github.com/apache/rocketmq-dashboard/pull/6637

   ### Which Issue(s) This PR Fixes
   
   Fixes #6636.
   
   ### Brief Description
   
   After #6633 replaced two independent datetime inputs with a RangePicker, entering only the start or end time stopped applying the time filter. The backend accepts each endpoint independently, and the previous controls supported that behavior.
   
   Enable empty endpoints on the existing picker. Three regressions exercise start-only and end-only filtering/export, and clearing a bounded range before selecting an end-only filter. They interact with the real picker and assert service parameters; the bounded-range test and existing UTC conversion stay in place. No new UI text or API changes.
   
   ### How Did You Test This Change?
   
   - ECS Ubuntu 24.04 / Node.js 20.20.2 / Asia/Shanghai: run the final three regressions against the unchanged component — **3 fail**, existing bounded-range control **1 passes**. With the fix, the full SystemAlertsPage file passes **24/24**, no skipped tests. Single worker; 60-second per-test budget on the shared ECS.
   - ECS and local `npm run build`: TypeScript project build, Vite production build and license check passed.
   - Local full frontend suite: **1618 passed, 1 failed**, across 160 files. All 24 SystemAlertsPage cases passed. The failure is in the unchanged Producer test `discards a slow connection response after the topic changes` (`pointer-events: none`), previously observed on the baseline; it is not hidden or included in this PR's scope.
   - `npm run lint`: 0 errors, 10 existing warnings. Changed-file ESLint: 0 errors, 1 existing effect-dependency warning. `npm run license:test`: 5 passed. Prettier and diff checks passed.
   
   No live Broker, database, Docker image or full ECS Web-suite verification was performed for this frontend-only change.
   
   ### Checklist
   
   - [x] One coherent change; Conventional Commit subject
   - [x] Regression tests added while preserving existing assertions
   - [x] No new UI text, source files, API or architecture changes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(alerts): restore open-ended event time filters [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #6637:
URL: https://github.com/apache/rocketmq-dashboard/pull/6637


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org