[GitHub] [helix] brentwritescode commented on pull request #1594: Fix builds failing on some non-Oracle JDKs

[GitBox <gi...@apache.org>]

brentwritescode commented on pull request #1594:
URL: https://github.com/apache/helix/pull/1594#issuecomment-746579232


   Sure, I can do that.  
   
   I think the difference worth pointing out is that things from the `sun.*` packages literally don't compile on some JDKs whereas things from `commons-lang3` compile fine, they just come from a 3rd party dependency instead of from the core JDK itself.
   
   The usage of `commons-lang3` as a whole in the entire project seems pretty minimal.  It's only getting used in a few places in `helix-rest` (JerseyUriRequestBuilder, ClusterAccessor, InstancesAccesor) and one place in `zookeeper-api` (RoutingDataReaderType) so maybe a future consideration might be either making more use of it or removing the dependency entirely from the project.
   
   Updated PR incoming.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org