[GitHub] [spark] zero323 commented on a change in pull request #33900: [SPARK-36654][PYTHON] Drop type ignores from numpy imports

[GitBox <gi...@apache.org>]

zero323 commented on a change in pull request #33900:
URL: https://github.com/apache/spark/pull/33900#discussion_r702889707



##########
File path: examples/src/main/python/sql/arrow.py
##########
@@ -32,7 +32,7 @@
 
 
 def dataframe_with_arrow_example(spark):
-    import numpy as np  # type: ignore[import]
+    import numpy as np

Review comment:
       Thank you for your feedback @HyukjinKwon! 
   
   I am aware that this is an optional dependency, but I don't think it really affects this PR ‒ I will update the description within the next few days to describe different scenarios and possible impact of this change to make that clear.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org