You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shafiquejamal <gi...@git.apache.org> on 2016/06/10 23:43:00 UTC
[GitHub] spark pull request #13614: Support Stata-like tabulation of values in a sing...
GitHub user shafiquejamal opened a pull request:
https://github.com/apache/spark/pull/13614
Support Stata-like tabulation of values in a single column, optionally with weights
## What changes were proposed in this pull request?
See JIRA ticket: https://issues.apache.org/jira/browse/SPARK-15890
## How was this patch tested?
Test is included.
I suspect that the changes in the /dev/pr-deps directory should not have been committed, but I would think that the .gitignore file would have prevented this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shafiquejamal/spark crosstab
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13614.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13614
----
commit 24ed3151db1ed2188ad67b2b5ccbf2883adf7af2
Author: Shafique Jamal <sh...@gmail.com>
Date: 2016-06-10T23:31:50Z
Support Stata-like tabulation of values in a single column, optionally with weights
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13614: [SPARK-15980] [SQL] Support Stata-like tabulation...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13614
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13614: [SPARK-15980] [SQL] Support Stata-like tabulation of val...
Posted by shafiquejamal <gi...@git.apache.org>.
Github user shafiquejamal commented on the issue:
https://github.com/apache/spark/pull/13614
Hello, just wanted to know what else I should do in order for this PR to be accepted. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13614: Support Stata-like tabulation of values in a single colu...
Posted by shafiquejamal <gi...@git.apache.org>.
Github user shafiquejamal commented on the issue:
https://github.com/apache/spark/pull/13614
Hello, I read the rules at the link before creating the Jira ticket and pull request, and I think I am in compliance. Can you please tell me which point at that link I have not complied with? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13614: Support Stata-like tabulation of values in a single colu...
Posted by sadikovi <gi...@git.apache.org>.
Github user sadikovi commented on the issue:
https://github.com/apache/spark/pull/13614
@shafiquejamal
The PR title should be of the form [SPARK-xxxx] [COMPONENT] Title, where SPARK-xxxx is the relevant JIRA number, COMPONENT is one of the PR categories shown at https://spark-prs.appspot.com/ and Title may be the JIRA's title or a more specific title describing the PR itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13614: Support Stata-like tabulation of values in a single colu...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13614
I think it will be nicer if it follows https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13614: Support Stata-like tabulation of values in a single colu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13614
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13614: [SPARK-15980] [SQL] Support Stata-like tabulation of val...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13614
This PR looks like it has some problems. It adds some deps files that are unrelated. Generally you'd want to argue that this functionality is important enough to justify the burden of maintaining it as an API. I'm not (yet) sure it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13614: Support Stata-like tabulation of values in a single colu...
Posted by shafiquejamal <gi...@git.apache.org>.
Github user shafiquejamal commented on the issue:
https://github.com/apache/spark/pull/13614
Ok, I'll close this an open a new PR with the title done correctly. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org