You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by bt...@apache.org on 2021/06/11 07:37:05 UTC
[james-project] 09/18: JAMES-3594 Complement existing LDAP tests to
cover all basic read operations
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit e080d390587f12b063962b0416a10a72ff041e3e
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Wed Jun 9 09:11:55 2021 +0700
JAMES-3594 Complement existing LDAP tests to cover all basic read operations
---
.../user/ldap/ReadOnlyUsersLDAPRepositoryTest.java | 44 +++++++++++++++++++++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/server/data/data-ldap/src/test/java/org/apache/james/user/ldap/ReadOnlyUsersLDAPRepositoryTest.java b/server/data/data-ldap/src/test/java/org/apache/james/user/ldap/ReadOnlyUsersLDAPRepositoryTest.java
index 7ae78e4..db551cc 100644
--- a/server/data/data-ldap/src/test/java/org/apache/james/user/ldap/ReadOnlyUsersLDAPRepositoryTest.java
+++ b/server/data/data-ldap/src/test/java/org/apache/james/user/ldap/ReadOnlyUsersLDAPRepositoryTest.java
@@ -47,6 +47,8 @@ import org.junit.jupiter.api.extension.RegisterExtension;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import com.google.common.collect.ImmutableList;
+
class ReadOnlyUsersLDAPRepositoryTest {
static final Logger LOGGER = LoggerFactory.getLogger(ReadOnlyUsersLDAPRepositoryTest.class);
@@ -98,6 +100,26 @@ class ReadOnlyUsersLDAPRepositoryTest {
}
@Test
+ void listShouldReturnExistingUsers() throws Exception {
+ assertThat(ImmutableList.copyOf(usersRepository.list())).containsOnly(JAMES_USER_MAIL);
+ }
+
+ @Test
+ void countUsersShouldReturnOne() throws Exception {
+ assertThat(usersRepository.countUsers()).isEqualTo(1);
+ }
+
+ @Test
+ void containsShouldReturnTrueWhenUserExists() throws Exception {
+ assertThat(usersRepository.contains(JAMES_USER_MAIL)).isTrue();
+ }
+
+ @Test
+ void containsShouldReturnFalseWhenUserDoesNotExists() throws Exception {
+ assertThat(usersRepository.contains(Username.of("unknown@" + DOMAIN))).isFalse();
+ }
+
+ @Test
void testShouldStillWorkAfterRestartingLDAP() throws Exception {
usersRepository.test(JAMES_USER_MAIL, PASSWORD);
@@ -172,6 +194,26 @@ class ReadOnlyUsersLDAPRepositoryTest {
}
@Test
+ void listShouldReturnExistingUsers() throws Exception {
+ assertThat(ImmutableList.copyOf(usersRepository.list())).containsOnly(JAMES_USER);
+ }
+
+ @Test
+ void countUsersShouldReturnOne() throws Exception {
+ assertThat(usersRepository.countUsers()).isEqualTo(1);
+ }
+
+ @Test
+ void containsShouldReturnTrueWhenUserExists() throws Exception {
+ assertThat(usersRepository.contains(JAMES_USER)).isTrue();
+ }
+
+ @Test
+ void containsShouldReturnFalseWhenUserDoesNotExists() throws Exception {
+ assertThat(usersRepository.contains(Username.of("unknown"))).isFalse();
+ }
+
+ @Test
void knownUserShouldNotBeAbleToLogInWhenPasswordIsNotCorrect() throws Exception {
assertThat(usersRepository.test(JAMES_USER, BAD_PASSWORD)).isFalse();
}
@@ -284,7 +326,7 @@ class ReadOnlyUsersLDAPRepositoryTest {
configuration.addProperty("[@ldapHost]", ldapContainer.getLdapHost());
configuration.addProperty("[@principal]", "cn=admin,dc=james,dc=org");
configuration.addProperty("[@credentials]", ADMIN_PASSWORD);
- configuration.addProperty("[@userBase]", "ou=People,dc=james,dc=org");
+ configuration.addProperty("[@userBase]", "ou=people,dc=james,dc=org");
configuration.addProperty("[@userObjectClass]", "inetOrgPerson");
configuration.addProperty("[@maxRetries]", "1");
configuration.addProperty("[@retryStartInterval]", "0");
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org