You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/15 09:08:39 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #37898: [SPARK-40446][PS][DOC] Rename `_MissingPandasXXX` as `MissingPandasXXX`
zhengruifeng opened a new pull request, #37898:
URL: https://github.com/apache/spark/pull/37898
### What changes were proposed in this pull request?
Rename `_MissingPandasXXX` as `MissingPandasXXX`
### Why are the changes needed?
for consistency
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37898: [SPARK-40446][PS][DOC] Rename `_MissingPandasXXX` as `MissingPandasXXX`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37898:
URL: https://github.com/apache/spark/pull/37898#issuecomment-1248868848
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #37898: [SPARK-40446][PS][DOC] Rename `_MissingPandasXXX` as `MissingPandasXXX`
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #37898:
URL: https://github.com/apache/spark/pull/37898#discussion_r971996428
##########
python/pyspark/pandas/missing/frame.py:
##########
@@ -29,7 +29,7 @@ def _unsupported_property(property_name, deprecated=False, reason=""):
)
-class _MissingPandasLikeDataFrame:
+class MissingPandasLikeDataFrame:
Review Comment:
Is this convention not used to 'hide' classes from docs or APIs in Python? I don't know if it applies to classes. Just wondering if it's intentional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #37898: [SPARK-40446][PS][DOC] Rename `_MissingPandasXXX` as `MissingPandasXXX`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #37898:
URL: https://github.com/apache/spark/pull/37898#discussion_r972518778
##########
python/pyspark/pandas/missing/frame.py:
##########
@@ -29,7 +29,7 @@ def _unsupported_property(property_name, deprecated=False, reason=""):
)
-class _MissingPandasLikeDataFrame:
+class MissingPandasLikeDataFrame:
Review Comment:
they will not be shown in the API references, because they are not registered in `python/docs/source/reference/pyspark.pandas`
All internal classes in Pandas-API-on-Spark but the three `_MissingPandasXXX` ones do not start with `_`, so I think it's fine to make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #37898: [SPARK-40446][PS][DOC] Rename `_MissingPandasXXX` as `MissingPandasXXX`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #37898:
URL: https://github.com/apache/spark/pull/37898#issuecomment-1248790175
cc @HyukjinKwon @itholic @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org