[GitHub] [druid] maytasm commented on pull request #10962: Fix streaming ingestion fails if it encounters empty rows (Regression)

[GitBox <gi...@apache.org>]

maytasm commented on pull request #10962:
URL: https://github.com/apache/druid/pull/10962#issuecomment-794223629


   > I'm curious that why not skip the empty rows instead of throwing a `ParseException` ?
   
   This PR simply fix the regression caused by https://github.com/apache/druid/pull/10383 and not intended to change / redesign any behavior. The behavior for streaming ingestion before https://github.com/apache/druid/pull/10383 was that it throw `ParseException` for empty row. Also the current behavior for `JsonLineReader` (batch ingestion) is that it throw `ParseException` for empty row. After fixing the regression (which will at least allow streaming task to proceed through empty row like before the https://github.com/apache/druid/pull/10383 change), we can have a separate discussion on if we want to change the behavior to simply skip the empty rows instead. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org