You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Cloudera) (Code Review)" <ge...@cloudera.org> on 2022/08/02 22:35:20 UTC

[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change

Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18800 )

Change subject: Update gerrit-auto-critic for a virtualenv API change
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18800/1/bin/jenkins/critique-gerrit-review.py
File bin/jenkins/critique-gerrit-review.py:

http://gerrit.cloudera.org:8080/#/c/18800/1/bin/jenkins/critique-gerrit-review.py@79
PS1, Line 79:  virtualenv.cli_run([VENV_PATH])
Jenkins is currently running with this change in production, but the patch is sourced from my own Impala fork on Github.
This also required a change to the job's embedded build script so that the repo URL for the review scripts and the commit to be critiqued can be separated.



-- 
To view, visit http://gerrit.cloudera.org:8080/18800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
Gerrit-Change-Number: 18800
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Aug 2022 22:35:20 +0000
Gerrit-HasComments: Yes