You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by cd...@apache.org on 2018/11/23 18:48:49 UTC
[incubator-plc4x] branch develop updated: Fixed some failing tests
This is an automated email from the ASF dual-hosted git repository.
cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
The following commit(s) were added to refs/heads/develop by this push:
new 4c79f29 Fixed some failing tests
4c79f29 is described below
commit 4c79f293d8d7f8ab7be1cdea0106f094779fec20
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Fri Nov 23 19:48:43 2018 +0100
Fixed some failing tests
---
.../plc4x/java/base/messages/DefaultPlcSubscriptionEventTest.java | 8 +++++---
.../plc4x/java/base/model/DefaultPlcSubscriptionHandleTest.java | 5 +++--
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/plc4j/protocols/driver-bases/base/src/test/java/org/apache/plc4x/java/base/messages/DefaultPlcSubscriptionEventTest.java b/plc4j/protocols/driver-bases/base/src/test/java/org/apache/plc4x/java/base/messages/DefaultPlcSubscriptionEventTest.java
index f2affa4..e244247 100644
--- a/plc4j/protocols/driver-bases/base/src/test/java/org/apache/plc4x/java/base/messages/DefaultPlcSubscriptionEventTest.java
+++ b/plc4j/protocols/driver-bases/base/src/test/java/org/apache/plc4x/java/base/messages/DefaultPlcSubscriptionEventTest.java
@@ -19,7 +19,6 @@
package org.apache.plc4x.java.base.messages;
-import org.apache.commons.lang3.NotImplementedException;
import org.apache.commons.lang3.tuple.ImmutablePair;
import org.apache.commons.lang3.tuple.Pair;
import org.apache.plc4x.java.api.types.PlcResponseCode;
@@ -32,6 +31,7 @@ import java.time.Instant;
import java.util.HashMap;
import java.util.Map;
+import static org.hamcrest.core.IsEqual.equalTo;
import static org.hamcrest.core.IsNull.notNullValue;
import static org.junit.Assert.assertThat;
import static org.junit.jupiter.api.Assertions.assertThrows;
@@ -49,12 +49,14 @@ class DefaultPlcSubscriptionEventTest {
@Test
void getFieldNames() {
- assertThrows(NotImplementedException.class, () -> SUT.getFieldNames());
+ assertThat(SUT.getFieldNames(), notNullValue());
+ assertThat(SUT.getFieldNames().size(), equalTo(1));
+ assertThat(SUT.getFieldNames().iterator().next(), equalTo("foo"));
}
@Test
void getField() {
- assertThrows(NotImplementedException.class, () -> SUT.getField("foo"));
+ assertThrows(UnsupportedOperationException.class, () -> SUT.getField("foo"));
}
@Test
diff --git a/plc4j/protocols/driver-bases/base/src/test/java/org/apache/plc4x/java/base/model/DefaultPlcSubscriptionHandleTest.java b/plc4j/protocols/driver-bases/base/src/test/java/org/apache/plc4x/java/base/model/DefaultPlcSubscriptionHandleTest.java
index 9f8ef53..0d04b7f 100644
--- a/plc4j/protocols/driver-bases/base/src/test/java/org/apache/plc4x/java/base/model/DefaultPlcSubscriptionHandleTest.java
+++ b/plc4j/protocols/driver-bases/base/src/test/java/org/apache/plc4x/java/base/model/DefaultPlcSubscriptionHandleTest.java
@@ -65,8 +65,9 @@ class DefaultPlcSubscriptionHandleTest {
@Test
void equals() {
- EqualsVerifier.forClass(DefaultPlcSubscriptionHandle.class)
- .suppress(Warning.STRICT_INHERITANCE).verify();
+ EqualsVerifier.forClass(DefaultPlcSubscriptionHandle.class).usingGetClass()
+ .suppress(Warning.STRICT_INHERITANCE).suppress(Warning.IDENTICAL_COPY)
+ .suppress(Warning.ALL_FIELDS_SHOULD_BE_USED).verify();
}
}
\ No newline at end of file