[GitHub] [kafka] likeyoukang opened a new pull request, #12852: Enhance the robustness of the program

[GitBox <gi...@apache.org>]

likeyoukang opened a new pull request, #12852:
URL: https://github.com/apache/kafka/pull/12852

   Enhance the robustness of the program, flip the equals method, and prevent NPE.
   
   eg:
   field.defaultString().equals("null")  -> "null".equals(field.defaultString())


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] divijvaidya commented on pull request #12852: Enhance the robustness of the program

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on PR #12852:
URL: https://github.com/apache/kafka/pull/12852#issuecomment-1594740256

   Hey @likeyoukang 
   Thank you for your first contribution. Could you please rebase this PR from trunk? And also change the title of the PR to "MINOR: Use "constant equals object" instead of "object equals Constant""


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org