You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2023/06/27 22:46:42 UTC
[GitHub] [pinot] Jackie-Jiang opened a new pull request, #10985: [Clean up] Do not count DISTINCT as aggregation
Jackie-Jiang opened a new pull request, #10985:
URL: https://github.com/apache/pinot/pull/10985
Context:
- When introducing the first version of `DISTINCT`, we treat it as aggregation. Then we found a lot of limitations because of that. To solve the limitations we implemented a dedicate operator for `DISTINCT` queries, but still keep it as an `AggregationFunction`. Before this PR, `DistinctAggregationFunction` works as a placeholder without handling the result computation.
This PR:
- Removes `DistinctAggregationFunction` completely and no longer model `DISTINCT` as aggregation.
- `AggregationFunctionFactory` no longer need to take the `QueryContext` as argument. It makes it much more self contained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on pull request #10985: [Clean up] Do not count DISTINCT as aggregation
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #10985:
URL: https://github.com/apache/pinot/pull/10985#issuecomment-1610421570
cc @vvivekiyer @somandal This should simplify the aggregation function creation on V2 engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10985: [Clean up] Do not count DISTINCT as aggregation
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10985:
URL: https://github.com/apache/pinot/pull/10985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10985: [Clean up] Do not count DISTINCT as aggregation
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10985:
URL: https://github.com/apache/pinot/pull/10985#issuecomment-1610386681
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10985](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2a7c021) into [master](https://app.codecov.io/gh/apache/pinot/commit/238629c41c551c6f42e38f817749aa445beea343?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (238629c) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10985 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2192 2137 -55
Lines 118087 115534 -2553
Branches 17885 17581 -304
=========================================
Hits 137 137
+ Misses 117930 115377 -2553
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `0.11% <0.00%> (+<0.01%)` | :arrow_up: |
| unittests2temurin20 | `0.11% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../operator/blocks/results/DistinctResultsBlock.java](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9EaXN0aW5jdFJlc3VsdHNCbG9jay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ore/operator/blocks/results/ResultsBlockUtils.java](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9SZXN1bHRzQmxvY2tVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...perator/query/DictionaryBasedDistinctOperator.java](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9EaWN0aW9uYXJ5QmFzZWREaXN0aW5jdE9wZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/pinot/core/operator/query/DistinctOperator.java](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9EaXN0aW5jdE9wZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/pinot/core/plan/DistinctPlanNode.java](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0Rpc3RpbmN0UGxhbk5vZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...gregation/function/AggregationFunctionFactory.java](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...t/core/query/distinct/DistinctExecutorFactory.java](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9EaXN0aW5jdEV4ZWN1dG9yRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../pinot/core/query/reduce/BaseGapfillProcessor.java](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQmFzZUdhcGZpbGxQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ot/core/query/reduce/DistinctDataTableReducer.java](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvRGlzdGluY3REYXRhVGFibGVSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ache/pinot/core/query/reduce/GapfillProcessor.java](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvR2FwZmlsbFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [6 more](https://app.codecov.io/gh/apache/pinot/pull/10985?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [56 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10985/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org