You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/08/06 19:05:52 UTC
[kudu-CR] [gradle] Remove integrationTest tasks
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11130
Change subject: [gradle] Remove integrationTest tasks
......................................................................
[gradle] Remove integrationTest tasks
When initially adding the Gradle build I added separate
source set definitions and tasks for Integration tests to
match the Maven build. However, given that the
gradle retry logic is the same for all tests and there
is no real difference between and integration test and
a unit test, we should remove this to simplify the build.
Change-Id: I58c0bafd19cc21ad9c0f83159fdc47d01e3731bf
---
M build-support/jenkins/build-and-test.sh
M java/gradle/quality.gradle
M java/gradle/tests.gradle
3 files changed, 5 insertions(+), 53 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/11130/1
--
To view, visit http://gerrit.cloudera.org:8080/11130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58c0bafd19cc21ad9c0f83159fdc47d01e3731bf
Gerrit-Change-Number: 11130
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [gradle] Remove integrationTest tasks
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11130 )
Change subject: [gradle] Remove integrationTest tasks
......................................................................
[gradle] Remove integrationTest tasks
When initially adding the Gradle build I added separate
source set definitions and tasks for Integration tests to
match the Maven build. However, given that the
gradle retry logic is the same for all tests and there
is no real difference between and integration test and
a unit test, we should remove this to simplify the build.
Change-Id: I58c0bafd19cc21ad9c0f83159fdc47d01e3731bf
Reviewed-on: http://gerrit.cloudera.org:8080/11130
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/jenkins/build-and-test.sh
M java/gradle/quality.gradle
M java/gradle/tests.gradle
3 files changed, 5 insertions(+), 53 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I58c0bafd19cc21ad9c0f83159fdc47d01e3731bf
Gerrit-Change-Number: 11130
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [gradle] Remove integrationTest tasks
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11130 )
Change subject: [gradle] Remove integrationTest tasks
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11130/1/java/gradle/tests.gradle
File java/gradle/tests.gradle:
http://gerrit.cloudera.org:8080/#/c/11130/1/java/gradle/tests.gradle@a89
PS1, Line 89:
:
So these two lines were different for itests than for regular tests. What effect did they have?
--
To view, visit http://gerrit.cloudera.org:8080/11130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58c0bafd19cc21ad9c0f83159fdc47d01e3731bf
Gerrit-Change-Number: 11130
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 06 Aug 2018 19:08:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] [gradle] Remove integrationTest tasks
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11130 )
Change subject: [gradle] Remove integrationTest tasks
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11130/1/java/gradle/tests.gradle
File java/gradle/tests.gradle:
http://gerrit.cloudera.org:8080/#/c/11130/1/java/gradle/tests.gradle@a89
PS1, Line 89:
:
> So these two lines were different for itests than for regular tests. What e
It was adding the main sources and test sources to the classpath for integration tests so things like tests utils were available.
--
To view, visit http://gerrit.cloudera.org:8080/11130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58c0bafd19cc21ad9c0f83159fdc47d01e3731bf
Gerrit-Change-Number: 11130
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 06 Aug 2018 19:09:31 +0000
Gerrit-HasComments: Yes