You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/12/03 15:19:01 UTC
[jira] [Commented] (LUCENE-9618) Improve
IntervalIterator.nextInterval's behavior/documentation/test
[ https://issues.apache.org/jira/browse/LUCENE-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243253#comment-17243253 ]
ASF subversion and git services commented on LUCENE-9618:
---------------------------------------------------------
Commit f24b497c72440bdc5cdaf30f4351f2d5015ece3c in lucene-solr's branch refs/heads/master from Patrick Zhai
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f24b497 ]
LUCENE-9618: Do not call IntervalIterator.nextInterval after NO_MORE_DOCS returned (#2095)
* LUCENE-9618: Do not call IntervalIterator.nextInterval after NO_MORE_DOCS is returned
> Improve IntervalIterator.nextInterval's behavior/documentation/test
> -------------------------------------------------------------------
>
> Key: LUCENE-9618
> URL: https://issues.apache.org/jira/browse/LUCENE-9618
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/query
> Reporter: Haoyu Zhai
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I'm trying to play around with my own {{IntervalSource}} and found out that {{nextInterval}} method of IntervalIterator will be called sometimes even after {{nextDoc}}/ {{docID}}/ {{advance}} method returns NO_MORE_DOCS.
>
> After I dug a bit more I found that {{FilteringIntervalIterator.reset}} is calling an inner iterator's {{nextInterval}} regardless of what the result of {{nextDoc}}, and also most (if not all) existing {{IntervalIterator}}'s implementation do considered the case where {{nextInterval}} is called after {{nextDoc}} returns NO_MORE_DOCS.
>
> We should probably update the javadoc and test if the behavior is necessary. Or we should change the current implementation to avoid this behavior
> original email discussion thread:
> https://markmail.org/thread/aytal77bgzl2zafm
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org