[GitHub] [iceberg] syun64 commented on a diff in pull request #6980: Spark-3.3: Bug Fix for Reading Metadata tables with Snapshot

["syun64 (via GitHub)" <gi...@apache.org>]

syun64 commented on code in PR #6980:
URL: https://github.com/apache/iceberg/pull/6980#discussion_r1123194620


##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java:
##########
@@ -488,6 +489,54 @@ public void testMetadataLogEntries() throws Exception {
         metadataLogWithProjection);
   }
 
+  @Test
+  public void testFilesVersionAsOf() throws Exception {
+    // Create table and insert data
+    sql(
+            "CREATE TABLE %s (id bigint, data string) "
+                    + "USING iceberg "
+                    + "PARTITIONED BY (data) "
+                    + "TBLPROPERTIES"
+                    + "('format-version'='2', 'write.delete.mode'='merge-on-read')",
+            tableName);
+
+    List<SimpleRecord> recordsA =
+            Lists.newArrayList(new SimpleRecord(1, "a"), new SimpleRecord(2, "a"));
+    spark
+            .createDataset(recordsA, Encoders.bean(SimpleRecord.class))
+            .coalesce(1)
+            .writeTo(tableName)
+            .append();
+
+    Table table = Spark3Util.loadIcebergTable(spark, tableName);
+    Long olderSnapshotId = table.currentSnapshot().snapshotId();
+
+    sql(
+            "ALTER TABLE %s ADD COLUMNS (data2 string)",
+            tableName);
+
+    List<SimpleExtraColumnRecord> recordsB =
+            Lists.newArrayList(new SimpleExtraColumnRecord(1, "b", "c"), new SimpleExtraColumnRecord (2, "b", "c"));
+    spark
+            .createDataset(recordsB, Encoders.bean(SimpleExtraColumnRecord.class))
+            .coalesce(1)
+            .writeTo(tableName)
+            .append();
+
+
+    List<Object[]> res1 = sql("SELECT * from %s.files VERSION AS OF %s", tableName, olderSnapshotId );
+
+    Dataset<Row> ds = spark.read().format("iceberg").option("snapshot-id", olderSnapshotId ).load(tableName + ".files");
+    List<Row> res2 = ds.collectAsList();
+
+    Long currentSnapshotId = table.currentSnapshot().snapshotId();
+
+    List<Object[]> res3 = sql("SELECT * from %s.files VERSION AS OF %s", tableName, currentSnapshotId);
+
+    Dataset<Row> ds2 = spark.read().format("iceberg").option("snapshot-id", currentSnapshotId ).load(tableName + ".files");

Review Comment:
   Hi @szehon-ho I took your first advice based on testAllFilesPartitioned - may I ask you for a second look through this test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org