svn commit: r793714 - in /incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets: DefaultGadgetSpecFactory.java templates/DefaultTemplateProcessor.java

[aw...@apache.org]

Author: awiner
Date: Mon Jul 13 21:15:54 2009
New Revision: 793714

URL: http://svn.apache.org/viewvc?rev=793714&view=rev
Log:
Small logging improvements to a couple of logging hooks:
- Use parameter substitution instead of string assembly
- Add the gadget URL to caught ELExceptions during template processing

Modified:
    incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
    incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java

Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java?rev=793714&r1=793713&r2=793714&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java Mon Jul 13 21:15:54 2009
@@ -39,6 +39,7 @@
 import org.w3c.dom.Element;
 
 import java.util.concurrent.ExecutorService;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 /**
@@ -214,10 +215,10 @@
         cache.addElement(uri, newObject, refresh);
       } catch (GadgetException e) {
         if (old != null) {
-          logger.info("Failed to update " + uri + ". Using cached version.");
+          logger.log(Level.INFO, "Failed to update {0}. Using cached version.", uri);
           cache.addElement(uri, old, refresh);
         } else {
-          logger.info("Failed to update " + uri + ". Applying negative cache.");
+          logger.log(Level.INFO, "Failed to update {0}. Applying negative cache.", uri);
           cache.addElement(uri, e, refresh);
         }
       }

Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java?rev=793714&r1=793713&r2=793714&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java Mon Jul 13 21:15:54 2009
@@ -33,6 +33,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 import javax.el.ELContext;
@@ -479,7 +480,9 @@
       Object result = expr.getValue(elContext);
       return type.cast(result);
     } catch (ELException e) {
-      logger.warning(e.getMessage());
+      logger.log(Level.WARNING, "EL failure for gadget {0}: {1}",
+          new Object[]{getTemplateContext().getGadget().getContext().getUrl(),
+              e.getMessage()});
       return defaultValue;
     }
   }