[GitHub] thrift pull request: changed the dict() to dict:dict() in the type...

[cjimison <gi...@git.apache.org>]

GitHub user cjimison opened a pull request:

    https://github.com/apache/thrift/pull/148

    changed the dict() to dict:dict() in the type spec of types and generate...

    ...d the -type spec for each record in the _types.hrl file
    
    This is needed for Erlang R17 support as well as being able to run the code in dialyzer

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjimison/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/148.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #148
    
----
commit 36fa676d1d3de8d9195fee6432af46fabc2a72e3
Author: Chris Jimison <ch...@merigo.co>
Date:   2014-06-27T18:25:43Z

    changed the dict() to dict:dict() in the type spec of types and generated the -type spec for each record in the _types.hrl file

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: changed the dict() to dict:dict() in the type...

[jfarrell <gi...@git.apache.org>]

Github user jfarrell commented on the pull request:

    https://github.com/apache/thrift/pull/148#issuecomment-93616012
  
    Thanks for your patch @cjimison, in order for us to accept a pull request we need to have a jira ticket associated with it. Please see our contributing guide at http://thrift.apache.org/docs/HowToContribute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: changed the dict() to dict:dict() in the type...

[drobakowski <gi...@git.apache.org>]

Github user drobakowski commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/148#discussion_r14310051
  
    --- Diff: compiler/cpp/src/generate/t_erl_generator.cc ---
    @@ -510,7 +510,7 @@ string t_erl_generator::render_member_type(t_field * field) {
       } else if (type->is_struct() || type->is_xception()) {
         return "#" + uncapitalize(type->get_name()) + "{}";
       } else if (type->is_map()) {
    -    return "dict()";
    +    return "dict:dict()";
    --- End diff --
    
    Hi @cjimison good point but doesn't this break the compatibility with Erlang/OTP prior to 17.0? I think this could be done over an conditional macro defined in the rebar.config: ```{erl_opts, [ {platform_define, "^R", pre17} ]}``` and some additions with ```-ifdef(pre17). ... -else. ... -endif.```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: changed the dict() to dict:dict() in the type...

[jfarrell <gi...@git.apache.org>]

Github user jfarrell closed the pull request at:

    https://github.com/apache/thrift/pull/148


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---