Re: [PR] API, Flink: Correct Handling of Table Names Containing Dots [iceberg]

["mxm (via GitHub)" <gi...@apache.org>]

mxm commented on code in PR #14932:
URL: https://github.com/apache/iceberg/pull/14932#discussion_r2755267479


##########
api/src/main/java/org/apache/iceberg/catalog/TableIdentifier.java:
##########
@@ -26,10 +27,10 @@
 import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
 
 /** Identifies a table in iceberg catalog. */
-public class TableIdentifier {
+public class TableIdentifier implements Serializable {

Review Comment:
   I think fixing the parsing logic would be preferable for me. There are many cases where we dynamically need to parse a table name and we don't want to rely on Java serialization in the process.
   
   Making Namespace / TableIdentifier Serializable could be an addition. What do you think about the Serializable change @pvary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org