You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/04/19 07:45:29 UTC

[GitHub] [superset] kgabryje commented on a diff in pull request #23551: feat: Add deck.gl Heatmap Visualization

kgabryje commented on code in PR #23551:
URL: https://github.com/apache/superset/pull/23551#discussion_r1170947949


##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Heatmap/Heatmap.jsx:
##########
@@ -0,0 +1,82 @@
+/**

Review Comment:
   Could you please refactor this file to typescript? I know that the rest of deckgl plugins are written in javascript, but our policy is for create the new files in typescript and SOME day refactor the old js files to ts too 🙂 (correct me if I'm wrong @rusackas)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org