You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/01/05 13:46:05 UTC
Review Request 55210: Config Groups: Save button not enabled while
trying to overwrite configs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55210/
-----------------------------------------------------------
Review request for Ambari and Andrii Tkach.
Bugs: ambari-19182
https://issues.apache.org/jira/browse/ambari-19182
Repository: ambari
Description
-------
STR:
-> For a service, create a config group
-> Go to configs page, select the config group. Now try to overwrite a config, Save button is not enabled here.
Diffs
-----
ambari-web/app/models/configs/objects/service_config.js 7d07467
ambari-web/test/controllers/main/admin/highAvailability/journalNode/step4_controller_test.js ba92b54
ambari-web/test/controllers/main/admin/highAvailability/resourceManager/step3_controller_test.js 665d8e6
ambari-web/test/utils/config_test.js 7c2515a
Diff: https://reviews.apache.org/r/55210/diff/
Testing
-------
20126 tests complete (25 seconds)
153 tests pending
Thanks,
Oleg Nechiporenko
Re: Review Request 55210: Config Groups: Save button not enabled while
trying to overwrite configs
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55210/#review160584
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On Jan. 5, 2017, 1:46 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55210/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 1:46 p.m.)
>
>
> Review request for Ambari and Andrii Tkach.
>
>
> Bugs: ambari-19182
> https://issues.apache.org/jira/browse/ambari-19182
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> -> For a service, create a config group
> -> Go to configs page, select the config group. Now try to overwrite a config, Save button is not enabled here.
>
>
> Diffs
> -----
>
> ambari-web/app/models/configs/objects/service_config.js 7d07467
> ambari-web/test/controllers/main/admin/highAvailability/journalNode/step4_controller_test.js ba92b54
> ambari-web/test/controllers/main/admin/highAvailability/resourceManager/step3_controller_test.js 665d8e6
> ambari-web/test/utils/config_test.js 7c2515a
>
> Diff: https://reviews.apache.org/r/55210/diff/
>
>
> Testing
> -------
>
> 20126 tests complete (25 seconds)
> 153 tests pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>