You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/08/30 17:39:21 UTC
[GitHub] [beam] damccorm opened a new pull request, #28228: Keep track of metrics at the KeyedModelHandler level
damccorm opened a new pull request, #28228:
URL: https://github.com/apache/beam/pull/28228
This adds metrics at the per cohort level and aggregate metrics when using a KeyedModelHandler with per key models. We override the base metrics for 2 reasons:
1) We want to keep track of metrics at the per cohort level
2) Model loading happens at a different place in this flow (we load a model right before inference if its not already loaded)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28228: Keep track of metrics at the KeyedModelHandler level
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28228:
URL: https://github.com/apache/beam/pull/28228#issuecomment-1699657832
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @riteshghorse for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #28228: Keep track of metrics at the KeyedModelHandler level
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #28228:
URL: https://github.com/apache/beam/pull/28228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #28228: Keep track of metrics at the KeyedModelHandler level
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #28228:
URL: https://github.com/apache/beam/pull/28228#discussion_r1311719611
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -318,7 +331,7 @@ def __init__(
# of this map should last as long as the corresponding entry in _tag_map.
self._proxy_map: Dict[str, multi_process_shared.MultiProcessShared] = {}
- def load(self, key: str) -> str:
+ def load(self, key: str) -> _ModelLoadStats:
Review Comment:
Yes, good catch - updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on a diff in pull request #28228: Keep track of metrics at the KeyedModelHandler level
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on code in PR #28228:
URL: https://github.com/apache/beam/pull/28228#discussion_r1311707668
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -318,7 +331,7 @@ def __init__(
# of this map should last as long as the corresponding entry in _tag_map.
self._proxy_map: Dict[str, multi_process_shared.MultiProcessShared] = {}
- def load(self, key: str) -> str:
+ def load(self, key: str) -> _ModelLoadStats:
Review Comment:
Should we change the doc for Return to `_ModelLoadStats with tag, byte size and latency to load the model`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #28228: Keep track of metrics at the KeyedModelHandler level
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28228:
URL: https://github.com/apache/beam/pull/28228#issuecomment-1699570450
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#28228](https://app.codecov.io/gh/apache/beam/pull/28228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1c00f1a) into [master](https://app.codecov.io/gh/apache/beam/commit/00136b112bc49e85c84dfe52d7b65560310012fe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (00136b1) will **increase** coverage by `0.00%`.
> Report is 8 commits behind head on master.
> The diff coverage is `94.11%`.
```diff
@@ Coverage Diff @@
## master #28228 +/- ##
=======================================
Coverage 72.28% 72.28%
=======================================
Files 678 678
Lines 99958 100024 +66
=======================================
+ Hits 72256 72307 +51
- Misses 26127 26142 +15
Partials 1575 1575
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/28228/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/28228/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.85% <94.11%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/beam/pull/28228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/ml/inference/base.py](https://app.codecov.io/gh/apache/beam/pull/28228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvaW5mZXJlbmNlL2Jhc2UucHk=) | `93.42% <94.11%> (-0.05%)` | :arrow_down: |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/28228/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org