You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Namrata Thanvi <nt...@pivotal.io> on 2015/07/23 07:36:56 UTC
Re: Review Request 36632: [#99282642] (Merging the changes done in
Changeset 44816]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36632/
-----------------------------------------------------------
(Updated July 23, 2015, 5:36 a.m.)
Review request for geode and Swapnil Bawaskar.
Repository: geode
Description
-------
calling setUsageThreshold() on MemoryPoolMXBean resulted in it reporting incorrect memory usage causing temporary spikes. Since we already set CollectionThreshold? at 1 byte and also have a stat and heap poller thread, we now skip setting the usage threshold. [fixes bug 49064]
tests run: precheckin, hdfs.bt
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java 83462456ccce093dc75661e00ac45888417d434a
Diff: https://reviews.apache.org/r/36632/diff/
Testing
-------
yes.
Thanks,
Namrata Thanvi
Re: Review Request 36632: [#99282642] (Merging the changes done in
Changeset 44816]
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36632/#review92761
-----------------------------------------------------------
A jira ticket needs to be filed on the geode project and then the jira number (GEODE-xxx) needs to be referred to in this review and in your git revision comment.
Some of the info in the trac ticket 52441 should be included but just the info that would make sense to the geode community.
- Darrel Schneider
On July 22, 2015, 10:36 p.m., Namrata Thanvi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36632/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 10:36 p.m.)
>
>
> Review request for geode and Swapnil Bawaskar.
>
>
> Repository: geode
>
>
> Description
> -------
>
> calling setUsageThreshold() on MemoryPoolMXBean resulted in it reporting incorrect memory usage causing temporary spikes. Since we already set CollectionThreshold? at 1 byte and also have a stat and heap poller thread, we now skip setting the usage threshold. [fixes bug 49064]
>
> tests run: precheckin, hdfs.bt
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java 83462456ccce093dc75661e00ac45888417d434a
>
> Diff: https://reviews.apache.org/r/36632/diff/
>
>
> Testing
> -------
>
> yes.
>
>
> Thanks,
>
> Namrata Thanvi
>
>
Re: Review Request 36632: GEODE-154: HDFS region with HeapLRU reports
LowMemoryExceptions even when region size is less then the eviction
threshold
Posted by Swapnil Bawaskar <sb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36632/#review93154
-----------------------------------------------------------
Ship it!
Ship It!
- Swapnil Bawaskar
On July 24, 2015, 6:04 a.m., Namrata Thanvi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36632/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 6:04 a.m.)
>
>
> Review request for geode and Swapnil Bawaskar.
>
>
> Repository: geode
>
>
> Description
> -------
>
> calling setUsageThreshold() on MemoryPoolMXBean resulted in it reporting incorrect memory usage causing temporary spikes. Since we already set CollectionThreshold at 1 byte and also have a stat and heap poller thread, we now skip setting the usage threshold.
>
> tests run: precheckin, hdfs.bt
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java 83462456ccce093dc75661e00ac45888417d434a
>
> Diff: https://reviews.apache.org/r/36632/diff/
>
>
> Testing
> -------
>
> yes.
>
>
> Thanks,
>
> Namrata Thanvi
>
>
Re: Review Request 36632: GEODE-154: HDFS region with HeapLRU reports
LowMemoryExceptions even when region size is less then the eviction
threshold
Posted by Namrata Thanvi <nt...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36632/
-----------------------------------------------------------
(Updated July 24, 2015, 6:04 a.m.)
Review request for geode and Swapnil Bawaskar.
Summary (updated)
-----------------
GEODE-154: HDFS region with HeapLRU reports LowMemoryExceptions even when region size is less then the eviction threshold
Repository: geode
Description (updated)
-------
calling setUsageThreshold() on MemoryPoolMXBean resulted in it reporting incorrect memory usage causing temporary spikes. Since we already set CollectionThreshold at 1 byte and also have a stat and heap poller thread, we now skip setting the usage threshold.
tests run: precheckin, hdfs.bt
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java 83462456ccce093dc75661e00ac45888417d434a
Diff: https://reviews.apache.org/r/36632/diff/
Testing
-------
yes.
Thanks,
Namrata Thanvi