You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/21 11:28:17 UTC

[GitHub] [shardingsphere] tristaZero opened a new pull request #7875: add ASTSQLParserEngineFactory

tristaZero opened a new pull request #7875:
URL: https://github.com/apache/shardingsphere/pull/7875


   Ref #7869


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] menghaoranss merged pull request #7875: add ASTSQLParserEngineFactory

Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #7875:
URL: https://github.com/apache/shardingsphere/pull/7875


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on pull request #7875: add ASTSQLParserEngineFactory

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7875:
URL: https://github.com/apache/shardingsphere/pull/7875#issuecomment-714086614


   > 41
   > 774.xow-
   
   Sorry?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jingshanglu commented on pull request #7875: add ASTSQLParserEngineFactory

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on pull request #7875:
URL: https://github.com/apache/shardingsphere/pull/7875#issuecomment-714186202


   @tristaZero Which interface to get `ast`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-io commented on pull request #7875: add ASTSQLParserEngineFactory

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7875:
URL: https://github.com/apache/shardingsphere/pull/7875#issuecomment-713568032


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7875?src=pr&el=h1) Report
   > Merging [#7875](https://codecov.io/gh/apache/shardingsphere/pull/7875?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/140c10b2073ed5703a6e26d0c57c2f52499e5802?el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7875/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7875?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7875      +/-   ##
   ============================================
   - Coverage     74.94%   74.87%   -0.07%     
     Complexity      532      532              
   ============================================
     Files          1429     1431       +2     
     Lines         22649    22668      +19     
     Branches       4052     4057       +5     
   ============================================
   - Hits          16974    16973       -1     
   - Misses         4580     4599      +19     
   - Partials       1095     1096       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7875?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...sql/parser/engine/ast/ASTSQLParsedResultCache.java](https://codecov.io/gh/apache/shardingsphere/pull/7875/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9lbmdpbmUvYXN0L0FTVFNRTFBhcnNlZFJlc3VsdENhY2hlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...here/sql/parser/engine/ast/ASTSQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7875/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9lbmdpbmUvYXN0L0FTVFNRTFBhcnNlckVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...l/parser/engine/ast/ASTSQLParserEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7875/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9lbmdpbmUvYXN0L0FTVFNRTFBhcnNlckVuZ2luZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ement/standard/StandardSQLParserEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7875/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9lbmdpbmUvc3RhdGVtZW50L3N0YW5kYXJkL1N0YW5kYXJkU1FMUGFyc2VyRW5naW5lRmFjdG9yeS5qYXZh) | `70.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/7875/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7875?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7875?src=pr&el=footer). Last update [140c10b...92ff2c4](https://codecov.io/gh/apache/shardingsphere/pull/7875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] yangyangpig commented on pull request #7875: add ASTSQLParserEngineFactory

Posted by GitBox <gi...@apache.org>.
yangyangpig commented on pull request #7875:
URL: https://github.com/apache/shardingsphere/pull/7875#issuecomment-713618003


   41
   774.xow-


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org