You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/21 00:52:52 UTC
[GitHub] [airflow] jsmodic opened a new issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
jsmodic opened a new issue #13205:
URL: https://github.com/apache/airflow/issues/13205
**Apache Airflow version**:
1.10.14
**What happened**:
> airflow upgradedb
[2020-12-21 00:47:14,079] {db.py:378} INFO - Creating tables
INFO [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO [alembic.runtime.migration] Will assume transactional DDL.
echo $?
0
> airflow db upgrade
(no output)
echo $?
1
**What you expected to happen**:
"airflow db upgrade" to exit 0, or at least output something useful.
<!-- What do you think went wrong? -->
**How to reproduce it**:
I updated from 1.10.12 to 1.10.14.
**Anything else we need to know**:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749226085
Oh that looks like a bug in `db upgrade` -- it's bound to the wrong function maybe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jsmodic commented on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
jsmodic commented on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749237232
https://github.com/apache/airflow/blob/1.10.14/airflow/bin/cli.py#L3114
looks like an easy fix there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jsmodic commented on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
jsmodic commented on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749220257
That must be my misunderstanding, I cut out that output as I thought it was part of the the deprecation warnings (that I have a ton of plugin-related ones).
I was under the impression the two commands were aliases in 1.10.14, so I was migrating my tooling to begin support for 2.0. I guess that's just a battle to fight in 2.0 instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749223319
I believe they are not. They were added very recently (@ashb ? ) and my current thinking was that they were there there to raise awareness about 2.0 migration rather than add the features from 2.0 to 1.10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749226674
@potiuk I added the "new style" commands to 1.10.14 so that it would be possible to upgrade any scripts etc to use new style commands. So this is a bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749951046
Fixed by #13267 :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749114893
I think you are somehow redirecting stderr and do not see what is being written there. This is the message printed to stderr when you run `arflow db upgrade`
```
airflow db upgrade
Please install apache-airflow-upgrade-check distribution from PyPI to perform upgrade checks
root@88e40ae01f74:/opt/airflow# airflow db upgrade 2>/dev/null
root@88e40ae01f74:/opt/airflow#
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #13205:
URL: https://github.com/apache/airflow/issues/13205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jsmodic edited a comment on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
jsmodic edited a comment on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749220257
That must be my misunderstanding, I cut out that output as I thought it was part of the the deprecation warnings (that I have a ton of plugin-related ones).
I was under the impression the two commands were aliases in 1.10.14 to facilitate the 2.0 migration, so I was migrating my tooling to begin that support. I guess that's just a battle to fight in 2.0 instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jsmodic commented on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
jsmodic commented on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749844066
Sure, that's just a one line change: https://github.com/apache/airflow/pull/13267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749608811
> https://github.com/apache/airflow/blob/1.10.14/airflow/bin/cli.py#L3114
>
> looks like an easy fix there
Yeah. Can you please make a PR fixing it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #13205:
URL: https://github.com/apache/airflow/issues/13205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749223319
I believe they are not. They were added very recently (@ashb ? ) and my current thinking was that they were there to raise awareness about 2.0 migration rather than add the features from 2.0 to 1.10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #13205: "airflow upgradedb" succeeds but "airflow db upgrade" fails on 1.10.14
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #13205:
URL: https://github.com/apache/airflow/issues/13205#issuecomment-749608811
> https://github.com/apache/airflow/blob/1.10.14/airflow/bin/cli.py#L3114
>
> looks like an easy fix there
Yeah. Can you please make a PR fixing it ? Nice first-time contribution :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org