You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/17 12:02:52 UTC
Review Request 38455: CMake: Remove thread_tests.cpp from Stout tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38455/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Remove thread_tests.cpp from Stout tests.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt cf5fd5c9840fb58b604dc0cd49b2922efbb2a10e
Diff: https://reviews.apache.org/r/38455/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 38455: CMake: Remove thread_tests.cpp from Stout
tests.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38455/#review99626
-----------------------------------------------------------
Ship it!
Synchronizing makefile and cmakefile a little more as I commit this.
- Joris Van Remoortere
On Sept. 17, 2015, 10:02 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38455/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 10:02 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Remove thread_tests.cpp from Stout tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt cf5fd5c9840fb58b604dc0cd49b2922efbb2a10e
>
> Diff: https://reviews.apache.org/r/38455/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38455: CMake: Remove thread_tests.cpp from Stout
tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38455/#review99372
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38455]
All tests passed.
- Mesos ReviewBot
On Sept. 17, 2015, 10:02 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38455/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 10:02 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Remove thread_tests.cpp from Stout tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt cf5fd5c9840fb58b604dc0cd49b2922efbb2a10e
>
> Diff: https://reviews.apache.org/r/38455/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38455: CMake: Remove thread_tests.cpp from Stout
tests.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38455/#review99434
-----------------------------------------------------------
Looks like this test doesn't exist anymore. At the same time, these exist but are not in the list:
* proc_tests.cpp
* recordio_tests.cpp
* try_tests.cpp
- Joseph Wu
On Sept. 17, 2015, 3:02 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38455/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 3:02 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Remove thread_tests.cpp from Stout tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt cf5fd5c9840fb58b604dc0cd49b2922efbb2a10e
>
> Diff: https://reviews.apache.org/r/38455/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>