You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/19 23:28:12 UTC

[GitHub] [kafka] ableegoldman opened a new pull request, #12310: MINOR: change Streams topic-level metrics tag from 'topic-name' to 'topic'

ableegoldman opened a new pull request, #12310:
URL: https://github.com/apache/kafka/pull/12310

   Changes the tag name from `topic-name` to just `topic` to conform to the way this tag is named elsewhere (ie in the clients)
   
   Also addresses the [followup feedback](https://github.com/apache/kafka/pull/12235#pullrequestreview-997922994) from @cadonna on the [original PR](https://github.com/apache/kafka/pull/12235):
   
   1. fixes a comment about dynamic topic routing
   2. fixes some indentation in `MockRecordCollector`
   3. Undoes the changes to `KStreamSplitTest.scala` and `TestTopicsTest` which are no longer necessary after [this hotfix](https://github.com/apache/kafka/pull/12288)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #12310: MINOR: change Streams topic-level metrics tag from 'topic-name' to 'topic'

Posted by GitBox <gi...@apache.org>.

cadonna commented on PR #12310:
URL: https://github.com/apache/kafka/pull/12310#issuecomment-1161598462

   Build failures are unrelated:
   ```
   Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna merged pull request #12310: MINOR: change Streams topic-level metrics tag from 'topic-name' to 'topic'

Posted by GitBox <gi...@apache.org>.

cadonna merged PR #12310:
URL: https://github.com/apache/kafka/pull/12310


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org