You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/05 21:33:15 UTC

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5593: GEODE-8577: PubSubNativeRedisAcceptanceTest is flaky

jdeppe-pivotal opened a new pull request #5593:
URL: https://github.com/apache/geode/pull/5593


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal merged pull request #5593: GEODE-8577: PubSubNativeRedisAcceptanceTest is flaky

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #5593:
URL: https://github.com/apache/geode/pull/5593


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #5593: GEODE-8577: PubSubNativeRedisAcceptanceTest is flaky

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on pull request #5593:
URL: https://github.com/apache/geode/pull/5593#issuecomment-703981470


   Failing test is unrelated to this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5593: GEODE-8577: PubSubNativeRedisAcceptanceTest is flaky

Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5593:
URL: https://github.com/apache/geode/pull/5593#discussion_r499898286



##########
File path: geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubNativeRedisAcceptanceTest.java
##########
@@ -16,9 +16,11 @@
 package org.apache.geode.redis.internal.executor.pubsub;
 
 import org.junit.ClassRule;
+import org.junit.Ignore;
 
 import org.apache.geode.NativeRedisTestRule;
 
+@Ignore

Review comment:
       I'd suggest having a geode ticket that will not be fixed until this Ignore can be removed. You can reference that ticket in the Ignore comment. I think it is okay for that to be GEODE-8577. You just need to be careful to not mark GEODE-8577 as fixed when you push this ignore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5593: GEODE-8577: PubSubNativeRedisAcceptanceTest is flaky

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #5593:
URL: https://github.com/apache/geode/pull/5593#discussion_r499962902



##########
File path: geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubNativeRedisAcceptanceTest.java
##########
@@ -16,9 +16,11 @@
 package org.apache.geode.redis.internal.executor.pubsub;
 
 import org.junit.ClassRule;
+import org.junit.Ignore;
 
 import org.apache.geode.NativeRedisTestRule;
 
+@Ignore

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org