You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhan Reddy <mr...@gmail.com> on 2017/03/08 07:30:43 UTC

Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57412/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20353
    https://issues.apache.org/jira/browse/AMBARI-20353


Repository: ambari


Description
-------

Logger added to log exception while steaming the output


Diffs
-----

  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 9bf2f90 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 0b9adda 


Diff: https://reviews.apache.org/r/57412/diff/1/


Testing
-------

Manual


Thanks,

Madhan Reddy


Re: Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57412/#review168268
-----------------------------------------------------------




contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
Line 24 (original), 24 (patched)
<https://reviews.apache.org/r/57412/#comment240475>

    Do not use wild card imports.


- Gaurav Nagar


On March 8, 2017, 7:30 a.m., Madhan Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57412/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 7:30 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20353
>     https://issues.apache.org/jira/browse/AMBARI-20353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Logger added to log exception while steaming the output
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 9bf2f90 
>   contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 0b9adda 
> 
> 
> Diff: https://reviews.apache.org/r/57412/diff/1/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>


Re: Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57412/#review168275
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On March 8, 2017, 11:10 a.m., Madhan Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57412/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 11:10 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20353
>     https://issues.apache.org/jira/browse/AMBARI-20353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Logger added to log exception while steaming the output
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 9bf2f90 
>   contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 0b9adda 
> 
> 
> Diff: https://reviews.apache.org/r/57412/diff/2/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>


Re: Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57412/#review168274
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On March 8, 2017, 11:10 a.m., Madhan Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57412/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 11:10 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20353
>     https://issues.apache.org/jira/browse/AMBARI-20353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Logger added to log exception while steaming the output
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 9bf2f90 
>   contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 0b9adda 
> 
> 
> Diff: https://reviews.apache.org/r/57412/diff/2/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>


Re: Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path

Posted by Madhan Reddy <mr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57412/
-----------------------------------------------------------

(Updated March 8, 2017, 11:10 a.m.)


Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Changes
-------

Removed wild card imports.


Bugs: AMBARI-20353
    https://issues.apache.org/jira/browse/AMBARI-20353


Repository: ambari


Description
-------

Logger added to log exception while steaming the output


Diffs (updated)
-----

  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 9bf2f90 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 0b9adda 


Diff: https://reviews.apache.org/r/57412/diff/2/

Changes: https://reviews.apache.org/r/57412/diff/1-2/


Testing
-------

Manual


Thanks,

Madhan Reddy


Re: Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57412/#review168253
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On March 8, 2017, 7:30 a.m., Madhan Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57412/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 7:30 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20353
>     https://issues.apache.org/jira/browse/AMBARI-20353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Logger added to log exception while steaming the output
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 9bf2f90 
>   contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 0b9adda 
> 
> 
> Diff: https://reviews.apache.org/r/57412/diff/1/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>