You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by pn...@apache.org on 2021/04/30 14:42:55 UTC
[flink] 01/02: [hotfix][network] Remove unused method
BufferPool#getSubpartitionBufferRecyclers
This is an automated email from the ASF dual-hosted git repository.
pnowojski pushed a commit to branch release-1.13
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 65319b256c8b2f13db17388a12844c55d018ee97
Author: Piotr Nowojski <pi...@gmail.com>
AuthorDate: Fri Apr 23 11:58:26 2021 +0200
[hotfix][network] Remove unused method BufferPool#getSubpartitionBufferRecyclers
---
.../org/apache/flink/runtime/io/network/buffer/BufferPool.java | 2 --
.../apache/flink/runtime/io/network/buffer/LocalBufferPool.java | 7 -------
.../apache/flink/runtime/io/network/buffer/NoOpBufferPool.java | 8 --------
3 files changed, 17 deletions(-)
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferPool.java b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferPool.java
index baec302..80d6e31 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferPool.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferPool.java
@@ -61,6 +61,4 @@ public interface BufferPool extends BufferProvider, BufferRecycler {
/** Returns the number of used buffers of this buffer pool. */
int bestEffortGetNumOfUsedBuffers();
-
- BufferRecycler[] getSubpartitionBufferRecyclers();
}
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
index c50da97..6748504 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
@@ -18,7 +18,6 @@
package org.apache.flink.runtime.io.network.buffer;
-import org.apache.flink.annotation.VisibleForTesting;
import org.apache.flink.core.memory.MemorySegment;
import org.apache.flink.runtime.io.network.buffer.BufferListener.NotificationResult;
import org.apache.flink.util.ExceptionUtils;
@@ -659,12 +658,6 @@ class LocalBufferPool implements BufferPool {
return numberOfRequestedMemorySegments >= currentPoolSize;
}
- @VisibleForTesting
- @Override
- public BufferRecycler[] getSubpartitionBufferRecyclers() {
- return subpartitionBufferRecyclers;
- }
-
private static class SubpartitionBufferRecycler implements BufferRecycler {
private int channel;
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NoOpBufferPool.java b/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NoOpBufferPool.java
index 9de2bea..b93de38 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NoOpBufferPool.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NoOpBufferPool.java
@@ -22,8 +22,6 @@ package org.apache.flink.runtime.io.network.buffer;
import org.apache.flink.core.memory.MemorySegment;
-import javax.annotation.Nullable;
-
import java.util.concurrent.CompletableFuture;
/** No-op implementation of {@link BufferPool}. */
@@ -98,12 +96,6 @@ public class NoOpBufferPool implements BufferPool {
throw new UnsupportedOperationException();
}
- @Nullable
- @Override
- public BufferRecycler[] getSubpartitionBufferRecyclers() {
- return new BufferRecycler[0];
- }
-
@Override
public void recycle(MemorySegment memorySegment) {
throw new UnsupportedOperationException();