You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/21 01:58:22 UTC

[GitHub] [apisix] dickens7 commented on a diff in pull request #7252: fix(skywalking-logger, error-log-logger): skywalking service_instance_name $hostname is supported

dickens7 commented on code in PR #7252:
URL: https://github.com/apache/apisix/pull/7252#discussion_r902097188


##########
apisix/plugins/error-log-logger.lua:
##########
@@ -180,10 +180,15 @@ local function send_to_skywalking(log_message)
     httpc:set_timeout(config.timeout * 1000)
 
     local entries = {}
+    local serviceInstanceName = config.skywalking.service_instance_name

Review Comment:
   Yes, we should use snake case naming



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org