You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2008/11/17 03:18:44 UTC

[jira] Created: (LUCENE-1457) There are a few binary search implmentations in lucene that suffer from a now well known overflow bug

There are a few binary search implmentations in lucene that suffer from a now well known overflow bug
-----------------------------------------------------------------------------------------------------

                 Key: LUCENE-1457
                 URL: https://issues.apache.org/jira/browse/LUCENE-1457
             Project: Lucene - Java
          Issue Type: Bug
            Reporter: Mark Miller
            Priority: Trivial


http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html

The places I see it are:

MultiSearcher.subSearcher(int)
TermInfosReader.getIndexOffset(Term)
MultiSegmentReader.readerIndex(int, int[], int)
MergeDocIDRemapper.remap(int)

I havn't taken much time to consider how likely any of these are to overflow. The values being averaged would have to be very large. That would rule out possible problems for at least a couple of these, but how about something like the MergeDocIDRemapper? Is there a document number that could be reached that has a chance of triggering this bug? If not we can close this and have a record of looking into it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1457) There are a few binary search implmentations in lucene that suffer from a now well known overflow bug

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-1457:
---------------------------------------

    Fix Version/s: 2.4.1

> There are a few binary search implmentations in lucene that suffer from a now well known overflow bug
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1457
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1457
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Priority: Trivial
>             Fix For: 2.4.1, 2.9
>
>
> http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html
> The places I see it are:
> MultiSearcher.subSearcher(int)
> TermInfosReader.getIndexOffset(Term)
> MultiSegmentReader.readerIndex(int, int[], int)
> MergeDocIDRemapper.remap(int)
> I havn't taken much time to consider how likely any of these are to overflow. The values being averaged would have to be very large. That would rule out possible problems for at least a couple of these, but how about something like the MergeDocIDRemapper? Is there a document number that could be reached that has a chance of triggering this bug? If not we can close this and have a record of looking into it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1457) There are a few binary search implmentations in lucene that suffer from a now well known overflow bug

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1457.
----------------------------------------

    Resolution: Fixed

Committed revision 745798 on 2.4 branch.

> There are a few binary search implmentations in lucene that suffer from a now well known overflow bug
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1457
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1457
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Priority: Trivial
>             Fix For: 2.4.1, 2.9
>
>
> http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html
> The places I see it are:
> MultiSearcher.subSearcher(int)
> TermInfosReader.getIndexOffset(Term)
> MultiSegmentReader.readerIndex(int, int[], int)
> MergeDocIDRemapper.remap(int)
> I havn't taken much time to consider how likely any of these are to overflow. The values being averaged would have to be very large. That would rule out possible problems for at least a couple of these, but how about something like the MergeDocIDRemapper? Is there a document number that could be reached that has a chance of triggering this bug? If not we can close this and have a record of looking into it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1457) There are a few binary search implmentations in lucene that suffer from a now well known overflow bug

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1457.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.9

Committed revision 723149.

I fixed these cases, plus one more in FieldCache.  Thanks Mark!

> There are a few binary search implmentations in lucene that suffer from a now well known overflow bug
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1457
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1457
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Priority: Trivial
>             Fix For: 2.9
>
>
> http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html
> The places I see it are:
> MultiSearcher.subSearcher(int)
> TermInfosReader.getIndexOffset(Term)
> MultiSegmentReader.readerIndex(int, int[], int)
> MergeDocIDRemapper.remap(int)
> I havn't taken much time to consider how likely any of these are to overflow. The values being averaged would have to be very large. That would rule out possible problems for at least a couple of these, but how about something like the MergeDocIDRemapper? Is there a document number that could be reached that has a chance of triggering this bug? If not we can close this and have a record of looking into it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org