You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Mandar Ambawane <ma...@freestoneinfotech.com> on 2020/05/27 09:58:14 UTC
Review Request 72546: ATLAS-3813 Import-.sh script shows
wrong
message of Import success even when there are no database/table/topic are
imported in the System
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72546/
-----------------------------------------------------------
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3813
https://issues.apache.org/jira/browse/ATLAS-3813
Repository: atlas
Description
-------
While importing Hive-data from the file, if file has db names and table names which are not in the Hive. Application still shows message as "Hive Meta Data imported successfully!!!"
While importing Kafka-Topic data from the file, if file has Topic names which are not present in Kafka. Application still shows message as "Kafka Data Model imported successfully!!!"
Diffs
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java eb691dc
addons/kafka-bridge/pom.xml 7b95aa3
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java 40b1fee
Diff: https://reviews.apache.org/r/72546/diff/1/
Testing
-------
Thanks,
Mandar Ambawane
Re: Review Request 72546: ATLAS-3813 Import-.sh script
shows
wrong message of Import success even when there are no database/table/topic
are imported in the System
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72546/
-----------------------------------------------------------
(Updated June 2, 2020, 1:35 p.m.)
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Changes done for: If atleast one metadata out of listed metadatas in the file is imported, then show message as Successful.
Bugs: ATLAS-3813
https://issues.apache.org/jira/browse/ATLAS-3813
Repository: atlas
Description
-------
While importing Hive-data from the file, if file has db names and table names which are not in the Hive. Application still shows message as "Hive Meta Data imported successfully!!!"
While importing Kafka-Topic data from the file, if file has Topic names which are not present in Kafka. Application still shows message as "Kafka Data Model imported successfully!!!"
Diffs (updated)
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java eb691dc
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java 40b1fee
Diff: https://reviews.apache.org/r/72546/diff/4/
Changes: https://reviews.apache.org/r/72546/diff/3-4/
Testing
-------
PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1920/console
PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1922/console
PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1940/console
Thanks,
Mandar Ambawane
Re: Review Request 72546: ATLAS-3813 Import-.sh script
shows
wrong message of Import success even when there are no database/table/topic
are imported in the System
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72546/
-----------------------------------------------------------
(Updated June 1, 2020, 6:35 p.m.)
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Addressed review comments
Bugs: ATLAS-3813
https://issues.apache.org/jira/browse/ATLAS-3813
Repository: atlas
Description
-------
While importing Hive-data from the file, if file has db names and table names which are not in the Hive. Application still shows message as "Hive Meta Data imported successfully!!!"
While importing Kafka-Topic data from the file, if file has Topic names which are not present in Kafka. Application still shows message as "Kafka Data Model imported successfully!!!"
Diffs (updated)
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java eb691dc
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java 40b1fee
Diff: https://reviews.apache.org/r/72546/diff/3/
Changes: https://reviews.apache.org/r/72546/diff/2-3/
Testing
-------
PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1920/console
PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1922/console
Thanks,
Mandar Ambawane
Re: Review Request 72546: ATLAS-3813 Import-.sh script
shows
wrong message of Import success even when there are no database/table/topic
are imported in the System
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72546/#review220901
-----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Lines 306 (patched)
<https://reviews.apache.org/r/72546/#comment309618>
'importCount' ignores successfull database import. If valid database with no tables exists, importCount returns 0. Please review.
- Sarath Subramanian
On May 27, 2020, 2:58 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72546/
> -----------------------------------------------------------
>
> (Updated May 27, 2020, 2:58 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3813
> https://issues.apache.org/jira/browse/ATLAS-3813
>
>
> Repository: atlas
>
>
> Description
> -------
>
> While importing Hive-data from the file, if file has db names and table names which are not in the Hive. Application still shows message as "Hive Meta Data imported successfully!!!"
>
> While importing Kafka-Topic data from the file, if file has Topic names which are not present in Kafka. Application still shows message as "Kafka Data Model imported successfully!!!"
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java eb691dc
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java 40b1fee
>
>
> Diff: https://reviews.apache.org/r/72546/diff/2/
>
>
> Testing
> -------
>
> PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1920/console
>
> PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1922/console
>
>
> Thanks,
>
> Mandar Ambawane
>
>