You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2024/09/24 07:31:48 UTC
[PR] GH-40410: [C++][CI] Try disabling hanging S3 test on macOS [arrow]
pitrou opened a new pull request, #44211:
URL: https://github.com/apache/arrow/pull/44211
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40410: [C++][CI] Disable hanging S3 test on macOS [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44211:
URL: https://github.com/apache/arrow/pull/44211#issuecomment-3547048239
Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40410: [C++][CI] Disable hanging S3 test on macOS [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #44211:
URL: https://github.com/apache/arrow/pull/44211#issuecomment-2372646964
I liked your idea here and did a bit of research. Apparently CTest can be configured to [send a custom signal](https://cmake.org/cmake/help/latest/prop_test/TIMEOUT_SIGNAL_NAME.html) to a test that would otherwise be SIGKILL'd, though you can't directly send SIGSEGV,
```cmake
set_tests_properties(YourTest PROPERTIES
TIMEOUT 1
TIMEOUT_SIGNAL_NAME SIGUSR1
)
```
Since macOS writes crash logs to `~/Library/Logs/DiagnosticReports` automatically, I set up a [test project](https://github.com/amoeba/ctest-example-crash-on-timeout) with a test executable that catches SIGUSR1 and crashes, thus writing a log. I tried to adapt that approach to the PR here but I haven't successfully caught the SIGUSR1 from test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40410: [C++][CI] Disable hanging S3 test on macOS [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed pull request #44211: GH-40410: [C++][CI] Disable hanging S3 test on macOS
URL: https://github.com/apache/arrow/pull/44211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40410: [C++][CI] Disable hanging S3 test on macOS [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #44211:
URL: https://github.com/apache/arrow/pull/44211#issuecomment-2372136070
That feels about as confusing and inconsistent as my testing. I'd say you'd need to have at least 5-10 successful CI runs to know for sure the issue has been resolved. One thing that doesn't really make sense is why we wouldn't be able to reliably reproduce the timeout after ssh'ing into the same VM instance that originally timed out on CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40410: [C++][CI] Disable hanging S3 test on macOS [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44211:
URL: https://github.com/apache/arrow/pull/44211#issuecomment-2371981555
And now that I added a core dump on timeout, I fail reproducing the timeout on my fork...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40410: [C++][CI] Disable hanging S3 test on macOS [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44211:
URL: https://github.com/apache/arrow/pull/44211#issuecomment-2370633884
But another run seems to hang again:
https://github.com/pitrou/arrow/actions/runs/11009485782/job/30569246602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40410: [C++][CI] Disable hanging S3 test on macOS [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44211:
URL: https://github.com/apache/arrow/pull/44211#issuecomment-2371139175
So, for some unknown reason, `arrow-s3fs-test` sometimes still times out on my fork `pitrou/arrow`, but not on this repo `apache/arrow`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40410: [C++][CI] Try disabling hanging S3 test on macOS [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44211:
URL: https://github.com/apache/arrow/pull/44211#issuecomment-2370591740
It seems that this allows `arrow-s3fs-test` to pass on ARM64 macOS CI. @amoeba
https://github.com/apache/arrow/actions/runs/11009486358/job/30569264450?pr=44211#step:13:249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org